From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD8F4C433DB for ; Fri, 26 Mar 2021 14:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7ED3E619C9 for ; Fri, 26 Mar 2021 14:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbhCZOtP (ORCPT ); Fri, 26 Mar 2021 10:49:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:53434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbhCZOso (ORCPT ); Fri, 26 Mar 2021 10:48:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AFF2561A05; Fri, 26 Mar 2021 14:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616770124; bh=Sn21efNseA5j0bpRvtff1pm/MoN2WZ/SnjDGYElzwFE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sSzA6sLwrXyYAqyOAE42+KoRWgWZNletaWCW0M2nAfyD1YQwB7KUTJM12pdwEElxN MUNF6hvY8QY2sydd3OEhHGQ8qM21rAIPm1EryDEkUXT1nN1cNxOmNJPGJuQKicefts HX9fw5m0E7tb2If9u+T9CAtkBDQ+nqk8b4BXlXxg= Date: Fri, 26 Mar 2021 15:48:41 +0100 From: Greg Kroah-Hartman To: Sebastian Reichel Cc: Matti Vaittinen , Matti Vaittinen , Hans de Goede , MyungJoo Ham , Chanwoo Choi , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/2] power: supply: axp20x_usb_power: fix work-queue init Message-ID: References: <20210324102506.3ta2zstmrwq4wswb@earth.universe> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324102506.3ta2zstmrwq4wswb@earth.universe> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 11:25:06AM +0100, Sebastian Reichel wrote: > Hi, > > On Wed, Mar 24, 2021 at 11:21:34AM +0200, Matti Vaittinen wrote: > > The commit 6d0c5de2fd84 > > ("power: supply: Clean-up few drivers by using managed work init") > > Re-introduced wrong order of initializing work-queue and requesting > > the IRQs which was originally fixed by the commit b5e8642ed95f > > ("power: supply: axp20x_usb_power: Init work before enabling IRQs") > > > > In addition this caused the work queue to be initialized twice. > > > > Fix it again. > > > > Fixes: 6d0c5de2fd84 ("power: supply: Clean-up few drivers by using managed work init") > > > > Signed-off-by: Matti Vaittinen > > Reported-by: Chen-Yu Tsai > > --- > > Acked-by: Sebastian Reichel > > Needs to be merged by Greg, since I do not have 6d0c5de2fd84 in > my tree. Now merged, thanks. greg k-h