* [PATCH] Staging: rtl8723bs: remove obsolete comments
@ 2021-03-24 19:47 Marco Cesati
2021-03-26 14:04 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Marco Cesati @ 2021-03-24 19:47 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Hans de Goede, Larry Finger, Dan Carpenter, linux-staging
Remove some obsolete comments in the staging/rtl8723bs driver.
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
---
drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 2 --
drivers/staging/rtl8723bs/hal/odm.h | 4 ----
drivers/staging/rtl8723bs/include/hal_com_h2c.h | 5 -----
3 files changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h b/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
index 08172cc38f09..194db3904982 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
+++ b/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h
@@ -198,8 +198,6 @@ enum btc_wifi_pnp {
BTC_WIFI_PNP_MAX
};
-/* for 8723b-d cut large current issue */
-
/* defined for BFP_BTC_GET */
enum btc_get_type {
/* type bool */
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 956357abfcaf..6595a5cc972b 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -1155,10 +1155,6 @@ enum dm_rf_e { /* tag_RF_Type_Definition */
RF_MAX = 2,
};
-/* 3 =========================================================== */
-/* 3 Antenna Diversity */
-/* 3 =========================================================== */
-
/* Maximal number of antenna detection mechanism needs to perform, added by Roger, 2011.12.28. */
#define MAX_ANTENNA_DETECTION_CNT 10
diff --git a/drivers/staging/rtl8723bs/include/hal_com_h2c.h b/drivers/staging/rtl8723bs/include/hal_com_h2c.h
index c7c2ff6c83b1..24cd9415fa95 100644
--- a/drivers/staging/rtl8723bs/include/hal_com_h2c.h
+++ b/drivers/staging/rtl8723bs/include/hal_com_h2c.h
@@ -7,11 +7,6 @@
#ifndef __COMMON_H2C_H__
#define __COMMON_H2C_H__
-/* */
-/* H2C CMD DEFINITION ------------------------------------------------ */
-/* */
-/* 88e, 8723b, 8812, 8821, 92e use the same FW code base */
-
#define H2C_RSVDPAGE_LOC_LEN 5
#define H2C_MEDIA_STATUS_RPT_LEN 3
#define H2C_KEEP_ALIVE_CTRL_LEN 2
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rtl8723bs: remove obsolete comments
2021-03-24 19:47 [PATCH] Staging: rtl8723bs: remove obsolete comments Marco Cesati
@ 2021-03-26 14:04 ` Greg Kroah-Hartman
2021-03-26 15:39 ` Marco Cesati
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2021-03-26 14:04 UTC (permalink / raw)
To: Marco Cesati; +Cc: Hans de Goede, Larry Finger, Dan Carpenter, linux-staging
On Wed, Mar 24, 2021 at 08:47:21PM +0100, Marco Cesati wrote:
> Remove some obsolete comments in the staging/rtl8723bs driver.
>
> Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Also does not apply :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rtl8723bs: remove obsolete comments
2021-03-26 14:04 ` Greg Kroah-Hartman
@ 2021-03-26 15:39 ` Marco Cesati
0 siblings, 0 replies; 3+ messages in thread
From: Marco Cesati @ 2021-03-26 15:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Hans de Goede, Larry Finger, Dan Carpenter, linux-staging
On Fri, Mar 26, 2021 at 03:04:56PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 24, 2021 at 08:47:21PM +0100, Marco Cesati wrote:
> > Remove some obsolete comments in the staging/rtl8723bs driver.
> >
> > Signed-off-by: Marco Cesati <marcocesati@gmail.com>
>
> Also does not apply :(
Yeah, it was supposed to be applied on top of the patch set
"remove unreferenced enums" (alternative to the patch set
"remove named enums"), which you applied
Sorry.
Marco
----
Marco Cesati, PhD
Dept. of Civil Engineering and Computer Science Engineering
Univ. of Rome Tor Vergata
via del Politecnico 1, I-00133 Rome, Italy
Tel. +39 06 7259 7389
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-26 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 19:47 [PATCH] Staging: rtl8723bs: remove obsolete comments Marco Cesati
2021-03-26 14:04 ` Greg Kroah-Hartman
2021-03-26 15:39 ` Marco Cesati
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.