From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9377EC433E6 for ; Tue, 16 Mar 2021 14:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E3E65070 for ; Tue, 16 Mar 2021 14:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235925AbhCPOEe (ORCPT ); Tue, 16 Mar 2021 10:04:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44552 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235403AbhCPOER (ORCPT ); Tue, 16 Mar 2021 10:04:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615903456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZNEQWnU1MKUmFvt5yn1z/1Cxme6xTcqchzQaFGYGPg=; b=KFm7mFyCM+Zwd+7uOiukQr79O7gMrthNwakUngbmFTyL93PnfPmxPLGQlFPfwzPXhuDw/X ppu307YXu7vxFwxutgd97VeLbynFyZEvInz7xmyCTD+taoJGBAYHvQ2gxFnhbDcbnq+dDv 1LcblOYiXzMoMRu9mGaKfsNDKXwAcUA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-BaZQag2UOUek8MRyCKd6vw-1; Tue, 16 Mar 2021 10:04:12 -0400 X-MC-Unique: BaZQag2UOUek8MRyCKd6vw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A90492508; Tue, 16 Mar 2021 14:04:10 +0000 (UTC) Received: from krava (unknown [10.40.193.217]) by smtp.corp.redhat.com (Postfix) with SMTP id 028715D9D3; Tue, 16 Mar 2021 14:04:07 +0000 (UTC) Date: Tue, 16 Mar 2021 15:04:07 +0100 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2 11/27] perf parse-events: Support hardware events inside PMU Message-ID: References: <20210311070742.9318-1-yao.jin@linux.intel.com> <20210311070742.9318-12-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 09:49:42AM +0800, Jin, Yao wrote: SNIP > > Performance counter stats for 'system wide': > > 136,655,302 cpu_core/branch-instructions/ > > 1.003171561 seconds time elapsed > > So we need special rules for both cycles and branches. > > The worse thing is, we also need to process the hardware cache events. > > # ./perf stat -e cpu_core/LLC-loads/ > event syntax error: 'cpu_core/LLC-loads/' > \___ unknown term 'LLC-loads' for pmu 'cpu_core' > > valid terms: event,pc,edge,offcore_rsp,ldlat,inv,umask,frontend,cmask,config,config1,config2,name,period,percore > > Initial error: > event syntax error: 'cpu_core/LLC-loads/' > \___ unknown term 'LLC-loads' for pmu 'cpu_core' > > If we use special rules for establishing all event mapping, that looks too much. :( hmmm but wait, currently we do not support events like this: 'cpu/cycles/' 'cpu/branches/' the pmu style accepts only 'events' or 'format' terms within // we made hw events like 'cycles','instructions','branches' special to be used without the pmu so why do we need to support cpu_code/cycles/ ? jirka