From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1BBC433E6 for ; Wed, 17 Mar 2021 04:27:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B5AE64F0F for ; Wed, 17 Mar 2021 04:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbhCQE0c (ORCPT ); Wed, 17 Mar 2021 00:26:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:59912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbhCQEZ7 (ORCPT ); Wed, 17 Mar 2021 00:25:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 27F3764F9E; Wed, 17 Mar 2021 04:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615955158; bh=b0+guY3uHI/7UugdBIJZaedLb8084zSH7Fj2VTny2X0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZnTO7xz3vXP2Hf3iarFYTkOy0PTS63Wwsd6gQE4Sklk4G9sX/pd5jC78A3wO+QrNo rCOBENUMFbAvxpj2Bdkrls0VFfqJ3FiRzw45r4MCdpzcC0vFkP1fXhlj6N+hod6RhI 0caOQfvz+18hHQu6dcxqShjZ0CjLMxgyf1on3dpS7pKxBmpnbDF3PIoro33h5aAdnu iiOJRlTEDqLRVzUN3V4iuKv8Vd6EvxHP82AN3+bG7xP81PHIujuNKe9bWWsBO11ak1 0YcZEJDZNUQRdHtCvJDAz+T+800RykOSqCTdtghpS00lMdv1T/OxaLn07ALduFYk0W htpuRlHqcfXhw== Date: Wed, 17 Mar 2021 06:25:54 +0200 From: Leon Romanovsky To: =?iso-8859-1?B?Suly9G1l?= Pouiller Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , devicetree@vger.kernel.org, Rob Herring , linux-mmc@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Ulf Hansson Subject: Re: [PATCH v5 03/24] wfx: add Makefile/Kconfig Message-ID: References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <20210315132501.441681-4-Jerome.Pouiller@silabs.com> <1718324.Ee3sdLpQUQ@pc-42> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1718324.Ee3sdLpQUQ@pc-42> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Mar 15, 2021 at 05:21:35PM +0100, Jérôme Pouiller wrote: > Hi Leon, > > On Monday 15 March 2021 16:11:52 CET Leon Romanovsky wrote: > > On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > > Signed-off-by: Jérôme Pouiller > > > --- > > > drivers/net/wireless/silabs/wfx/Kconfig | 12 +++++++++++ > > > drivers/net/wireless/silabs/wfx/Makefile | 26 ++++++++++++++++++++++++ > > > 2 files changed, 38 insertions(+) > > > create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig > > > create mode 100644 drivers/net/wireless/silabs/wfx/Makefile > > > > > > diff --git a/drivers/net/wireless/silabs/wfx/Kconfig b/drivers/net/wireless/silabs/wfx/Kconfig > > > new file mode 100644 > > > index 000000000000..3be4b1e735e1 > > > --- /dev/null > > > +++ b/drivers/net/wireless/silabs/wfx/Kconfig > > > @@ -0,0 +1,12 @@ > > > +config WFX > > > + tristate "Silicon Labs wireless chips WF200 and further" > > > + depends on MAC80211 > > > + depends on MMC || !MMC # do not allow WFX=y if MMC=m > > > + depends on (SPI || MMC) > > > + help > > > + This is a driver for Silicons Labs WFxxx series (WF200 and further) > > > + chipsets. This chip can be found on SPI or SDIO buses. > > > + > > > + Silabs does not use a reliable SDIO vendor ID. So, to avoid conflicts, > > > + the driver won't probe the device if it is not also declared in the > > > + Device Tree. > > > diff --git a/drivers/net/wireless/silabs/wfx/Makefile b/drivers/net/wireless/silabs/wfx/Makefile > > > new file mode 100644 > > > index 000000000000..f399962c8619 > > > --- /dev/null > > > +++ b/drivers/net/wireless/silabs/wfx/Makefile > > > @@ -0,0 +1,26 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > + > > > +# Necessary for CREATE_TRACE_POINTS > > > +CFLAGS_debug.o = -I$(src) > > > > I wonder if it is still relevant outside of the staging tree. > > It seems this pattern is common in the main tree. You suggest to relocate > trace.h to include/trace/events? No, leave it as it. Sorry for the noise. Thanks > > -- > Jérôme Pouiller > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9262DC433E0 for ; Wed, 17 Mar 2021 04:26:03 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4517164FA7 for ; Wed, 17 Mar 2021 04:26:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4517164FA7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 12E7142FC1; Wed, 17 Mar 2021 04:26:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YhNh4T6FP3Jb; Wed, 17 Mar 2021 04:26:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 04046431EC; Wed, 17 Mar 2021 04:26:02 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 13C221BF34B for ; Wed, 17 Mar 2021 04:26:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0C4CF431EC for ; Wed, 17 Mar 2021 04:26:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gSvCidmVad9n for ; Wed, 17 Mar 2021 04:25:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5534142FC1 for ; Wed, 17 Mar 2021 04:25:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 27F3764F9E; Wed, 17 Mar 2021 04:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615955158; bh=b0+guY3uHI/7UugdBIJZaedLb8084zSH7Fj2VTny2X0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZnTO7xz3vXP2Hf3iarFYTkOy0PTS63Wwsd6gQE4Sklk4G9sX/pd5jC78A3wO+QrNo rCOBENUMFbAvxpj2Bdkrls0VFfqJ3FiRzw45r4MCdpzcC0vFkP1fXhlj6N+hod6RhI 0caOQfvz+18hHQu6dcxqShjZ0CjLMxgyf1on3dpS7pKxBmpnbDF3PIoro33h5aAdnu iiOJRlTEDqLRVzUN3V4iuKv8Vd6EvxHP82AN3+bG7xP81PHIujuNKe9bWWsBO11ak1 0YcZEJDZNUQRdHtCvJDAz+T+800RykOSqCTdtghpS00lMdv1T/OxaLn07ALduFYk0W htpuRlHqcfXhw== Date: Wed, 17 Mar 2021 06:25:54 +0200 From: Leon Romanovsky To: =?iso-8859-1?B?Suly9G1l?= Pouiller Subject: Re: [PATCH v5 03/24] wfx: add Makefile/Kconfig Message-ID: References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <20210315132501.441681-4-Jerome.Pouiller@silabs.com> <1718324.Ee3sdLpQUQ@pc-42> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1718324.Ee3sdLpQUQ@pc-42> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Ulf Hansson , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , "David S . Miller" , Kalle Valo Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Mar 15, 2021 at 05:21:35PM +0100, J=E9r=F4me Pouiller wrote: > Hi Leon, > > On Monday 15 March 2021 16:11:52 CET Leon Romanovsky wrote: > > On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote: > > > From: J=E9r=F4me Pouiller > > > > > > Signed-off-by: J=E9r=F4me Pouiller > > > --- > > > drivers/net/wireless/silabs/wfx/Kconfig | 12 +++++++++++ > > > drivers/net/wireless/silabs/wfx/Makefile | 26 ++++++++++++++++++++++= ++ > > > 2 files changed, 38 insertions(+) > > > create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig > > > create mode 100644 drivers/net/wireless/silabs/wfx/Makefile > > > > > > diff --git a/drivers/net/wireless/silabs/wfx/Kconfig b/drivers/net/wi= reless/silabs/wfx/Kconfig > > > new file mode 100644 > > > index 000000000000..3be4b1e735e1 > > > --- /dev/null > > > +++ b/drivers/net/wireless/silabs/wfx/Kconfig > > > @@ -0,0 +1,12 @@ > > > +config WFX > > > + tristate "Silicon Labs wireless chips WF200 and further" > > > + depends on MAC80211 > > > + depends on MMC || !MMC # do not allow WFX=3Dy if MMC=3Dm > > > + depends on (SPI || MMC) > > > + help > > > + This is a driver for Silicons Labs WFxxx series (WF200 and fu= rther) > > > + chipsets. This chip can be found on SPI or SDIO buses. > > > + > > > + Silabs does not use a reliable SDIO vendor ID. So, to avoid c= onflicts, > > > + the driver won't probe the device if it is not also declared = in the > > > + Device Tree. > > > diff --git a/drivers/net/wireless/silabs/wfx/Makefile b/drivers/net/w= ireless/silabs/wfx/Makefile > > > new file mode 100644 > > > index 000000000000..f399962c8619 > > > --- /dev/null > > > +++ b/drivers/net/wireless/silabs/wfx/Makefile > > > @@ -0,0 +1,26 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > + > > > +# Necessary for CREATE_TRACE_POINTS > > > +CFLAGS_debug.o =3D -I$(src) > > > > I wonder if it is still relevant outside of the staging tree. > > It seems this pattern is common in the main tree. You suggest to relocate > trace.h to include/trace/events? No, leave it as it. Sorry for the noise. Thanks > > -- > J=E9r=F4me Pouiller > > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel