From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB978C433DB for ; Wed, 17 Mar 2021 15:29:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C0FB64FBA for ; Wed, 17 Mar 2021 15:29:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C0FB64FBA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qmE6wCvj5O7gwXn7E6CWnsAGp4K7pC7C/QRrlFQJ5M4=; b=AIbczjiS5oQBSOqYo0jtiCJw5 TknzY8t3HbLJwnLbx21Ec7elH0scVl5kRtF59Zo4kxrNiELSOOfy9rRj/AsIZh6rQPoDfm4IP9knR LdaZk7+qM6DlBBp+NmWzg1JbRE6A5vpBnhA2TVYDL/DHMpO6MpyrHqUaSnr7RjIkYy66UK86+8I+O DuwVsTF2s3kXwy2jAbGkbiTLFZ2iJ2HAujGyZJCwIF98sDdDcxn1Lr7LaCZfQTVBX4LRnS3E0aDfy 3JWA0K9lTikE2ozOZTLXKPC0MpcDhIDqtrE/h9lGcBhH/R4DCif6nzWpYCdXOAaSGqIYHxEB32GC0 qI67RUV/w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMY5a-003RBO-3n; Wed, 17 Mar 2021 15:28:02 +0000 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.21]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMY5V-003RB2-Hr for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 15:28:00 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1615994875; cv=none; d=strato.com; s=strato-dkim-0002; b=SNqzTXx/b6qyDOno2EYVU3lyWcU/hwmEHBOmjLCFaLLIq/FjV5uAy1McG/RTSSa8W4 9/DSLcwEhEI4+newaxuJDUCpfjVvG1WMFvr4VeI+swfrhdyFhPxMEJOH+X8OXmH8t+zn pLs5gE7iUz7fUjkQlgVxdwRc6x8aMG6HCgzkjEJI/psvMI14smC9/JydKDWYUJmI/8iD JaMVd+x39+gNVVxEUdu2rZQktQJbZa228amxzlRneF16fGiiYl10XNdddI0BCuYQ42kc Pg2hdWvWq9y5BAY4TPNat0JyQSjk0Ous2fCmqNQBF+/nf4wlkUPi+/zkIcC+oiST9DdG Cbwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1615994875; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=/dxQuj106nA800QMoe8LAHmPpYk+ZY5YiT023IQ4KVs=; b=YJEiL8XQBDgvpGvpevPfClxzw4LdF8/PY+gyNdvpmmtlGJDKjkCclph0dqZL2Msiev W7v7x5uuhfeZXfPV441/XIIBEANwDR2rA/zSmNpBIOUuhD/2jAn/k07HE0L8Zm8jQT6F gO8gov5/Z0Rr/4pJEZzjT4bPkv/0HaZ3LavIvTOrnMOTmVTqI/5GFf3HAzxH2d0OUoom F/LdFSUDx+ggCuaLm/5PTkMrKQew4NC8iwMrYyAueeOPTNsywreZu16iFeo9J6/AXUMR hP2zbCozucuKLikQgAWxKCuRFGjM+6F4Kc/yUmsqTQQNrFdae3RhoZ2gHL2gf4Fe7Lkh Ma4Q== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1615994875; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=/dxQuj106nA800QMoe8LAHmPpYk+ZY5YiT023IQ4KVs=; b=imjBG0m66wQKHK9Opct9GQG+tm103zaIHILX9nqjza/tDmL1aGxsqSaM0D8vbBOnRq 1rEBood9M40bDzAC8ghNCHgLrpipbgUFeb12IU6qSEVSAYQPJirXFJIjpVw3TPtUD83p eDtI7adX6EBEQQ9Mci/ZMaFGeIvuHt+ljDdDyT/IJKZcPOHsi8DWwZ1EWgm5QM4a1rWu pmVZJMGoi4yWCsD28bbMFY+FXj7BSdd5hkMV27e+Gco7dVv/4N5l7p5vDDKNZKT7NPzH YXebz95BMZ+bDwIRiiR7u/qvnuKSO6Z0l6CzTQ3DVpeUefywdfivCo3iC5clh1w8N7xX lvXg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8j9IcvABg==" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.21.0 DYNA|AUTH) with ESMTPSA id 605792x2HFRtK47 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 17 Mar 2021 16:27:55 +0100 (CET) Date: Wed, 17 Mar 2021 16:27:42 +0100 From: Stephan Gerhold To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] ARM: dts: ux500: Fix BT+WLAN on Samsung phones Message-ID: References: <20210315110750.139610-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315110750.139610-1-linus.walleij@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_152757_683660_5CF4037F X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 15, 2021 at 12:07:50PM +0100, Linus Walleij wrote: > Some of the Samsung phones had set GPIO 215 as voltage > regulator GPIO, while in fact this is always on GPIO 222. > > Using GPIO 215 meant that the Bluetooth would not come > on properly since both WLAN and Bluetooth use GPIO 222 > to power up. The Bluetooth part refers to this GPIO > line as "shutdown-gpios" which is kind of true, but > fails to mention that it will also shut down the WLAN > when it is disabled, which was causing bugs. > Hmm, I'm a bit confused here. The datasheet for BCM4334 [1] that I was looking at back when I added WiFi/BT to samsung-golden says: "Section 22: Power-Up Sequence and Timing Note: The WL_REG_ON and BT_REG_ON signals are ORed in the BCM4334. [...] If two independent host GPIOs are used (one for WL_REG_ON and one for BT_REG_ON), then only one of the two signals needs to be high to enable the BCM4334 regulators." and the "Description of Control Signals" part after that repeats the same, and even shows diagrams that only one of them should be high to enable only WiFi or only BT. According to the schematics for samsung-golden: - GPIO215 goes to WL_REG_ON of BCM4334 - GPIO222 goes to BT_REG_ON of BCM4334 So I would say the device tree is correct the way it is, unless the datasheet is wrong... I wonder if there is some other problem here, I think WiFi/BT used to probe just fine on samsung-golden... Stephan [1]: https://www.cypress.com/file/298706/download _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel