From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9442C433DB for ; Thu, 18 Mar 2021 09:56:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3B2664F3B for ; Thu, 18 Mar 2021 09:56:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbhCRJ4P (ORCPT ); Thu, 18 Mar 2021 05:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbhCRJzr (ORCPT ); Thu, 18 Mar 2021 05:55:47 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FFD3C06174A for ; Thu, 18 Mar 2021 02:55:47 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 3B2EF2D8; Thu, 18 Mar 2021 10:55:46 +0100 (CET) Date: Thu, 18 Mar 2021 10:55:44 +0100 From: Joerg Roedel To: Robin Murphy Cc: iommu@lists.linux-foundation.org, dwmw2@infradead.org, baolu.lu@linux.intel.com, murphyt7@tcd.ie, john.garry@huawei.com, thunder.leizhen@huawei.com, will@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/dma: Resurrect the "forcedac" option Message-ID: References: <7eece8e0ea7bfbe2cd0e30789e0d46df573af9b0.1614961776.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7eece8e0ea7bfbe2cd0e30789e0d46df573af9b0.1614961776.git.robin.murphy@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 04:32:34PM +0000, Robin Murphy wrote: > In converting intel-iommu over to the common IOMMU DMA ops, it quietly > lost the functionality of its "forcedac" option. Since this is a handy > thing both for testing and for performance optimisation on certain > platforms, reimplement it under the common IOMMU parameter namespace. > > For the sake of fixing the inadvertent breakage of the Intel-specific > parameter, remove the dmar_forcedac remnants and hook it up as an alias > while documenting the transition to the new common parameter. > > Fixes: c588072bba6b ("iommu/vt-d: Convert intel iommu driver to the iommu ops") > Signed-off-by: Robin Murphy > --- > Documentation/admin-guide/kernel-parameters.txt | 15 ++++++++------- > drivers/iommu/dma-iommu.c | 13 ++++++++++++- > drivers/iommu/intel/iommu.c | 5 ++--- > include/linux/dma-iommu.h | 2 ++ > 4 files changed, 24 insertions(+), 11 deletions(-) Applied for v5.13, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BEDDC433DB for ; Thu, 18 Mar 2021 09:55:53 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDBF364F45 for ; Thu, 18 Mar 2021 09:55:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDBF364F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A428C841CE; Thu, 18 Mar 2021 09:55:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gg0Wshw7DJmU; Thu, 18 Mar 2021 09:55:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTP id 7DFD284168; Thu, 18 Mar 2021 09:55:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 443C4C000A; Thu, 18 Mar 2021 09:55:51 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7A718C0001 for ; Thu, 18 Mar 2021 09:55:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 54FB360650 for ; Thu, 18 Mar 2021 09:55:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gpHB138qMtn0 for ; Thu, 18 Mar 2021 09:55:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by smtp3.osuosl.org (Postfix) with ESMTPS id AC54160643 for ; Thu, 18 Mar 2021 09:55:48 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 3B2EF2D8; Thu, 18 Mar 2021 10:55:46 +0100 (CET) Date: Thu, 18 Mar 2021 10:55:44 +0100 From: Joerg Roedel To: Robin Murphy Subject: Re: [PATCH] iommu/dma: Resurrect the "forcedac" option Message-ID: References: <7eece8e0ea7bfbe2cd0e30789e0d46df573af9b0.1614961776.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7eece8e0ea7bfbe2cd0e30789e0d46df573af9b0.1614961776.git.robin.murphy@arm.com> Cc: will@kernel.org, linux-kernel@vger.kernel.org, murphyt7@tcd.ie, iommu@lists.linux-foundation.org, dwmw2@infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Mar 05, 2021 at 04:32:34PM +0000, Robin Murphy wrote: > In converting intel-iommu over to the common IOMMU DMA ops, it quietly > lost the functionality of its "forcedac" option. Since this is a handy > thing both for testing and for performance optimisation on certain > platforms, reimplement it under the common IOMMU parameter namespace. > > For the sake of fixing the inadvertent breakage of the Intel-specific > parameter, remove the dmar_forcedac remnants and hook it up as an alias > while documenting the transition to the new common parameter. > > Fixes: c588072bba6b ("iommu/vt-d: Convert intel iommu driver to the iommu ops") > Signed-off-by: Robin Murphy > --- > Documentation/admin-guide/kernel-parameters.txt | 15 ++++++++------- > drivers/iommu/dma-iommu.c | 13 ++++++++++++- > drivers/iommu/intel/iommu.c | 5 ++--- > include/linux/dma-iommu.h | 2 ++ > 4 files changed, 24 insertions(+), 11 deletions(-) Applied for v5.13, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu