From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Fri, 19 Mar 2021 10:04:26 +0100 Subject: [LTP] [PATCH v2 2/2] doc: Add Maintainer Patch Review Checklist In-Reply-To: References: <20210318181641.2062-1-pvorel@suse.cz> <20210318181641.2062-3-pvorel@suse.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it > Li Wang wrote: > > +Commit messages should have > >> + > >> +* Author's `Signed-off-by` tag > >> +* Committer's `Reviewed-by` or `Signed-off-by` tag > > Or adding `Acked-by:` also acceptable? > > I'm not sure what's the difference between Acked-by and Reviewed-by, > > but personally feel the Acked-by has more confidence in the reviewing. > > In my mind, > > `Acked-by` means: > > code review OK, compiled OK, executed OK, has confidence it OK for all > > arches > > `Reviewed-by` means: > > code review OK, compiled and executed OK just locally or optional, still room > > for improvement/discussion > Plz ignore my rough understanding, I find a precise description at kernel > process/submitting-patches.rst. > https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst#when-to-use-acked-by-cc-and-co-developed-by But you were right, I omit "tags". Maybe this? - Check also mailing lists for other reviewers / testers + Check also mailing lists for other reviewers / testers tags, notes and failure reports Kind regards, Petr