From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88B3C433DB for ; Fri, 19 Mar 2021 18:36:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D05661986 for ; Fri, 19 Mar 2021 18:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbhCSSfm (ORCPT ); Fri, 19 Mar 2021 14:35:42 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37648 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbhCSSfl (ORCPT ); Fri, 19 Mar 2021 14:35:41 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lNJyG-00BvSO-0r; Fri, 19 Mar 2021 19:35:40 +0100 Date: Fri, 19 Mar 2021 19:35:40 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix Message-ID: References: <20210319143149.823-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210319143149.823-1-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote: > We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane` > to mv88e6390_serdes_read() instead of MV88E6393X_PORT0_LANE. > > All other occurances in this function are using the `lane` variable. > > It seems I forgot to change it at this one place after refactoring. > > Signed-off-by: Marek Behún > Fixes: de776d0d316f7 ("net: dsa: mv88e6xxx: add support for ...") Reviewed-by: Andrew Lunn Andrew