From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F5A5C433E0 for ; Sun, 21 Mar 2021 04:44:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 544526193C for ; Sun, 21 Mar 2021 04:44:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbhCUEoO (ORCPT ); Sun, 21 Mar 2021 00:44:14 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45632 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229870AbhCUEnx (ORCPT ); Sun, 21 Mar 2021 00:43:53 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 12L4hiJR017790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 21 Mar 2021 00:43:45 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6DBC115C39CA; Sun, 21 Mar 2021 00:43:44 -0400 (EDT) Date: Sun, 21 Mar 2021 00:43:44 -0400 From: "Theodore Ts'o" To: Pan Bian Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: ext4: stop inode update before return Message-ID: References: <20210117085732.93788-1-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210117085732.93788-1-bianpan2016@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 17, 2021 at 12:57:32AM -0800, Pan Bian wrote: > The inode update should be stopped before returing the error code. > > Signed-off-by: Pan Bian Thanks, applied. - Ted