From: Peter Zijlstra <peterz@infradead.org>
To: Barret Rhoden <brho@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: sched: allow resubmits to queue_balance_callback()
Date: Mon, 22 Mar 2021 11:41:06 +0100 [thread overview]
Message-ID: <YFh0QjnoGPmbykyE@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210318195734.3579799-1-brho@google.com>
On Thu, Mar 18, 2021 at 03:57:34PM -0400, Barret Rhoden wrote:
> Prior to this commit, if you submitted the same callback_head twice, it
> would be enqueued twice, but only if it was the last callback on the
> list. The first time it was submitted, rq->balance_callback was NULL,
> so head->next is NULL. That defeated the check in
> queue_balance_callback().
>
> This commit changes the callback list such that whenever an item is on
> the list, its head->next is not NULL. The last element (first inserted)
> will point to itself. This allows us to detect and ignore any attempt
> to reenqueue a callback_head.
>
> Signed-off-by: Barret Rhoden <brho@google.com>
AFAICT you're patching dead code, please check a current tree.
next prev parent reply other threads:[~2021-03-22 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 19:57 sched: allow resubmits to queue_balance_callback() Barret Rhoden
2021-03-22 10:41 ` Peter Zijlstra [this message]
2021-03-22 18:43 ` [PATCH v2] " Barret Rhoden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFh0QjnoGPmbykyE@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=brho@google.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.