From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B76DDC433E6 for ; Tue, 23 Mar 2021 09:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83A63619C5 for ; Tue, 23 Mar 2021 09:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbhCWJnF (ORCPT ); Tue, 23 Mar 2021 05:43:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:53326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbhCWJme (ORCPT ); Tue, 23 Mar 2021 05:42:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 122E9619B8; Tue, 23 Mar 2021 09:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616492554; bh=qtCot0i39hBZ+nrGjK9DgAurtMlhpSE9CuHUJ91HGS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e2YAYnzmiidqkYDCWCXCnXLTObndQ+NnSnRIHuGZBf7flK2ucyeoqqEr5dr0Y1SWi aPebEEtlLlhYG+ydRXmYM7nzerrNoMLrTgmXHwjlf0NQo5KcMY+HQkfJblZss1oeL0 kUG6WTPr1L7aZG5hb/lgOk4Br5GcfcVFhJ8L6Kwc= Date: Tue, 23 Mar 2021 10:42:32 +0100 From: Greg KH To: Luiz Sampaio Cc: zbr@ioremap.net, rikard.falkeborn@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] w1: ds2438: adding support for accessing page1 registers Message-ID: References: <20210323024410.temxutbcfdswctz4@LuizSampaio-PC.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323024410.temxutbcfdswctz4@LuizSampaio-PC.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 11:44:10PM -0300, Luiz Sampaio wrote: > @@ -395,6 +483,8 @@ static BIN_ATTR_RO(vdd, 0/* real length varies */); > static struct bin_attribute *w1_ds2438_bin_attrs[] = { > &bin_attr_iad, > &bin_attr_page0, > + &bin_attr_page1, > + &bin_attr_offset, You are adding new sysfs files, but no new Documentation/ABI entries :( please fix that up for your next submission. thanks, greg k-h