* [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment
@ 2021-03-13 16:16 ` Abhishek C
0 siblings, 0 replies; 4+ messages in thread
From: Abhishek C @ 2021-03-13 16:16 UTC (permalink / raw)
To: gregkh
Cc: arve, tkjos, maco, joel, christian, hridya, surenb, devel,
linux-kernel, bkkarthik
Fixed alignment of multi-line comment.
Added a * for each line of the comment.
Signed-off-by: Abhishek C <astro.abhishek02@gmail.com>
---
drivers/android/binder.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index c119736ca56a..700719c58147 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
unsigned int size = _IOC_SIZE(cmd);
void __user *ubuf = (void __user *)arg;
- /*pr_info("binder_ioctl: %d:%d %x %lx\n",
- proc->pid, current->pid, cmd, arg);*/
+ /* pr_info("binder_ioctl: %d:%d %x %lx\n",
+ * proc->pid, current->pid, cmd, arg);
+ */
binder_selftest_alloc(&proc->alloc);
@@ -5750,8 +5751,8 @@ static int __init binder_init(void)
if (!IS_ENABLED(CONFIG_ANDROID_BINDERFS) &&
strcmp(binder_devices_param, "") != 0) {
/*
- * Copy the module_parameter string, because we don't want to
- * tokenize it in-place.
+ * Copy the module_parameter string, because we don't want to
+ * tokenize it in-place.
*/
device_names = kstrdup(binder_devices_param, GFP_KERNEL);
if (!device_names) {
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment
@ 2021-03-13 16:16 ` Abhishek C
0 siblings, 0 replies; 4+ messages in thread
From: Abhishek C @ 2021-03-13 16:16 UTC (permalink / raw)
To: gregkh
Cc: devel, tkjos, surenb, bkkarthik, linux-kernel, hridya, arve,
joel, maco, christian
Fixed alignment of multi-line comment.
Added a * for each line of the comment.
Signed-off-by: Abhishek C <astro.abhishek02@gmail.com>
---
drivers/android/binder.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index c119736ca56a..700719c58147 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
unsigned int size = _IOC_SIZE(cmd);
void __user *ubuf = (void __user *)arg;
- /*pr_info("binder_ioctl: %d:%d %x %lx\n",
- proc->pid, current->pid, cmd, arg);*/
+ /* pr_info("binder_ioctl: %d:%d %x %lx\n",
+ * proc->pid, current->pid, cmd, arg);
+ */
binder_selftest_alloc(&proc->alloc);
@@ -5750,8 +5751,8 @@ static int __init binder_init(void)
if (!IS_ENABLED(CONFIG_ANDROID_BINDERFS) &&
strcmp(binder_devices_param, "") != 0) {
/*
- * Copy the module_parameter string, because we don't want to
- * tokenize it in-place.
+ * Copy the module_parameter string, because we don't want to
+ * tokenize it in-place.
*/
device_names = kstrdup(binder_devices_param, GFP_KERNEL);
if (!device_names) {
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment
2021-03-13 16:16 ` Abhishek C
@ 2021-03-23 13:18 ` Greg KH
-1 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-03-23 13:18 UTC (permalink / raw)
To: Abhishek C
Cc: devel, tkjos, surenb, bkkarthik, linux-kernel, hridya, arve,
joel, maco, christian
On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote:
> Fixed alignment of multi-line comment.
> Added a * for each line of the comment.
>
> Signed-off-by: Abhishek C <astro.abhishek02@gmail.com>
> ---
> drivers/android/binder.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c119736ca56a..700719c58147 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> unsigned int size = _IOC_SIZE(cmd);
> void __user *ubuf = (void __user *)arg;
>
> - /*pr_info("binder_ioctl: %d:%d %x %lx\n",
> - proc->pid, current->pid, cmd, arg);*/
> + /* pr_info("binder_ioctl: %d:%d %x %lx\n",
> + * proc->pid, current->pid, cmd, arg);
> + */
This looks like left-over debugging code, and as-is, is formatted
properly.
Why not just delete it entirely? If someone needs debugging code, they
can add it back in.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment
@ 2021-03-23 13:18 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-03-23 13:18 UTC (permalink / raw)
To: Abhishek C
Cc: devel, tkjos, maco, bkkarthik, linux-kernel, joel, arve, hridya,
surenb, christian
On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote:
> Fixed alignment of multi-line comment.
> Added a * for each line of the comment.
>
> Signed-off-by: Abhishek C <astro.abhishek02@gmail.com>
> ---
> drivers/android/binder.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c119736ca56a..700719c58147 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> unsigned int size = _IOC_SIZE(cmd);
> void __user *ubuf = (void __user *)arg;
>
> - /*pr_info("binder_ioctl: %d:%d %x %lx\n",
> - proc->pid, current->pid, cmd, arg);*/
> + /* pr_info("binder_ioctl: %d:%d %x %lx\n",
> + * proc->pid, current->pid, cmd, arg);
> + */
This looks like left-over debugging code, and as-is, is formatted
properly.
Why not just delete it entirely? If someone needs debugging code, they
can add it back in.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-23 13:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 16:16 [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment Abhishek C
2021-03-13 16:16 ` Abhishek C
2021-03-23 13:18 ` Greg KH
2021-03-23 13:18 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.