From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E18C433C1 for ; Tue, 23 Mar 2021 13:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0D7861920 for ; Tue, 23 Mar 2021 13:20:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231547AbhCWNUD (ORCPT ); Tue, 23 Mar 2021 09:20:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:46956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbhCWNSy (ORCPT ); Tue, 23 Mar 2021 09:18:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F1B761925; Tue, 23 Mar 2021 13:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616505534; bh=Vs7PdDT7Zq32DdrSGItgF4jCKR5j3s25JM4aU1qJMaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lh8Jft0EnLBcj3gRmzp0I22GXzBoPBTmJFCTj7w6Ug3clmG1qOEo8spX5BPdMLKlA 5jERiCWFI1O2+QGkKmdIOnPRS8kWgsQs++WDWHxptbnIaoK+oioOU82Y/PWk/SDdoY Q4xyG37XO37oBT3uGnXXLKQ3TFsORA9dIeKsH1cM= Date: Tue, 23 Mar 2021 14:18:51 +0100 From: Greg KH To: Abhishek C Cc: devel@driverdev.osuosl.org, tkjos@android.com, surenb@google.com, bkkarthik@pesu.pes.edu, linux-kernel@vger.kernel.org, hridya@google.com, arve@android.com, joel@joelfernandes.org, maco@android.com, christian@brauner.io Subject: Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment Message-ID: References: <20210313161655.mu64qezxog4ghibq@astroabhi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210313161655.mu64qezxog4ghibq@astroabhi> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote: > Fixed alignment of multi-line comment. > Added a * for each line of the comment. > > Signed-off-by: Abhishek C > --- > drivers/android/binder.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index c119736ca56a..700719c58147 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > unsigned int size = _IOC_SIZE(cmd); > void __user *ubuf = (void __user *)arg; > > - /*pr_info("binder_ioctl: %d:%d %x %lx\n", > - proc->pid, current->pid, cmd, arg);*/ > + /* pr_info("binder_ioctl: %d:%d %x %lx\n", > + * proc->pid, current->pid, cmd, arg); > + */ This looks like left-over debugging code, and as-is, is formatted properly. Why not just delete it entirely? If someone needs debugging code, they can add it back in. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4D8C433DB for ; Tue, 23 Mar 2021 13:18:59 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADD4E619BA for ; Tue, 23 Mar 2021 13:18:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADD4E619BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5FBE3402E0; Tue, 23 Mar 2021 13:18:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xRUZ_TZ9D23p; Tue, 23 Mar 2021 13:18:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 5715F40374; Tue, 23 Mar 2021 13:18:57 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 13FC41BF331 for ; Tue, 23 Mar 2021 13:18:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0F5F34024F for ; Tue, 23 Mar 2021 13:18:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=linuxfoundation.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0CDlPqBZK4F5 for ; Tue, 23 Mar 2021 13:18:54 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp4.osuosl.org (Postfix) with ESMTPS id 66F2A40249 for ; Tue, 23 Mar 2021 13:18:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F1B761925; Tue, 23 Mar 2021 13:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616505534; bh=Vs7PdDT7Zq32DdrSGItgF4jCKR5j3s25JM4aU1qJMaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lh8Jft0EnLBcj3gRmzp0I22GXzBoPBTmJFCTj7w6Ug3clmG1qOEo8spX5BPdMLKlA 5jERiCWFI1O2+QGkKmdIOnPRS8kWgsQs++WDWHxptbnIaoK+oioOU82Y/PWk/SDdoY Q4xyG37XO37oBT3uGnXXLKQ3TFsORA9dIeKsH1cM= Date: Tue, 23 Mar 2021 14:18:51 +0100 From: Greg KH To: Abhishek C Subject: Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment Message-ID: References: <20210313161655.mu64qezxog4ghibq@astroabhi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210313161655.mu64qezxog4ghibq@astroabhi> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, tkjos@android.com, maco@android.com, bkkarthik@pesu.pes.edu, linux-kernel@vger.kernel.org, joel@joelfernandes.org, arve@android.com, hridya@google.com, surenb@google.com, christian@brauner.io Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote: > Fixed alignment of multi-line comment. > Added a * for each line of the comment. > > Signed-off-by: Abhishek C > --- > drivers/android/binder.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index c119736ca56a..700719c58147 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > unsigned int size = _IOC_SIZE(cmd); > void __user *ubuf = (void __user *)arg; > > - /*pr_info("binder_ioctl: %d:%d %x %lx\n", > - proc->pid, current->pid, cmd, arg);*/ > + /* pr_info("binder_ioctl: %d:%d %x %lx\n", > + * proc->pid, current->pid, cmd, arg); > + */ This looks like left-over debugging code, and as-is, is formatted properly. Why not just delete it entirely? If someone needs debugging code, they can add it back in. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel