All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabian Vogt <fabian@ritter-vogt.de>
Cc: linux-input@vger.kernel.org, dt.tangr@gmail.com
Subject: Re: [PATCH] input: nspire-keypad: enable interrupts only when opened
Date: Tue, 23 Mar 2021 10:47:55 -0700	[thread overview]
Message-ID: <YFopy9Ts4MGPZ+wj@google.com> (raw)
In-Reply-To: <3383725.iizBOSrK1V@linux-e202.suse.de>

On Tue, Mar 23, 2021 at 10:39:05AM +0100, Fabian Vogt wrote:
> The driver registers an interrupt handler in _probe, but didn't configure
> them until later when the _open function is called. In between, the keypad
> can fire an IRQ due to touchpad activity, which the handler ignores. This
> causes the kernel to disable the interrupt, blocking the keypad from
> working.
> 
> Fix this by disabling interrupts before registering the handler.
> Additionally, disable them in _close, so that they're only enabled while
> open.
> 
> Fixes: fc4f31461892 ("Input: add TI-Nspire keypad support")
> Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de>

Applied, thank you.

-- 
Dmitry

      reply	other threads:[~2021-03-23 17:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  9:39 [PATCH] input: nspire-keypad: enable interrupts only when opened Fabian Vogt
2021-03-23 17:47 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFopy9Ts4MGPZ+wj@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=dt.tangr@gmail.com \
    --cc=fabian@ritter-vogt.de \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.