* Re: [PATCH -next] usb: typec: tcpci_maxim: Make symbol 'max_tcpci_tcpci_write_table' static
2021-03-24 14:42 [PATCH -next] usb: typec: tcpci_maxim: Make symbol 'max_tcpci_tcpci_write_table' static 'Wei Yongjun
@ 2021-03-24 14:42 ` Guenter Roeck
2021-03-24 15:47 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-03-24 14:42 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Heikki Krogerus, Greg Kroah-Hartman, Badhri Jagan Sridharan,
linux-usb, kernel-janitors, Hulk Robot
On Wed, Mar 24, 2021 at 02:42:53PM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/usb/typec/tcpm/tcpci_maxim.c:55:34: warning:
> symbol 'max_tcpci_tcpci_write_table' was not declared. Should it be static?
>
> This symbol is not used outside of tcpci_maxim.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpci_maxim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 041a1c393594..df2505570f07 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -52,7 +52,7 @@ static const struct regmap_range max_tcpci_tcpci_range[] = {
> regmap_reg_range(0x00, 0x95)
> };
>
> -const struct regmap_access_table max_tcpci_tcpci_write_table = {
> +static const struct regmap_access_table max_tcpci_tcpci_write_table = {
> .yes_ranges = max_tcpci_tcpci_range,
> .n_yes_ranges = ARRAY_SIZE(max_tcpci_tcpci_range),
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] usb: typec: tcpci_maxim: Make symbol 'max_tcpci_tcpci_write_table' static
@ 2021-03-24 14:42 'Wei Yongjun
2021-03-24 14:42 ` Guenter Roeck
2021-03-24 15:47 ` Heikki Krogerus
0 siblings, 2 replies; 3+ messages in thread
From: 'Wei Yongjun @ 2021-03-24 14:42 UTC (permalink / raw)
To: weiyongjun1, Guenter Roeck, Heikki Krogerus, Greg Kroah-Hartman,
Badhri Jagan Sridharan
Cc: linux-usb, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
The sparse tool complains as follows:
drivers/usb/typec/tcpm/tcpci_maxim.c:55:34: warning:
symbol 'max_tcpci_tcpci_write_table' was not declared. Should it be static?
This symbol is not used outside of tcpci_maxim.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/usb/typec/tcpm/tcpci_maxim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
index 041a1c393594..df2505570f07 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
@@ -52,7 +52,7 @@ static const struct regmap_range max_tcpci_tcpci_range[] = {
regmap_reg_range(0x00, 0x95)
};
-const struct regmap_access_table max_tcpci_tcpci_write_table = {
+static const struct regmap_access_table max_tcpci_tcpci_write_table = {
.yes_ranges = max_tcpci_tcpci_range,
.n_yes_ranges = ARRAY_SIZE(max_tcpci_tcpci_range),
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: typec: tcpci_maxim: Make symbol 'max_tcpci_tcpci_write_table' static
2021-03-24 14:42 [PATCH -next] usb: typec: tcpci_maxim: Make symbol 'max_tcpci_tcpci_write_table' static 'Wei Yongjun
2021-03-24 14:42 ` Guenter Roeck
@ 2021-03-24 15:47 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2021-03-24 15:47 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Guenter Roeck, Greg Kroah-Hartman, Badhri Jagan Sridharan,
linux-usb, kernel-janitors, Hulk Robot
Wed, Mar 24, 2021 at 02:42:53PM +0000, 'Wei Yongjun kirjoitti:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/usb/typec/tcpm/tcpci_maxim.c:55:34: warning:
> symbol 'max_tcpci_tcpci_write_table' was not declared. Should it be static?
>
> This symbol is not used outside of tcpci_maxim.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_maxim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 041a1c393594..df2505570f07 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -52,7 +52,7 @@ static const struct regmap_range max_tcpci_tcpci_range[] = {
> regmap_reg_range(0x00, 0x95)
> };
>
> -const struct regmap_access_table max_tcpci_tcpci_write_table = {
> +static const struct regmap_access_table max_tcpci_tcpci_write_table = {
> .yes_ranges = max_tcpci_tcpci_range,
> .n_yes_ranges = ARRAY_SIZE(max_tcpci_tcpci_range),
> };
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-24 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 14:42 [PATCH -next] usb: typec: tcpci_maxim: Make symbol 'max_tcpci_tcpci_write_table' static 'Wei Yongjun
2021-03-24 14:42 ` Guenter Roeck
2021-03-24 15:47 ` Heikki Krogerus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.