From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D47C433DB for ; Thu, 25 Mar 2021 11:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D540F61A0D for ; Thu, 25 Mar 2021 11:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbhCYLXU (ORCPT ); Thu, 25 Mar 2021 07:23:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:58792 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbhCYLXO (ORCPT ); Thu, 25 Mar 2021 07:23:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 73BA3AC16; Thu, 25 Mar 2021 11:23:13 +0000 (UTC) Date: Thu, 25 Mar 2021 12:23:10 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Michal Hocko , Andrew Morton , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] mm,memory_hotplug: Allocate memmap from the added memory range Message-ID: References: <20210324101259.GB16560@linux> <3bc4168c-fd31-0c9a-44ac-88e25d524eef@redhat.com> <9591a0b8-c000-2f61-67a6-4402678fe50b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 12:08:43PM +0100, David Hildenbrand wrote: > As I said, having soemthing like > memory_block_online()/memory_block_offline() could be one way to tackle it. > We only support onlining/offlining of memory blocks and I ripped out all > code that was abusing online_pages/offline_pages ... > > So have memory_block_online() call online_pages() and do the accounting of > the vmemmap, with a big fat comment that sections are actually set > online/offline in online_pages/offline_pages(). Could be a simple cleanup on > top of this series ... I overlooked this in your previous reply. Yes, this looks like a middle-ground compromise and something I would definitely pick over the other options. If there is a consensus that that is the most straightforward way to go, I could try to code that up to see how it looks so we all have an idea. Thanks! -- Oscar Salvador SUSE L3