From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93B0C433B4 for ; Thu, 8 Apr 2021 09:25:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EB8F61130 for ; Thu, 8 Apr 2021 09:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230475AbhDHJ0D (ORCPT ); Thu, 8 Apr 2021 05:26:03 -0400 Received: from mga05.intel.com ([192.55.52.43]:59134 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhDHJ0B (ORCPT ); Thu, 8 Apr 2021 05:26:01 -0400 IronPort-SDR: 2FmBwaNonASUGSPlk5c1LrldDNcbqEVebWZyR/VdIg8PgEBcaQr0zblgHqOztxrtTvKqyGMjlR P3ip/ekOUd6A== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="278769636" X-IronPort-AV: E=Sophos;i="5.82,205,1613462400"; d="scan'208";a="278769636" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 02:25:50 -0700 IronPort-SDR: tDJZXqF5IHHMgCoJtA0Qj7X1TGJqBh7/6uaeZNO//dZgoWRkOHvuYtWkeITznzI/TyQaKeWlhO Ub8stqs13zAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,205,1613462400"; d="scan'208";a="519781454" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 08 Apr 2021 02:25:48 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 08 Apr 2021 12:25:47 +0300 Date: Thu, 8 Apr 2021 12:25:47 +0300 From: Heikki Krogerus To: Hans de Goede Cc: Zhen Lei , Guenter Roeck , Greg Kroah-Hartman , linux-usb , linux-kernel Subject: Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops' Message-ID: References: <20210407091540.2815-1-thunder.leizhen@huawei.com> <7e2797f7-0ba7-0362-ae34-a1d4fb265cd7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e2797f7-0ba7-0362-ae34-a1d4fb265cd7@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote: > Hi, > > On 4/7/21 11:15 AM, Zhen Lei wrote: > > Fixes the following W=1 kernel build warning: > > > > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] > > > > The reference to the variable 'tcpm_altmode_ops' is deleted by the > > commit a079973f462a ("usb: typec: tcpm: Remove tcpc_config configuration > > mechanism"). > > > > By the way, the static functions referenced only by the variable > > 'tcpm_altmode_ops' are deleted accordingly. > > > > Reported-by: Hulk Robot > > Signed-off-by: Zhen Lei > > I have a patch pending: > > https://www.spinics.net/lists/linux-usb/msg197684.html > > Which actually uses this. I really need to (and plan to) brush the dust of > this one soon and submit a new version. > > As such I would prefer for these ops to not get removed. But I guess I > can always include a patch in my series reverting the removal... Well, can we then just leave the ops there? If we're going to re-introduce them back soon in any case, then why drop them in the first place. thanks, -- heikki