From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46266C433B4 for ; Thu, 8 Apr 2021 11:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 142706113D for ; Thu, 8 Apr 2021 11:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231416AbhDHLUi (ORCPT ); Thu, 8 Apr 2021 07:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231310AbhDHLUg (ORCPT ); Thu, 8 Apr 2021 07:20:36 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17EEFC061760 for ; Thu, 8 Apr 2021 04:20:23 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id w7-20020a1cdf070000b0290125f388fb34so227271wmg.0 for ; Thu, 08 Apr 2021 04:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=p9/vcGnQMibF9rkDWZtUMCI7BNJHmwZHzupvVKqVu3E=; b=YnHMsaO2s1KNWHEyZA+FBnXLbzo0kKMYlmU9l9iP1g4DGl7O4FRzWyFDCE5BWmlipe byHjyxws/nm6+Um0woHg/dDHbRJEKezIUFT3iWU5a8w1PU2e7m+WM6pVFy2MfWlfxoAa LoEdm8nFSDszG2vkXnarWkoZ7cVvGd0uGCunY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=p9/vcGnQMibF9rkDWZtUMCI7BNJHmwZHzupvVKqVu3E=; b=n1VJ54x0WGQ5JJ0/Yj01jaE27ms0iD018HCcEaeGhuEkkxW4s46fPeSDUcq+S0syKo i5I01mOYXCc/b6M2eP8kN7BrzgJUk1Ed3bfy69k5wP70yEcwLwXmMf/9122h9E7lNsm9 Ic0TLW6Pzty8ff2Lh26k4DC1fmcK46sRstxh9ibG9tDLllBV1X55aj2dHPwBck5LOrhm +6Zse1tB+4TUSJoMH9Tl0b2paXAFcpawDr4NR1MCPQbYZtweiwFvN/tRtW01KjDaooZA /iZ1U9utJdJEpmMPKxY0jITmvb8p/KLMGEYRFfypxZ/sdAeGHEaBEdMscOT2wpj4F04V AXUQ== X-Gm-Message-State: AOAM530DYJ0UTbDvVkAY41pee3lKjzOKVgaGsavyddasjf1DWAF9IWAj xoPkyd5ICLHeopD8ZG+l61CCDw== X-Google-Smtp-Source: ABdhPJyGIebRl0LCNGA8cQnrb+fYGQT/Pf+/l14E/xAG36Cx4IwUC+NrIjreWsTLESHVxP3rRmlSCQ== X-Received: by 2002:a05:600c:4fd0:: with SMTP id o16mr7872267wmq.123.1617880821826; Thu, 08 Apr 2021 04:20:21 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id c16sm55234757wrs.81.2021.04.08.04.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 04:20:21 -0700 (PDT) Date: Thu, 8 Apr 2021 13:20:19 +0200 From: Daniel Vetter To: Huang Guobin Cc: Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock Message-ID: Mail-Followup-To: Huang Guobin , Patrik Jakobsson , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1617710114-48071-1-git-send-email-huangguobin4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617710114-48071-1-git-send-email-huangguobin4@huawei.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 07:55:14PM +0800, Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang Applied to drm-misc-next, thanks for your patch. -Daniel > --- > drivers/gpu/drm/gma500/power.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c > index 56ef88237ef6..f07641dfa5a4 100644 > --- a/drivers/gpu/drm/gma500/power.c > +++ b/drivers/gpu/drm/gma500/power.c > @@ -36,7 +36,7 @@ > #include > > static struct mutex power_mutex; /* Serialize power ops */ > -static spinlock_t power_ctrl_lock; /* Serialize power claim */ > +static DEFINE_SPINLOCK(power_ctrl_lock); /* Serialize power claim */ > > /** > * gma_power_init - initialise power manager > @@ -55,7 +55,6 @@ void gma_power_init(struct drm_device *dev) > dev_priv->display_power = true; /* We start active */ > dev_priv->display_count = 0; /* Currently no users */ > dev_priv->suspended = false; /* And not suspended */ > - spin_lock_init(&power_ctrl_lock); > mutex_init(&power_mutex); > > if (dev_priv->ops->init_pm) > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51918C433B4 for ; Thu, 8 Apr 2021 11:20:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDE856113C for ; Thu, 8 Apr 2021 11:20:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDE856113C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F326E6EA9D; Thu, 8 Apr 2021 11:20:23 +0000 (UTC) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id 209D06EA9D for ; Thu, 8 Apr 2021 11:20:23 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id o20-20020a05600c4fd4b0290114265518afso1024454wmq.4 for ; Thu, 08 Apr 2021 04:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=p9/vcGnQMibF9rkDWZtUMCI7BNJHmwZHzupvVKqVu3E=; b=YnHMsaO2s1KNWHEyZA+FBnXLbzo0kKMYlmU9l9iP1g4DGl7O4FRzWyFDCE5BWmlipe byHjyxws/nm6+Um0woHg/dDHbRJEKezIUFT3iWU5a8w1PU2e7m+WM6pVFy2MfWlfxoAa LoEdm8nFSDszG2vkXnarWkoZ7cVvGd0uGCunY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=p9/vcGnQMibF9rkDWZtUMCI7BNJHmwZHzupvVKqVu3E=; b=VPzwNhElo0qQL75596n3FXQrTeLuxlyLhIf7mgKe/WP1yF3eKvikVwi9JQoqMQxz5M pYsNzMvQlbp1n230I0AL90/yoPMpxWrxfKMkS+eys/YS3SkRLiI1PMS6g6g+Tx5DHYy6 4igdsFUHVTakx/bIDO2Vev+BfCUAiKXz6ObyQW0lhwEc1O6WqxgLhF3ru+XIClzS7+oj gYx03ponkLI+NPdgfnfaaxQfzpC643kXG0kXqO1rSmRO1209LfQNcfU6bxZaCfJksJDK uvByPBAwbuniJ4KSyRN+jS9Pb0BStlf0pcSBc/D+GXI2mP25e1ADV5c78+qWrPh8/5Wq hAIA== X-Gm-Message-State: AOAM531ScsQLK3/KmoghNkd9x7iaKLc5mOYIPPHf0V8vKGxPkys35tln 40d01w4ORL9jut4M/ZesnmVd2w== X-Google-Smtp-Source: ABdhPJyGIebRl0LCNGA8cQnrb+fYGQT/Pf+/l14E/xAG36Cx4IwUC+NrIjreWsTLESHVxP3rRmlSCQ== X-Received: by 2002:a05:600c:4fd0:: with SMTP id o16mr7872267wmq.123.1617880821826; Thu, 08 Apr 2021 04:20:21 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id c16sm55234757wrs.81.2021.04.08.04.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 04:20:21 -0700 (PDT) Date: Thu, 8 Apr 2021 13:20:19 +0200 From: Daniel Vetter To: Huang Guobin Subject: Re: [PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock Message-ID: Mail-Followup-To: Huang Guobin , Patrik Jakobsson , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1617710114-48071-1-git-send-email-huangguobin4@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617710114-48071-1-git-send-email-huangguobin4@huawei.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 06, 2021 at 07:55:14PM +0800, Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang Applied to drm-misc-next, thanks for your patch. -Daniel > --- > drivers/gpu/drm/gma500/power.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c > index 56ef88237ef6..f07641dfa5a4 100644 > --- a/drivers/gpu/drm/gma500/power.c > +++ b/drivers/gpu/drm/gma500/power.c > @@ -36,7 +36,7 @@ > #include > > static struct mutex power_mutex; /* Serialize power ops */ > -static spinlock_t power_ctrl_lock; /* Serialize power claim */ > +static DEFINE_SPINLOCK(power_ctrl_lock); /* Serialize power claim */ > > /** > * gma_power_init - initialise power manager > @@ -55,7 +55,6 @@ void gma_power_init(struct drm_device *dev) > dev_priv->display_power = true; /* We start active */ > dev_priv->display_count = 0; /* Currently no users */ > dev_priv->suspended = false; /* And not suspended */ > - spin_lock_init(&power_ctrl_lock); > mutex_init(&power_mutex); > > if (dev_priv->ops->init_pm) > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel