All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>, Roman Gushchin <guro@fb.com>,
	Shakeel Butt <shakeelb@google.com>,
	Oscar Salvador <osalvador@suse.de>,
	David Hildenbrand <david@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Matthew Wilcox <willy@infradead.org>,
	HORIGUCHI NAOYA <naoya.horiguchi@nec.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	Waiman Long <longman@redhat.com>, Peter Xu <peterx@redhat.com>,
	Mina Almasry <almasrymina@google.com>,
	Hillf Danton <hdanton@sina.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [External] [PATCH 7/8] hugetlb: make free_huge_page irq safe
Date: Mon, 29 Mar 2021 09:49:16 +0200	[thread overview]
Message-ID: <YGGGfBE0JVrxyFsW@dhcp22.suse.cz> (raw)
In-Reply-To: <CAMZfGtVghACpXiXRrNhQa-fM8A+-xBZvsW+QiEUU1Rqjhd2W5Q@mail.gmail.com>

On Sat 27-03-21 15:06:36, Muchun Song wrote:
> On Thu, Mar 25, 2021 at 8:29 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
> >
> > Commit c77c0a8ac4c5 ("mm/hugetlb: defer freeing of huge pages if in
> > non-task context") was added to address the issue of free_huge_page
> > being called from irq context.  That commit hands off free_huge_page
> > processing to a workqueue if !in_task.  However, as seen in [1] this
> > does not cover all cases.  Instead, make the locks taken in the
> > free_huge_page irq safe.
> >
> > This patch does the following:
> > - Make hugetlb_lock irq safe.  This is mostly a simple process of
> >   changing spin_*lock calls to spin_*lock_irq* calls.
> > - Make subpool lock irq safe in a similar manner.
> > - Revert the !in_task check and workqueue handoff.
> >
> > [1] https://lore.kernel.org/linux-mm/000000000000f1c03b05bc43aadc@google.com/
> >
> > Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> 
> The changes are straightforward.
> 
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> 
> Since this patchset aims to fix a real word issue. Should we add a Fixes
> tag?

Do we know since when it is possible to use hugetlb in the networking
context? Maybe this is possible since ever but I am wondering why the
lockdep started complaining only now. Maybe just fuzzing finally started
using this setup which nobody does normally.
-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2021-03-29  7:49 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  0:28 [PATCH 0/8] make hugetlb put_page safe for all calling contexts Mike Kravetz
2021-03-25  0:28 ` [PATCH 1/8] mm: cma: introduce cma_release_nowait() Mike Kravetz
2021-03-25  9:39   ` Oscar Salvador
2021-03-25  9:45   ` Michal Hocko
2021-03-25  9:54     ` Oscar Salvador
2021-03-25 10:10       ` Michal Hocko
2021-03-25 10:11     ` Michal Hocko
2021-03-25 10:13       ` David Hildenbrand
2021-03-25 10:17       ` Oscar Salvador
2021-03-25 10:24         ` Michal Hocko
2021-03-25  9:56   ` David Hildenbrand
2021-03-25 10:22     ` Michal Hocko
2021-03-25 16:56       ` Mike Kravetz
2021-03-25 17:15         ` David Hildenbrand
2021-03-25 20:12           ` Minchan Kim
2021-03-25 23:19             ` Roman Gushchin
2021-03-25 23:49               ` Mike Kravetz
2021-03-26 21:32                 ` Mike Kravetz
2021-03-29  7:46                   ` Michal Hocko
2021-03-29 22:27                     ` Mike Kravetz
2021-03-25  0:28 ` [PATCH 2/8] mm: hugetlb: don't drop hugetlb_lock around cma_release() call Mike Kravetz
2021-03-25  0:28 ` [PATCH 3/8] hugetlb: add per-hstate mutex to synchronize user adjustments Mike Kravetz
2021-03-25 10:47   ` Michal Hocko
2021-03-25 12:29   ` Oscar Salvador
2021-03-26  1:52   ` Miaohe Lin
2021-03-25  0:28 ` [PATCH 4/8] hugetlb: create remove_hugetlb_page() to separate functionality Mike Kravetz
2021-03-25 10:49   ` Michal Hocko
2021-03-26  2:10   ` Miaohe Lin
2021-03-26 19:57     ` Mike Kravetz
2021-03-27  1:40       ` Miaohe Lin
2021-03-27  6:36   ` [External] " Muchun Song
2021-03-27  6:36     ` Muchun Song
2021-03-25  0:28 ` [PATCH 5/8] hugetlb: call update_and_free_page without hugetlb_lock Mike Kravetz
2021-03-25 10:55   ` Michal Hocko
2021-03-25 17:12     ` Mike Kravetz
2021-03-25 19:39       ` Michal Hocko
2021-03-25 20:33         ` Mike Kravetz
2021-03-27  6:54   ` [External] " Muchun Song
2021-03-27  6:54     ` Muchun Song
2021-03-28 21:40     ` Mike Kravetz
2021-03-25  0:28 ` [PATCH 6/8] hugetlb: change free_pool_huge_page to remove_pool_huge_page Mike Kravetz
2021-03-25 11:06   ` Michal Hocko
2021-03-25 17:29     ` Mike Kravetz
2021-03-25  0:28 ` [PATCH 7/8] hugetlb: make free_huge_page irq safe Mike Kravetz
2021-03-25 11:21   ` Michal Hocko
2021-03-25 17:32     ` Mike Kravetz
2021-03-27  7:06   ` [External] " Muchun Song
2021-03-27  7:06     ` Muchun Song
2021-03-29  7:49     ` Michal Hocko [this message]
2021-03-29 22:44       ` Mike Kravetz
2021-03-25  0:28 ` [PATCH 8/8] hugetlb: add lockdep_assert_held() calls for hugetlb_lock Mike Kravetz
2021-03-25 11:22   ` Michal Hocko
2021-03-26  2:12   ` Miaohe Lin
2021-03-27  8:14   ` [External] " Muchun Song
2021-03-27  8:14     ` Muchun Song
2021-03-26  1:42 ` [PATCH 0/8] make hugetlb put_page safe for all calling contexts Miaohe Lin
2021-03-26 20:00   ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGGGfBE0JVrxyFsW@dhcp22.suse.cz \
    --to=mhocko@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=guro@fb.com \
    --cc=hdanton@sina.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=mike.kravetz@oracle.com \
    --cc=naoya.horiguchi@nec.com \
    --cc=osalvador@suse.de \
    --cc=peterx@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=shakeelb@google.com \
    --cc=songmuchun@bytedance.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.