From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8B8C433E4 for ; Mon, 29 Mar 2021 16:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8762B6191F for ; Mon, 29 Mar 2021 16:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbhC2QvN (ORCPT ); Mon, 29 Mar 2021 12:51:13 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52838 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231224AbhC2Quz (ORCPT ); Mon, 29 Mar 2021 12:50:55 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lQv6A-00DqUo-1x; Mon, 29 Mar 2021 18:50:42 +0200 Date: Mon, 29 Mar 2021 18:50:42 +0200 From: Andrew Lunn To: Maxim Kochetkov , Florian Fainelli Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/1] net: dsa: Fix type was not set for devlink port Message-ID: References: <20210329153016.1940552-1-fido_max@inbox.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210329153016.1940552-1-fido_max@inbox.ru> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 29, 2021 at 06:30:16PM +0300, Maxim Kochetkov wrote: > If PHY is not available on DSA port (described at devicetree but absent or > failed to detect) then kernel prints warning after 3700 secs: > > [ 3707.948771] ------------[ cut here ]------------ > [ 3707.948784] Type was not set for devlink port. > [ 3707.948894] WARNING: CPU: 1 PID: 17 at net/core/devlink.c:8097 0xc083f9d8 > > We should unregister the devlink port as a user port and > re-register it as an unused port before executing "continue" in case of > dsa_port_setup error. > > Fixes: 86f8b1c01a0a ("net: dsa: Do not make user port errors fatal") This commit says: Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would not treat failures to set-up an user port as fatal, but after this commit we would, which is a regression for some systems where interfaces may be declared in the Device Tree, but the underlying hardware may not be present (pluggable daughter cards for instance). Florian Are these daughter cards hot pluggable? So we expect them to appear and the port is then usable? Or is a reboot required? Andrew