From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E6BC433B4 for ; Fri, 2 Apr 2021 18:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D6A061165 for ; Fri, 2 Apr 2021 18:15:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbhDBSPJ (ORCPT ); Fri, 2 Apr 2021 14:15:09 -0400 Received: from mga09.intel.com ([134.134.136.24]:33970 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231406AbhDBSPJ (ORCPT ); Fri, 2 Apr 2021 14:15:09 -0400 IronPort-SDR: j560koXwRwp7Lw4GBijcSOBw7Nzytja8PaTw9+IO3QD2/l3yJ9E83lBhhi+8NJ6pRKaj2W5l9o 5IOlB5K5Rkgw== X-IronPort-AV: E=McAfee;i="6000,8403,9942"; a="192618478" X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="192618478" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 11:15:07 -0700 IronPort-SDR: w+2GUbQGVAzLrPUAfXSqu6v0TCddOQGVNY8NtLwOBOUjWh5IjgpScQbFXzpW773TgQmc2HXJqR 7ijlGVOtbJfA== X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="446895013" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 11:15:06 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lSOJz-000cKD-8x; Fri, 02 Apr 2021 21:15:03 +0300 Date: Fri, 2 Apr 2021 21:15:03 +0300 From: Andy Shevchenko To: Randy Dunlap Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , Denis Turischev Subject: Re: [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH Message-ID: References: <20210402161751.7683-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Apr 02, 2021 at 07:38:41PM +0300, Andy Shevchenko wrote: > On Fri, Apr 2, 2021 at 7:18 PM Randy Dunlap wrote: > > > > Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on > > LPC_SCH to prevent kconfig warning and build errors: > > > > WARNING: unmet direct dependencies detected for LPC_SCH > > Depends on [n]: HAS_IOMEM [=y] && PCI [=n] > > Selected by [y]: > > - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y] > > > > and > > > > ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class > > module_pci_driver(lpc_sch_driver); > > ^~~~~~~~~~~~~~~~~ > > ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int] > > ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration > > ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable] > > static struct pci_driver lpc_sch_driver = { > > ^~~~~~~~~~~~~~ > > Thanks! > > Bart, please, take it in your tree directly, or if you wish I may > collect this one together with Hans' one and send a PR. Bart, nevermind. Same answer as to Hans' patch: I'll take care as usual. -- With Best Regards, Andy Shevchenko