From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BED5C433B4 for ; Mon, 5 Apr 2021 11:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC107611AF for ; Mon, 5 Apr 2021 11:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239658AbhDEL64 (ORCPT ); Mon, 5 Apr 2021 07:58:56 -0400 Received: from mga14.intel.com ([192.55.52.115]:45795 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233960AbhDEL6z (ORCPT ); Mon, 5 Apr 2021 07:58:55 -0400 IronPort-SDR: fiuSY6eEdrvZF4Du1vN9NXBAMbeGnYJVYKv16AcS1HpDR6RLAJxPC1JIJPT9sd2ZboVaAxuEHK scmF36L8II2g== X-IronPort-AV: E=McAfee;i="6000,8403,9944"; a="192357900" X-IronPort-AV: E=Sophos;i="5.81,306,1610438400"; d="scan'208";a="192357900" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 04:58:48 -0700 IronPort-SDR: hbWQXiBgEZ3QUgsl33+QUPhP+YH5y+9V9E/J5tZnT77mACSuR4Uuhxy+zn5+OYGL1WoD4azlTX XpZFKc7fzOHQ== X-IronPort-AV: E=Sophos;i="5.81,306,1610438400"; d="scan'208";a="529396729" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 04:58:46 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lTNsR-001PpQ-9U; Mon, 05 Apr 2021 14:58:43 +0300 Date: Mon, 5 Apr 2021 14:58:43 +0300 From: Andy Shevchenko To: Yury Norov Cc: Yoshinori Sato , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, Andrew Morton , Arnd Bergmann , Rasmus Villemoes , kernel test robot Subject: Re: [PATCH] h8300: rearrange headers inclusion order in asm/bitops Message-ID: References: <20210401203228.124145-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401203228.124145-1-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 01, 2021 at 01:32:28PM -0700, Yury Norov wrote: > This patch fixes [next-20210401] commit a5145bdad3ff ("arch: rearrange "This patch fixes [next-20210401] commit ..." ==> "The commit ... > headers inclusion order in asm/bitops for m68k and sh"). ...fixed header ordering issue." > h8300 has > similar problem, which was overlooked by me. > h8300 includes bitmap/{find,le}.h prior to ffs/fls headers. New fast-path > implementation in find.h requires ffs/fls. Reordering the headers inclusion > sequence helps to prevent compile-time implicit function declaration error. Whit above commit message rephrasing: Reviewed-by: Andy Shevchenko > Reported-by: kernel test robot > Signed-off-by: Yury Norov > --- > arch/h8300/include/asm/bitops.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/h8300/include/asm/bitops.h b/arch/h8300/include/asm/bitops.h > index 7aa16c732aa9..c867a80cab5b 100644 > --- a/arch/h8300/include/asm/bitops.h > +++ b/arch/h8300/include/asm/bitops.h > @@ -9,6 +9,10 @@ > > #include > > +#include > +#include > +#include > + > #ifdef __KERNEL__ > > #ifndef _LINUX_BITOPS_H > @@ -173,8 +177,4 @@ static inline unsigned long __ffs(unsigned long word) > > #endif /* __KERNEL__ */ > > -#include > -#include > -#include > - > #endif /* _H8300_BITOPS_H */ > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko