From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CF756D0E for ; Tue, 6 Apr 2021 16:05:30 +0000 (UTC) Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lToCh-00F94W-A1; Tue, 06 Apr 2021 18:05:23 +0200 Date: Tue, 6 Apr 2021 18:05:23 +0200 From: Andrew Lunn To: DENG Qingfang Cc: Chun-Kuang Hu , "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Landen Chao , Matthias Brugger , Russell King , Sean Wang , Vivien Didelot , Vladimir Oltean , Rob Herring , Linus Walleij , Greg Kroah-Hartman , Sergio Paracuellos , linux-kernel , "moderated list:ARM/Mediatek SoC support" , linux-staging@lists.linux.dev, DTML , netdev , Weijie Gao , Chuanhong Guo , =?iso-8859-1?Q?Ren=E9?= van Dorst Subject: Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver Message-ID: References: <20210406141819.1025864-1-dqfext@gmail.com> <20210406141819.1025864-2-dqfext@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 06, 2021 at 11:57:14PM +0800, DENG Qingfang wrote: > On Tue, Apr 6, 2021 at 11:47 PM Chun-Kuang Hu wrote: > > > > Hi, Qingfang: > > > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道： > > > --- a/drivers/net/phy/Kconfig > > > +++ b/drivers/net/phy/Kconfig > > > @@ -207,6 +207,11 @@ config MARVELL_88X2222_PHY > > > Support for the Marvell 88X2222 Dual-port Multi-speed Ethernet > > > Transceiver. > > > > > > +config MEDIATEK_PHY > > > > There are many Mediatek phy drivers in [1], so use a specific name. > > So "MEDIATEK_MT7530_PHY" should be okay? No. MEDIATEK_PHY is consistent with other PHY drivers. Please leave it as it is. And with time, we expect other devices will be supported by this driver, so having MT7530 in the name would be confusing. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C48EAC433ED for ; Tue, 6 Apr 2021 16:05:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65935613BD for ; Tue, 6 Apr 2021 16:05:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65935613BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0dCWIx+WHhXMvUnZKNod0CWmR3uMWf/a6LyMzLLwo2w=; b=peqhOz7ajmpURFnKgtiLwFlvK 7MSSgW7qZiTJHsTfo+i9XsAL++GpHkLCK+jSuvppcdP7YLbJLqYVdRy0JFcm8Hw6TUbqv+sAFTTG7 x05+Qp6wwphW/oaO6fJNBIRIWi1omhqnKdbEDkIFJ8mB5F42qtCj+hVgV4/PSKO+Mn9RucIoPO/By q/+KkHAbIb1FznI+VpSJzsmw2Ke2uRU7e1FqtL+S8isgoVcz4JFnkIIG+P52AnYqVlVTwyr7XtJdp +3U80iGBQXGSIBRfhS9Ngd46Vjs6IYSKvXDY0RH/oANRDYR+K37c7yR7Sc4CwSoC9AVJybEJRfC5y 1EpetABYw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lToCp-002yWo-OB; Tue, 06 Apr 2021 16:05:31 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lToCm-002yWP-E3 for linux-mediatek@lists.infradead.org; Tue, 06 Apr 2021 16:05:30 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lToCh-00F94W-A1; Tue, 06 Apr 2021 18:05:23 +0200 Date: Tue, 6 Apr 2021 18:05:23 +0200 From: Andrew Lunn To: DENG Qingfang Cc: Chun-Kuang Hu , "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Landen Chao , Matthias Brugger , Russell King , Sean Wang , Vivien Didelot , Vladimir Oltean , Rob Herring , Linus Walleij , Greg Kroah-Hartman , Sergio Paracuellos , linux-kernel , "moderated list:ARM/Mediatek SoC support" , linux-staging@lists.linux.dev, DTML , netdev , Weijie Gao , Chuanhong Guo , =?iso-8859-1?Q?Ren=E9?= van Dorst Subject: Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver Message-ID: References: <20210406141819.1025864-1-dqfext@gmail.com> <20210406141819.1025864-2-dqfext@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_170528_522649_2F9209FF X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMDYsIDIwMjEgYXQgMTE6NTc6MTRQTSArMDgwMCwgREVORyBRaW5nZmFuZyB3 cm90ZToKPiBPbiBUdWUsIEFwciA2LCAyMDIxIGF0IDExOjQ3IFBNIENodW4tS3VhbmcgSHUgPGNo dW5rdWFuZy5odUBrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBIaSwgUWluZ2Zhbmc6Cj4gPgo+ ID4gREVORyBRaW5nZmFuZyA8ZHFmZXh0QGdtYWlsLmNvbT4g5pa8IDIwMjHlubQ05pyINuaXpSDp gLHkuowg5LiL5Y2IMTA6MTnlr6vpgZPvvJoKPiA+ID4gLS0tIGEvZHJpdmVycy9uZXQvcGh5L0tj b25maWcKPiA+ID4gKysrIGIvZHJpdmVycy9uZXQvcGh5L0tjb25maWcKPiA+ID4gQEAgLTIwNyw2 ICsyMDcsMTEgQEAgY29uZmlnIE1BUlZFTExfODhYMjIyMl9QSFkKPiA+ID4gICAgICAgICAgIFN1 cHBvcnQgZm9yIHRoZSBNYXJ2ZWxsIDg4WDIyMjIgRHVhbC1wb3J0IE11bHRpLXNwZWVkIEV0aGVy bmV0Cj4gPiA+ICAgICAgICAgICBUcmFuc2NlaXZlci4KPiA+ID4KPiA+ID4gK2NvbmZpZyBNRURJ QVRFS19QSFkKPiA+Cj4gPiBUaGVyZSBhcmUgbWFueSBNZWRpYXRlayBwaHkgZHJpdmVycyBpbiBb MV0sIHNvIHVzZSBhIHNwZWNpZmljIG5hbWUuCj4gCj4gU28gIk1FRElBVEVLX01UNzUzMF9QSFki IHNob3VsZCBiZSBva2F5PwoKTm8uIE1FRElBVEVLX1BIWSBpcyBjb25zaXN0ZW50IHdpdGggb3Ro ZXIgUEhZIGRyaXZlcnMuIFBsZWFzZSBsZWF2ZSBpdAphcyBpdCBpcy4gQW5kIHdpdGggdGltZSwg d2UgZXhwZWN0IG90aGVyIGRldmljZXMgd2lsbCBiZSBzdXBwb3J0ZWQgYnkKdGhpcyBkcml2ZXIs IHNvIGhhdmluZyBNVDc1MzAgaW4gdGhlIG5hbWUgd291bGQgYmUgY29uZnVzaW5nLgoKICAgQW5k cmV3CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlh dGVrCg==