All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Hung <joe_hung@ilitek.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-input@vger.kernel.org, luca_hsu@ilitek.com
Subject: Re: [RESEND v7 2/2] input: touchscreen: Add support for ILITEK Lego Series
Date: Tue, 20 Apr 2021 22:40:12 -0700	[thread overview]
Message-ID: <YH+6vHUf12roZPP+@google.com> (raw)
In-Reply-To: <20210419051325.147314-2-joe_hung@ilitek.com>

Hi Joe,

On Mon, Apr 19, 2021 at 01:13:25PM +0800, Joe Hung wrote:
> Add support for ILITEK Lego series of touch devices.
> Lego series includes ILITEK 213X/23XX/25XX.
> 
> Tested/passed with evaluation board with ILI2520/2322 IC.

Sorry, I mean to send the email earlier, but I did apply the patches
with some minor formatting changes and ...

> +
> +	/* Single touch input setup */
> +	input_set_abs_params(input, ABS_X, ts->screen_min_x,
> +			     ts->screen_max_x, 0, 0);
> +	input_set_abs_params(input, ABS_Y, ts->screen_min_y,
> +			     ts->screen_max_y, 0, 0);

You do not need to set up single-axis as ...

> +
> +	/* Multi-touch input setup */
> +	input_set_abs_params(input, ABS_MT_POSITION_X,
> +			     ts->screen_min_x,
> +			     ts->screen_max_x, 0, 0);
> +	input_set_abs_params(input, ABS_MT_POSITION_Y,
> +			     ts->screen_min_y,
> +			     ts->screen_max_y, 0, 0);
> +
> +	touchscreen_parse_properties(input, true, &ts->prop);
> +
> +	error = input_mt_init_slots(input, ts->max_tp,
> +				    INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);

this will do it for you.

Thanks.

-- 
Dmitry

  reply	other threads:[~2021-04-21  5:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19  5:13 [RESEND v7 1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings Joe Hung
2021-04-19  5:13 ` [RESEND v7 2/2] input: touchscreen: Add support for ILITEK Lego Series Joe Hung
2021-04-21  5:40   ` Dmitry Torokhov [this message]
2021-04-22 10:30     ` Joe Hung (洪銘陽)
  -- strict thread matches above, loose matches on Subject: below --
2021-04-06  3:56 [RESEND v7 1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings Joe Hung
2021-04-06  3:56 ` [RESEND v7 2/2] input: touchscreen: Add support for ILITEK Lego Series Joe Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YH+6vHUf12roZPP+@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joe_hung@ilitek.com \
    --cc=linux-input@vger.kernel.org \
    --cc=luca_hsu@ilitek.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.