From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B98C43460 for ; Tue, 20 Apr 2021 13:37:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09B4561026 for ; Tue, 20 Apr 2021 13:37:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09B4561026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BF266E827; Tue, 20 Apr 2021 13:37:01 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D0B216E827 for ; Tue, 20 Apr 2021 13:36:59 +0000 (UTC) IronPort-SDR: WNB3wisdP5LZItJWBCD+suHkU8uM+D0VobgaNuX/OMdXLeHe2n+VLoVXqweR6im8kY2mQOXaev pLCI6iidxS6Q== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="193383183" X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="193383183" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 06:36:59 -0700 IronPort-SDR: 4EPiy5HSj8YmsRWxTdDQsasVdpMz4Dpjnkt5L+Kr/RTBq3yZH4qC0gVax+SHyu6QYJA5scZsuD +YnJ95wa57OQ== X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="602478874" Received: from jyick-mobl.amr.corp.intel.com (HELO intel.com) ([10.212.57.228]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 06:36:58 -0700 Date: Tue, 20 Apr 2021 09:36:56 -0400 From: Rodrigo Vivi To: Bhanuprakash Modem , uma.shankar@intel.com Message-ID: References: <20210419191834.7574-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210419191834.7574-1-bhanuprakash.modem@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix state mismatch in drm infoframe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Apr 20, 2021 at 12:48:34AM +0530, Bhanuprakash Modem wrote: > While reading the SDP infoframe, we are getting filtered with > the encoder type INTEL_OUTPUT_DDI which causes the infoframe > mismatch. This patch will extend the support to read the SDP > infoframes for eDP. > > [1025.606556] i915 0000:00:02.0: [drm] *ERROR* mismatch in drm infoframe > [1025.607865] i915 0000:00:02.0: [drm] *ERROR* expected: > [1025.607879] i915 0000:00:02.0: HDMI infoframe: Dynamic Range and Mastering, version 1, length 26 > [1025.607889] i915 0000:00:02.0: length: 26 > [1025.607898] i915 0000:00:02.0: metadata type: 0 > [1025.608292] i915 0000:00:02.0: eotf: 2 > [1025.608302] i915 0000:00:02.0: x[0]: 35400 > [1025.608312] i915 0000:00:02.0: y[0]: 14599 > [1025.609115] i915 0000:00:02.0: x[1]: 8500 > [1025.609947] i915 0000:00:02.0: y[1]: 39850 > [1025.609959] i915 0000:00:02.0: x[2]: 6550 > [1025.609970] i915 0000:00:02.0: y[2]: 2300 > [1025.609980] i915 0000:00:02.0: white point x: 15634 > [1025.609989] i915 0000:00:02.0: white point y: 16450 > [1025.610381] i915 0000:00:02.0: max_display_mastering_luminance: 1000 > [1025.610392] i915 0000:00:02.0: min_display_mastering_luminance: 500 > [1025.610401] i915 0000:00:02.0: max_cll: 500 > [1025.610816] i915 0000:00:02.0: max_fall: 1000 > [1025.612457] i915 0000:00:02.0: [drm] *ERROR* found: > [1025.614354] ------------[ cut here ]------------ > [1025.616244] pipe state doesn't match! > [1025.617640] WARNING: CPU: 6 PID: 2114 at drivers/gpu/drm/i915/display/intel_display.c:9332 intel_atomic_commit_tail+0x14d4/0x17c0 [i915] > > Cc: Uma Shankar > Signed-off-by: Bhanuprakash Modem > Reviewed-by: Uma Shankar I'm sorry, but I haven't seen this review anywhere. What am I missing? Where did this happen? Whenever sending a patch for the first time, even if it was internally reviewed, please use only "Cc:" and ask the internal reviewer to re-check and send the response directly. > --- > drivers/gpu/drm/i915/display/intel_dp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 5ee953aaa00c..91e67735a45c 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -3063,7 +3063,8 @@ void intel_read_dp_sdp(struct intel_encoder *encoder, > struct intel_crtc_state *crtc_state, > unsigned int type) > { > - if (encoder->type != INTEL_OUTPUT_DDI) > + if (encoder->type != INTEL_OUTPUT_DDI && > + encoder->type != INTEL_OUTPUT_EDP) > return; > > switch (type) { > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx