On Fri, Mar 26, 2021 at 09:18:04AM +0100, Uwe Kleine-König wrote: > A consumer is expected to disable a PWM before calling pwm_put(). And if > they didn't there is hopefully a good reason (or the consumer needs > fixing.) Also if disabling an enabled PWM was the right thing to do, this > should better be done in the framework instead of in each low level driver. > > So drop the hardware modification from the .remove() callback. > > Signed-off-by: Uwe Kleine-König > --- > drivers/pwm/pwm-bcm-kona.c | 5 ----- > 1 file changed, 5 deletions(-) It'd be better to somehow WARN about this instead of silently leaking the clock reference, but I can't think of a good way to do that, which would also work in the case where the consumer intentionally left the PWM enabled, so: Applied, thanks. Thierry