Re: [RFT] prepping up pahole 1.21, wanna test it? was Re: [PATCH dwarves] dwarf_loader: handle subprogram ret type with abstract_origin properly

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yonghong Song <yhs@fb.com>
Cc: Arnaldo <arnaldo.melo@gmail.com>,
	David Blaikie <dblaikie@gmail.com>,
	dwarves@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Bill Wendling <morbo@google.com>, bpf <bpf@vger.kernel.org>,
	kernel-team@fb.com, Nick Desaulniers <ndesaulniers@google.com>,
	Jiri Olsa <jolsa@kernel.org>
Subject: Re: [RFT] prepping up pahole 1.21, wanna test it? was Re: [PATCH dwarves] dwarf_loader: handle subprogram ret type with abstract_origin properly
Date: Fri, 9 Apr 2021 10:52:05 -0300	[thread overview]
Message-ID: <YHBcBXNATDOg+mYr@kernel.org> (raw)
In-Reply-To: <7cdd9179-df5e-bdb5-ab36-983acddcbc1c@fb.com>

Em Wed, Apr 07, 2021 at 03:53:32PM -0700, Yonghong Song escreveu:
> 
> 
> On 4/7/21 8:40 AM, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Apr 07, 2021 at 12:37:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, Apr 07, 2021 at 07:54:26AM -0700, Yonghong Song escreveu:
> > > > Arnaldo, just in case that you missed it, please remember
> > > > to fold the above changes to the patch:
> > > >     [PATCH dwarves] dwarf_loader: handle subprogram ret type with
> > > > abstract_origin properly
> > > > Thanks!
> > > 
> > > Its there, I did it Sunday, IIRC:
> > > 
> > > https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?h=tmp.master&id=9adb014930f31c66608fa39a35ccea2daa5586ad
> > 
> > So I pushed it all to the master branch, hopefully some more people may
> > feel encouraged to give it a try for the various things it fixes since
> > 1.20:
> > 
> > [acme@quaco pahole]$ git log --oneline v1.20..
> > ae0b7dde1fd50b12 (HEAD -> master, origin/tmp.master, origin/master, origin/HEAD, github/master, five/master, acme.korg/tmp.master, acme.korg/master) dwarf_loader: Handle DWARF5 DW_OP_addrx properly
> > 9adb014930f31c66 dwarf_loader: Handle subprogram ret type with abstract_origin properly
> > 5752d1951d081a80 dwarf_loader: Check .notes section for LTO build info
> > 209e45424ff4a22d dwarf_loader: Check .debug_abbrev for cross-CU references
> > 39227909db3cc2c2 dwarf_loader: Permit merging all DWARF CU's for clang LTO built binary
> > 763475ca1101ccfe dwarf_loader: Factor out common code to initialize a cu
> > d0d3fbd4744953e8 dwarf_loader: Permit a flexible HASHTAGS__BITS
> > ffe0ef4d73906c18 btf: Add --btf_gen_all flag
> > de708b33114d42c2 btf: Add support for the floating-point types
> > 4b7f8c04d009942b fprintf: Honour conf_fprintf.hex when printing enumerations
> > f2889ff163726336 Avoid warning when building with NDEBUG
> > 8e1f8c904e303d5d btf_encoder: Match ftrace addresses within ELF functions
> > 9fecc77ed82d429f dwarf_loader: Use a better hashing function, from libbpf
> > 0125de3a4c055cdf btf_encoder: Funnel ELF error reporting through a macro
> > 7d8e829f636f47ab btf_encoder: Sanitize non-regular int base type
> > [acme@quaco pahole]$
> 
> I tested with llvm-project "main" branch and latest bpf-next.
> clang non-lto, dwarf4/5: okay
> clang thin-lto, dwarf4/5: okay
> gcc (8.4.1, non-lto, default dwarf4): okay
> 
> So pahole looks good. Thanks!

Thanks a lot, in time for a friday release! :-)

- Arnaldo