From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FF9C433ED for ; Sat, 10 Apr 2021 01:24:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56E0B610FB for ; Sat, 10 Apr 2021 01:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235391AbhDJBYj (ORCPT ); Fri, 9 Apr 2021 21:24:39 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47266 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235319AbhDJBYi (ORCPT ); Fri, 9 Apr 2021 21:24:38 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 13A1OKeh011017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Apr 2021 21:24:20 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0EA2015C3B12; Fri, 9 Apr 2021 21:24:20 -0400 (EDT) Date: Fri, 9 Apr 2021 21:24:19 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: linux-ext4@vger.kernel.org, Hao Sun Subject: Re: [PATCH 2/2] ext4: Annotate data race in jbd2_journal_dirty_metadata() Message-ID: References: <20210406161605.2504-1-jack@suse.cz> <20210406161804.20150-2-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406161804.20150-2-jack@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 06, 2021 at 06:18:00PM +0200, Jan Kara wrote: > Assertion checks in jbd2_journal_dirty_metadata() are known to be racy > but we don't want to be grabbing locks just for them. We thus recheck > them under b_state_lock only if it looks like they would fail. Annotate > the checks with data_race(). > > Reported-by: Hao Sun > Signed-off-by: Jan Kara Thanks, applied. - Ted