From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 490DFC43461 for ; Fri, 9 Apr 2021 21:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C2146115B for ; Fri, 9 Apr 2021 21:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234574AbhDIVbC (ORCPT ); Fri, 9 Apr 2021 17:31:02 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:43936 "EHLO mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233687AbhDIVbB (ORCPT ); Fri, 9 Apr 2021 17:31:01 -0400 Received: by mail-pg1-f174.google.com with SMTP id p12so4863054pgj.10; Fri, 09 Apr 2021 14:30:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2XXqOMB7no84r14nU406OpNWXXLiSmIGXiQhHcyMAkk=; b=iCSC3AERc/mTBUDNMTnczOVjgXldZvSPc/6dzLL3wibnvmZv/YHqI1fIM+yND9yan2 HyYyHHaRDAgSxzEERFdgGJiA3rzK7oCRVQ8P9/t/Bj+/EVsBTPqFi5npuxAvYYvR0q5z 00LEhy3/ZS+yW2ONGTpSwQxwAryXYlea/x3zS5+bdprjB5Hgc5tLT9AzZYB/Vti8vKsX a2EktsrZfoOTc3vFqP4Npfxbt9Ff7boFLao9PQKnEgnWoVsfWMo5JGbo03mW69JuB71b oSsfVGVMO/PD+wajHjfdK53wBGDLuidyriUTNi6mtMoAqG6r7Vo2Aum7vZqTcCgVjDfQ NnRA== X-Gm-Message-State: AOAM532OCZaer2KZ/+UvBNJSMbhb0mRt/iinVslOIy4+KitZ3lN+2vPU gZFnglcn2zCO9uPo+vWvOOz6KoPqFIg= X-Google-Smtp-Source: ABdhPJwBrLtol0mRutEPMQs4Fpt4m0HV/+0/6ayK48mHIdHR3+k7+LHV2Q2U+8ZRkZWw0s/l8S0vHg== X-Received: by 2002:a63:c145:: with SMTP id p5mr14851986pgi.451.1618003847503; Fri, 09 Apr 2021 14:30:47 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id k10sm2995741pfk.205.2021.04.09.14.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 14:30:46 -0700 (PDT) Date: Fri, 9 Apr 2021 14:30:45 -0700 From: Moritz Fischer To: Nava kishore Manne Cc: mdf@kernel.org, trix@redhat.com, robh+dt@kernel.org, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Subject: Re: [PATCH 3/3] fpga: region: Adds runtime PM support Message-ID: References: <20210402092049.479-1-nava.manne@xilinx.com> <20210402092049.479-4-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210402092049.479-4-nava.manne@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 02, 2021 at 02:50:49PM +0530, Nava kishore Manne wrote: > Adds support to handle FPGA/PL power domain. With this patch, > the PL power domain will be turned on before loading the bitstream > and turned off while removing/unloading the bitstream using overlays. > This can be achieved by adding the runtime PM support. > > Signed-off-by: Nava kishore Manne > --- > drivers/fpga/of-fpga-region.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c > index e405309baadc..35fc2f3d4bd8 100644 > --- a/drivers/fpga/of-fpga-region.c > +++ b/drivers/fpga/of-fpga-region.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > static const struct of_device_id fpga_region_of_match[] = { > { .compatible = "fpga-region", }, > @@ -302,6 +303,7 @@ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, > } > > region->info = info; > + pm_runtime_get_sync(dev->parent); > ret = fpga_region_program_fpga(region); > if (ret) { > /* error; reject overlay */ > @@ -324,10 +326,13 @@ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, > static void of_fpga_region_notify_post_remove(struct fpga_region *region, > struct of_overlay_notify_data *nd) > { > + struct device *dev = ®ion->dev; > + > fpga_bridges_disable(®ion->bridge_list); > fpga_bridges_put(®ion->bridge_list); > fpga_image_info_free(region->info); > region->info = NULL; > + pm_runtime_put(dev->parent); > } > > /** > @@ -411,9 +416,16 @@ static int of_fpga_region_probe(struct platform_device *pdev) > goto eprobe_mgr_put; > } > > + pm_runtime_enable(&pdev->dev); > + ret = pm_runtime_get_sync(&pdev->dev); > + if (ret < 0) > + goto err_pm; > + > + pm_runtime_put(&pdev->dev); > + > ret = fpga_region_register(region); > if (ret) > - goto eprobe_mgr_put; > + goto err_pm; > > of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev); > platform_set_drvdata(pdev, region); > @@ -422,6 +434,9 @@ static int of_fpga_region_probe(struct platform_device *pdev) > > return 0; > > +err_pm: > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > eprobe_mgr_put: > fpga_mgr_put(mgr); > return ret; > @@ -434,6 +449,7 @@ static int of_fpga_region_remove(struct platform_device *pdev) > > fpga_region_unregister(region); > fpga_mgr_put(mgr); > + pm_runtime_disable(region->dev.parent); > > return 0; > } > -- > 2.18.0 > Does this add a dependency on CONFIG_PM? Thanks, Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B9EC433B4 for ; Fri, 9 Apr 2021 21:36:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CAD561074 for ; Fri, 9 Apr 2021 21:36:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CAD561074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xl+FKw6jGr7L+8FmjlcWA/pJAmtKKlFXT/KyJPe3uN8=; b=Id67X1HYq9gJAxe67xwq4LQQX Y0CShvCl3Cipt9ssS95oVYlSdbakHKAWU3M8she9r2FJToMkHXpsNQFTQbkr4IdsMky2RU8bh/ZPy Vhq94Z7/pNxkMjISDPEQThI15rvUPUPyYRxB16bYrYfQUU5T/5JxScShJvxXX5GCO8EM7WptIaAbr LEsZ6j80wD1OUjvGaFK9dWf6Xdmh5aEmEJ6p3rqDNfI4p4QsuIQZFfSUFN2NE20t83R2f9sj8JpNQ 6t5hRq/XijlvAdGRv1hZLcJnnFdP1+6EL17c8fQPFH4nWeIrpYIbrtVLujfz1vEQ3WnpfpQ5s61Kr pYRjRsh6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUylM-001YHp-QX; Fri, 09 Apr 2021 21:34:01 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUyiK-001Y2r-2C for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 21:31:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2XXqOMB7no84r14nU406OpNWXXLiSmIGXiQhHcyMAkk=; b=cdDzx3U3aKMQ8KltkMI6oecDX3 2c2MbrqWAS8peqLi5UsZ3sBhKbeQZstMRx9Ybr5LDKuETALban2KOrni85Ui8OvY07JAnFJ0vC1ih uVBs0zwwNEcyZcZ6svoK4afxMnycLWWVugUkmuC38nyUdtkedAuXjNZhYeh5ARQ3cnzqUY49yF/CH YvAZHca5KjNtMn+Y9SiA8CyDQRWoeirik331RJp7GWDA95f07xVbjWYwVon1sruImONxH27Kis5w2 wvEdZ9Q6Z4oOdklLtc5VSxxDANrp23oY7KeZWV10+ZwIbHX3XbskhB9tE7q6sqzAA1FfRbu8WrKD4 81aBR2lg==; Received: from mail-pg1-f176.google.com ([209.85.215.176]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUyiH-004oNi-Cm for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 21:30:50 +0000 Received: by mail-pg1-f176.google.com with SMTP id q10so4873007pgj.2 for ; Fri, 09 Apr 2021 14:30:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2XXqOMB7no84r14nU406OpNWXXLiSmIGXiQhHcyMAkk=; b=THDRv6k2A5Afst6CBGgUQ2C1Iazr3/5fxuN6sQqMuJmRfiJ/6f/jESKAN0Izqxqdvl R/0Qbfi+fFFypEEzxEBEbdiSk9BtlNc0ty8MMRSVcVRtvQn4kMx8MPekpBZnW4Sz35no y/U1DFcHcOg1rgD7JWmIp0pk2sL1gdjQe5eM+ou+cQ/gPvuVBpztJkDLonkkpdRO037w lSsF1XjoltoE1XTNMfoKCcmHnNhrms2j/0PfZKr73EGmi+Jv7gXHhOO+FOlCa2sRc966 pkiCw3SePS9G+phSq4wu2LN4p6l7jgo67TkbUFFJO1o0llWFgZG3ToJLxnZDQj82O43+ YPYg== X-Gm-Message-State: AOAM530nhmvfVuYPQiTppr16D7gQn9gqeY4eXZ/7oxH6ubdX4XlVS4ed lz3y+T9NGizM25+yjgMZ6Aw= X-Google-Smtp-Source: ABdhPJwBrLtol0mRutEPMQs4Fpt4m0HV/+0/6ayK48mHIdHR3+k7+LHV2Q2U+8ZRkZWw0s/l8S0vHg== X-Received: by 2002:a63:c145:: with SMTP id p5mr14851986pgi.451.1618003847503; Fri, 09 Apr 2021 14:30:47 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id k10sm2995741pfk.205.2021.04.09.14.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 14:30:46 -0700 (PDT) Date: Fri, 9 Apr 2021 14:30:45 -0700 From: Moritz Fischer To: Nava kishore Manne Cc: mdf@kernel.org, trix@redhat.com, robh+dt@kernel.org, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Subject: Re: [PATCH 3/3] fpga: region: Adds runtime PM support Message-ID: References: <20210402092049.479-1-nava.manne@xilinx.com> <20210402092049.479-4-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210402092049.479-4-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_143049_461607_08353BA9 X-CRM114-Status: GOOD ( 23.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 02, 2021 at 02:50:49PM +0530, Nava kishore Manne wrote: > Adds support to handle FPGA/PL power domain. With this patch, > the PL power domain will be turned on before loading the bitstream > and turned off while removing/unloading the bitstream using overlays. > This can be achieved by adding the runtime PM support. > > Signed-off-by: Nava kishore Manne > --- > drivers/fpga/of-fpga-region.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c > index e405309baadc..35fc2f3d4bd8 100644 > --- a/drivers/fpga/of-fpga-region.c > +++ b/drivers/fpga/of-fpga-region.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > static const struct of_device_id fpga_region_of_match[] = { > { .compatible = "fpga-region", }, > @@ -302,6 +303,7 @@ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, > } > > region->info = info; > + pm_runtime_get_sync(dev->parent); > ret = fpga_region_program_fpga(region); > if (ret) { > /* error; reject overlay */ > @@ -324,10 +326,13 @@ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, > static void of_fpga_region_notify_post_remove(struct fpga_region *region, > struct of_overlay_notify_data *nd) > { > + struct device *dev = ®ion->dev; > + > fpga_bridges_disable(®ion->bridge_list); > fpga_bridges_put(®ion->bridge_list); > fpga_image_info_free(region->info); > region->info = NULL; > + pm_runtime_put(dev->parent); > } > > /** > @@ -411,9 +416,16 @@ static int of_fpga_region_probe(struct platform_device *pdev) > goto eprobe_mgr_put; > } > > + pm_runtime_enable(&pdev->dev); > + ret = pm_runtime_get_sync(&pdev->dev); > + if (ret < 0) > + goto err_pm; > + > + pm_runtime_put(&pdev->dev); > + > ret = fpga_region_register(region); > if (ret) > - goto eprobe_mgr_put; > + goto err_pm; > > of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev); > platform_set_drvdata(pdev, region); > @@ -422,6 +434,9 @@ static int of_fpga_region_probe(struct platform_device *pdev) > > return 0; > > +err_pm: > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > eprobe_mgr_put: > fpga_mgr_put(mgr); > return ret; > @@ -434,6 +449,7 @@ static int of_fpga_region_remove(struct platform_device *pdev) > > fpga_region_unregister(region); > fpga_mgr_put(mgr); > + pm_runtime_disable(region->dev.parent); > > return 0; > } > -- > 2.18.0 > Does this add a dependency on CONFIG_PM? Thanks, Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel