All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 8/8 v3] Input: cyttsp - Flag the device properly
Date: Sat, 10 Apr 2021 00:41:33 -0700	[thread overview]
Message-ID: <YHFWrdYMSmnLAm2V@google.com> (raw)
In-Reply-To: <20210408131153.3446138-9-linus.walleij@linaro.org>

Hi Linus,

On Thu, Apr 08, 2021 at 03:11:53PM +0200, Linus Walleij wrote:
> This device is certainly a very simple touchscreen so
> we set INPUT_MT_DIRECT.
> 
> The sibling driver for CY8CTMA140 also sets
> INPUT_MT_DROP_UNUSED and experimenting with this driver
> it clearly does not hurt: the touchscreen is working just
> fine so let's set it for this one as well.

This is not a good justification, and INPUT_MT_DROP_UNUSED is
essentially a noop if the driver does not use input_mt_sync_frame().

I dropped INPUT_MT_DROP_UNUSED from the patch and applied, but I would
appreciate a followup patch switching the driver to INPUT_MT_DROP_UNUSED
and adding input_mt_sync_frame() to cyttsp_report_tchdata() and removing
manual release of inactive slots from there (the "used" bitmap).

Thanks.

-- 
Dmitry

      reply	other threads:[~2021-04-10  7:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 13:11 [PATCH 0/8 v3] Update CYTTSP driver Linus Walleij
2021-04-08 13:11 ` [PATCH 1/8 v3] Input: cyttsp - Convert bindings to YAML and extend Linus Walleij
2021-04-10  7:44   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 2/8 v3] Input: cyttsp - Probe from compatibles Linus Walleij
2021-04-08 13:11 ` [PATCH 3/8 v3] Input: cyttsp - Obtain regulators Linus Walleij
2021-04-08 13:11 ` [PATCH 4/8 v3] Input: cyttsp - Error message on boot mode exit error Linus Walleij
2021-04-10  7:31   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 5/8 v3] Input: cyttsp - Reduce reset pulse timings Linus Walleij
2021-04-10  7:32   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 6/8 v3] Input: cyttsp - Drop the phys path Linus Walleij
2021-04-10  7:33   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 7/8 v3] Input: cyttsp - Set abs params for ABS_MT_TOUCH_MAJOR Linus Walleij
2021-04-10  7:34   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 8/8 v3] Input: cyttsp - Flag the device properly Linus Walleij
2021-04-10  7:41   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHFWrdYMSmnLAm2V@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=javier@dowhile0.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.