All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: Sun Ke <sunke32@huawei.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/591: tmpfs do not test with O_DIRECT flag
Date: Sun, 11 Apr 2021 16:48:56 +0800	[thread overview]
Message-ID: <YHK3+OTP20bjIx4A@desktop> (raw)
In-Reply-To: <20210409103800.2077384-1-sunke32@huawei.com>

On Fri, Apr 09, 2021 at 06:38:00AM -0400, Sun Ke wrote:
> tmpfs does not support the O_DIRECT flag, so when FSTYP is tmpfs,
> do not test with O_DIRECT flag.
> 
> Signed-off-by: Sun Ke <sunke32@huawei.com>

Seems we should add _require_odirect instead, otherwise we'll keep
adding new checks when new filesystems without dio support emerge.

Thanks,
Eryu

> ---
>  tests/generic/591 | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/generic/591 b/tests/generic/591
> index d4020463..4b97a2fc 100755
> --- a/tests/generic/591
> +++ b/tests/generic/591
> @@ -31,10 +31,18 @@ _require_test_program "splice-test"
>  
>  rm -f $seqres.full
>  
> -$here/src/splice-test -r $TEST_DIR/a
> -$here/src/splice-test -rd $TEST_DIR/a
> -$here/src/splice-test $TEST_DIR/a
> -$here/src/splice-test -d $TEST_DIR/a
> +if [ $FSTYP == "tmpfs" ]; then
> +	echo "concurrent reader with O_DIRECT"
> +	echo "concurrent reader with O_DIRECT"
> +	$here/src/splice-test -rd $TEST_DIR/a
> +	echo "sequential reader with O_DIRECT"
> +	$here/src/splice-test -d $TEST_DIR/a
> +else
> +	$here/src/splice-test -r $TEST_DIR/a
> +	$here/src/splice-test -rd $TEST_DIR/a
> +	$here/src/splice-test $TEST_DIR/a
> +	$here/src/splice-test -d $TEST_DIR/a
> +fi
>  
>  # success, all done
>  status=0
> -- 
> 2.13.6

      reply	other threads:[~2021-04-11  8:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 10:38 [PATCH] generic/591: tmpfs do not test with O_DIRECT flag Sun Ke
2021-04-11  8:48 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHK3+OTP20bjIx4A@desktop \
    --to=guan@eryu.me \
    --cc=fstests@vger.kernel.org \
    --cc=sunke32@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.