From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D29C433ED for ; Sun, 11 Apr 2021 15:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 264706109F for ; Sun, 11 Apr 2021 15:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236006AbhDKPUD (ORCPT ); Sun, 11 Apr 2021 11:20:03 -0400 Received: from out20-61.mail.aliyun.com ([115.124.20.61]:52687 "EHLO out20-61.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235503AbhDKPUD (ORCPT ); Sun, 11 Apr 2021 11:20:03 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07961861|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.0376481-0.000358055-0.961994;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047206;MF=guan@eryu.me;NM=1;PH=DS;RN=7;RT=7;SR=0;TI=SMTPD_---.JyM-tLj_1618154384; Received: from localhost(mailfrom:guan@eryu.me fp:SMTPD_---.JyM-tLj_1618154384) by smtp.aliyun-inc.com(10.147.40.233); Sun, 11 Apr 2021 23:19:44 +0800 Date: Sun, 11 Apr 2021 23:19:44 +0800 From: Eryu Guan To: Christian Brauner Cc: Christian Brauner , fstests@vger.kernel.org, Christoph Hellwig , "Darrick J . Wong" , David Howells , Amir Goldstein Subject: Re: [PATCH v12 2/6] generic/632: add fstests for idmapped mounts Message-ID: References: <20210328223400.1800301-1-brauner@kernel.org> <20210328223400.1800301-3-brauner@kernel.org> <20210411151249.6y34x7yatqtpcvi6@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210411151249.6y34x7yatqtpcvi6@wittgenstein> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Sun, Apr 11, 2021 at 05:12:49PM +0200, Christian Brauner wrote: > On Sun, Apr 11, 2021 at 10:30:20PM +0800, Eryu Guan wrote: > > On Mon, Mar 29, 2021 at 12:33:56AM +0200, Christian Brauner wrote: > > > From: Christian Brauner > > > > > > Add a test suite to verify the behavior of idmapped mounts. The test > > > suite also includes a range of vfs tests to verify that no regressions > > > are introduced by idmapped mounts. The following tests are currently > > > available with more to come in the future: > > > > > > 01. posix acls on regular and idmapped mounts > > > > I'm getting failures like below when testing on btrfs and overlayfs > > > > [root@fedoravm xfstests]# diff -u > > /root/workspace/xfstests/tests/generic/633.out /root/workspace/xfstests/results//btrfs/generic/633.out.bad > > --- /root/workspace/xfstests/tests/generic/633.out 2021-04-11 22:18: 24.458518716 +0800 > > +++ /root/workspace/xfstests/results//btrfs/generic/633.out.bad 2021-04-11 22:19:58.887980770 +0800 > > @@ -1,2 +1,4 @@ > > QA output created by 633 > > Silence is golden > > +idmapped-mounts.c: 6622: acls - Invalid argument - failure: sys_mount_setattr > > +failure: posix acls on regular mounts > > > > Is this a known issue or test needs some fix? > > Ah, this is very likely just the getfacl command missing which is part > of the "acl" package, at least on Ubuntu. I do have getfacl command installed, and test passed if I tested on ext4 or xfs. So I don't think it's related to getfacl command. Thanks, Eryu