From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F021C433ED for ; Tue, 13 Apr 2021 14:08:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9F78613AB for ; Tue, 13 Apr 2021 14:08:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9F78613AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XQbwO7saq4Cue9KNNJqQx7hQLVyVSXVW9acF8W/7Pf4=; b=akKG4jbF9zEH1oNmTZl6/zX7E 3f/3410tS+86aStqlyCr1GCRwaM2eGSlXJM2OoNaTTy48cxgDDdaN1aFniV0+ktTtaHtZhWNQmVSM f54DPDcG6ckoryDME0JkNT1k3enwW03FEjP8Lxyxv2N26BcYK3hx6DmW0Xm40ovMeJsJ9OouHbf+b hxAH10ORhIl3uwH660h08HbAPEGCWcDEPEFxTUz/SnM3HwnsL7eV3Yz9Oj7lY7AIXXYcbHxsf5w9Z rDZeK+K9XAHsFtoAqCzv1lD+B7vERI3sDzxIrzInjLKpRZ7KA6C4yEe/q+t+yFNiA/72JSIGEEZm5 /MQifv1rw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWJfC-009SNe-GB; Tue, 13 Apr 2021 14:05:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWJeo-009SLS-VE for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 14:04:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=h/8wbVDaxKr1pxr3xsfJZCxLfYGtm7wlDkUhOm6t6b4=; b=f0jwNDt50TjXK91BVc5wSvGS54 D5R6bg6/WLT2nsjSJrzUUW5dJ7dG7yoq9XgCYEzkD8eQ5l8yzL4sCNDbbZlU8dMY5Ac0r4NtZAjba TcFv4vcyU6ieUbJTrf424PEnDIr9HXqYoGCF1/8SfotTT+8b7vxQFgATawxPr0qLU8Dw/qPN8Wzc+ qYTwjMH+oPC+bSCvAb5LQEnuiE2oYBcfRCr3tBbbfTio7fVDY8heDgT23z4pHAuEbVWENQNwm3Hc1 7/09NsMvPeOCT4Mmrl7QgRL5UV9P0e2KHTDXt1J1VucFcddO+7X1qjLnWQpJ+MvVQow/nZ1woHYbd rbtMCFIw==; Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWJel-007590-Qd for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 14:04:45 +0000 Received: by mail-wr1-x433.google.com with SMTP id w4so12861431wrt.5 for ; Tue, 13 Apr 2021 07:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=h/8wbVDaxKr1pxr3xsfJZCxLfYGtm7wlDkUhOm6t6b4=; b=hBQxBj0oG2Kel7df7Of3iDfJUusA0RF8LI9lu89GN9KaVP3u88gTytEJBBpdsiVttV YZ23pgKYTDa2Wpql6LfNMUnLc8cDfge7j+LpE2twGRdxL61RruI8j3w8X3C1W2c8qKCi 7PYPZXvhwHo2HF1035nYZPcCpRc+lDkkA8HOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=h/8wbVDaxKr1pxr3xsfJZCxLfYGtm7wlDkUhOm6t6b4=; b=uH/ZMrx1iJaMOiMJV/rVlKj30UJME35J+bDVhVdjliEZ0UwWyZniWq7KFKHoDn49pq o2Vw+xdzQYYHnyT7C+JCOK4tRY6g9UcCQ+GG94atB95JxL9HeKO4A+JbvjK/8+8PLaXY 6+UseOPUNRI85moVc81vaGgjN0SmqlkBYOdzwQiPUWcEQwA+eftZnNN1AgGmjnLpXXNg Ytd/S92e9M+rdNGYR0JGBflTRbniVcxC+xDER9BvR1r4GL9F327rPgxfhP027l0RUz/l VO2cJzW9uGHQ/yobB0+lVAzS1aCpBBXcl0ItMsy0fJGxhAoFAhvBI17PVBdnJBgzTm9j BYgQ== X-Gm-Message-State: AOAM533CPln5iJ7kywiuvHPBWmBDpOPrVgcQlKUsuNMxbXww/DF5dT7Z MeUxjnK6xSLIjqPZdsBBkfgWow== X-Google-Smtp-Source: ABdhPJxIskl1NS0XtaVK2rXOOyH64CtwzDZOqUuJOxxyU93tTi9dGB9/qlYK4sqT5VsoRX9bJngn6Q== X-Received: by 2002:adf:b608:: with SMTP id f8mr15474341wre.338.1618322681172; Tue, 13 Apr 2021 07:04:41 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h9sm2584304wmb.35.2021.04.13.07.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:04:39 -0700 (PDT) Date: Tue, 13 Apr 2021 16:04:37 +0200 From: Daniel Vetter To: Lucas Stach Cc: Daniel Vetter , DRI Development , Pengutronix Kernel Team , Intel Graphics Development , NXP Linux Team , Daniel Vetter , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly Message-ID: References: <20210413094904.3736372-1-daniel.vetter@ffwll.ch> <20210413094904.3736372-5-daniel.vetter@ffwll.ch> <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_070444_035517_07583FB0 X-CRM114-Status: GOOD ( 26.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > = > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski > > Date: Fri Jan 4 09:56:10 2019 +0100 > > = > > =A0=A0=A0=A0drm: Auto-set allow_fb_modifiers when given modifiers at pl= ane init > > = > > this is done automatically as part of plane init, if drivers set the > > modifier list correctly. Which is the case here. > > = > > This one actually set it twice on top of what drm_plane_init does, so > > double-redundant! > = > That's not true. imx-dcss and imx-drm are two totally separate drivers. > Maybe we should move imx-drm into its own ipuv3 directory one day to > make this more clear. Change is still correct, though. Hm I greeped for drm_universal_plane_init and didn't find anythinf for the imx main driver ... where are planes set up for that? Need to review that they have the modifiers listed in all cases. -Daniel > = > Reviewed-by: Lucas Stach > = > > Signed-off-by: Daniel Vetter > > Cc: Philipp Zabel > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > =A0drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > =A0drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > =A02 files changed, 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/= dcss/dcss-kms.c > > index b549ce5e7607..37ae68a7fba5 100644 > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms= _dev *kms) > > =A0 config->min_height =3D 1; > > =A0 config->max_width =3D 4096; > > =A0 config->max_height =3D 4096; > > - config->allow_fb_modifiers =3D true; > > =A0 config->normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 config->funcs =3D &dcss_drm_mode_config_funcs; > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/i= mx-drm-core.c > > index 2ded8e4f32d0..8be4edaec958 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > =A0 drm->mode_config.max_height =3D 4096; > > =A0 drm->mode_config.funcs =3D &imx_drm_mode_config_funcs; > > =A0 drm->mode_config.helper_private =3D &imx_drm_mode_config_helpers; > > - drm->mode_config.allow_fb_modifiers =3D true; > > =A0 drm->mode_config.normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 ret =3D drmm_mode_config_init(drm); > = > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D85EC43462 for ; Tue, 13 Apr 2021 14:04:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8BA061206 for ; Tue, 13 Apr 2021 14:04:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8BA061206 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B75E188D96; Tue, 13 Apr 2021 14:04:43 +0000 (UTC) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AAF389024 for ; Tue, 13 Apr 2021 14:04:42 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id p6so9883485wrn.9 for ; Tue, 13 Apr 2021 07:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=h/8wbVDaxKr1pxr3xsfJZCxLfYGtm7wlDkUhOm6t6b4=; b=hBQxBj0oG2Kel7df7Of3iDfJUusA0RF8LI9lu89GN9KaVP3u88gTytEJBBpdsiVttV YZ23pgKYTDa2Wpql6LfNMUnLc8cDfge7j+LpE2twGRdxL61RruI8j3w8X3C1W2c8qKCi 7PYPZXvhwHo2HF1035nYZPcCpRc+lDkkA8HOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=h/8wbVDaxKr1pxr3xsfJZCxLfYGtm7wlDkUhOm6t6b4=; b=WtRyLVTWhNkxCX/P5397z1bdCYPGkqqkGuTcbC37sQWYdzAEGVyYRVvjRxuasP2VnC ywHddTCP65+dMcgH5Z4XWZwC2ofKk+J6oC0Ls3C0/aO7IIxlipNNdUszC8uFiD/o85Ks iTw/frWf/OVpJPhW7Te6tHBrZwpLkOOi6pjN8qWWsFTdGHzUWV/dfzc5swJ8yM7PGoGu M767w25qGBxN1iuG+Z8H8hUzjhdHsZQj7JLUivzkzN7oP3TyPrE56+Kv8CR1UMOINBv8 zWpC0Y87acsU6I4NV/CFXbEnZZg4vp0fedNLHEkBotHMevml+2/6FYojB9SYbI0PEu9s IQ9A== X-Gm-Message-State: AOAM532B0eHY3/RWhTsbkf8x2sLVK33VHegvZGUv+p1o2pr+s2PxCvFg 0OwZaD4inStoPOi6BLyQfDbx5Q== X-Google-Smtp-Source: ABdhPJxIskl1NS0XtaVK2rXOOyH64CtwzDZOqUuJOxxyU93tTi9dGB9/qlYK4sqT5VsoRX9bJngn6Q== X-Received: by 2002:adf:b608:: with SMTP id f8mr15474341wre.338.1618322681172; Tue, 13 Apr 2021 07:04:41 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h9sm2584304wmb.35.2021.04.13.07.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:04:39 -0700 (PDT) Date: Tue, 13 Apr 2021 16:04:37 +0200 From: Daniel Vetter To: Lucas Stach Subject: Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly Message-ID: References: <20210413094904.3736372-1-daniel.vetter@ffwll.ch> <20210413094904.3736372-5-daniel.vetter@ffwll.ch> <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , NXP Linux Team , Pengutronix Kernel Team , Daniel Vetter , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > = > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski > > Date: Fri Jan 4 09:56:10 2019 +0100 > > = > > =A0=A0=A0=A0drm: Auto-set allow_fb_modifiers when given modifiers at pl= ane init > > = > > this is done automatically as part of plane init, if drivers set the > > modifier list correctly. Which is the case here. > > = > > This one actually set it twice on top of what drm_plane_init does, so > > double-redundant! > = > That's not true. imx-dcss and imx-drm are two totally separate drivers. > Maybe we should move imx-drm into its own ipuv3 directory one day to > make this more clear. Change is still correct, though. Hm I greeped for drm_universal_plane_init and didn't find anythinf for the imx main driver ... where are planes set up for that? Need to review that they have the modifiers listed in all cases. -Daniel > = > Reviewed-by: Lucas Stach > = > > Signed-off-by: Daniel Vetter > > Cc: Philipp Zabel > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > =A0drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > =A0drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > =A02 files changed, 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/= dcss/dcss-kms.c > > index b549ce5e7607..37ae68a7fba5 100644 > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms= _dev *kms) > > =A0 config->min_height =3D 1; > > =A0 config->max_width =3D 4096; > > =A0 config->max_height =3D 4096; > > - config->allow_fb_modifiers =3D true; > > =A0 config->normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 config->funcs =3D &dcss_drm_mode_config_funcs; > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/i= mx-drm-core.c > > index 2ded8e4f32d0..8be4edaec958 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > =A0 drm->mode_config.max_height =3D 4096; > > =A0 drm->mode_config.funcs =3D &imx_drm_mode_config_funcs; > > =A0 drm->mode_config.helper_private =3D &imx_drm_mode_config_helpers; > > - drm->mode_config.allow_fb_modifiers =3D true; > > =A0 drm->mode_config.normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 ret =3D drmm_mode_config_init(drm); > = > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D05BC433B4 for ; Tue, 13 Apr 2021 14:04:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B31B611CE for ; Tue, 13 Apr 2021 14:04:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B31B611CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E66BE89024; Tue, 13 Apr 2021 14:04:43 +0000 (UTC) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7974788D96 for ; Tue, 13 Apr 2021 14:04:42 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id 12so16616644wrz.7 for ; Tue, 13 Apr 2021 07:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=h/8wbVDaxKr1pxr3xsfJZCxLfYGtm7wlDkUhOm6t6b4=; b=hBQxBj0oG2Kel7df7Of3iDfJUusA0RF8LI9lu89GN9KaVP3u88gTytEJBBpdsiVttV YZ23pgKYTDa2Wpql6LfNMUnLc8cDfge7j+LpE2twGRdxL61RruI8j3w8X3C1W2c8qKCi 7PYPZXvhwHo2HF1035nYZPcCpRc+lDkkA8HOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=h/8wbVDaxKr1pxr3xsfJZCxLfYGtm7wlDkUhOm6t6b4=; b=HTelLndjc3zz8TVcfUMbJTPuOy27VsSzwYUQOgAhepz4upXEk5PDbGgeJwvMAVsC3c UcliAyk/o2eUoLrrFk75khnmcYYMJREDyJzysIcgcPxMdiKC8pyKu5uBXHkdpsmsGZxW F6Pi410S62SNUj1mXz1jCBcaWBwIoFM93QPYRVq3uX0yhekTOxShC3pUSX2DeAVfMtsl TSSlD+cNRJjFIpkhMuR9MtjlDsrI1WhYP7jFZ7/YFqx8iIk8cSUcaGtin/HL7iJmKut+ H/FZfSLNG5WdNpZtwINKd0678HTJ1IUAV0p60WBFpT3LgY1gDMG5ONf+XWQiyBVNVZy1 UAZA== X-Gm-Message-State: AOAM5333KCSDECfIFkrBm+Zzg9VZ4FbS+l5y8sfRDz3YBzSBtgS/oqBM ilfn0SbtIK1rsOsoDF5RN4iVhA== X-Google-Smtp-Source: ABdhPJxIskl1NS0XtaVK2rXOOyH64CtwzDZOqUuJOxxyU93tTi9dGB9/qlYK4sqT5VsoRX9bJngn6Q== X-Received: by 2002:adf:b608:: with SMTP id f8mr15474341wre.338.1618322681172; Tue, 13 Apr 2021 07:04:41 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h9sm2584304wmb.35.2021.04.13.07.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:04:39 -0700 (PDT) Date: Tue, 13 Apr 2021 16:04:37 +0200 From: Daniel Vetter To: Lucas Stach Message-ID: References: <20210413094904.3736372-1-daniel.vetter@ffwll.ch> <20210413094904.3736372-5-daniel.vetter@ffwll.ch> <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> X-Operating-System: Linux phenom 5.7.0-1-amd64 Subject: Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , NXP Linux Team , Pengutronix Kernel Team , Daniel Vetter , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > = > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski > > Date: Fri Jan 4 09:56:10 2019 +0100 > > = > > =A0=A0=A0=A0drm: Auto-set allow_fb_modifiers when given modifiers at pl= ane init > > = > > this is done automatically as part of plane init, if drivers set the > > modifier list correctly. Which is the case here. > > = > > This one actually set it twice on top of what drm_plane_init does, so > > double-redundant! > = > That's not true. imx-dcss and imx-drm are two totally separate drivers. > Maybe we should move imx-drm into its own ipuv3 directory one day to > make this more clear. Change is still correct, though. Hm I greeped for drm_universal_plane_init and didn't find anythinf for the imx main driver ... where are planes set up for that? Need to review that they have the modifiers listed in all cases. -Daniel > = > Reviewed-by: Lucas Stach > = > > Signed-off-by: Daniel Vetter > > Cc: Philipp Zabel > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > =A0drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > =A0drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > =A02 files changed, 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/= dcss/dcss-kms.c > > index b549ce5e7607..37ae68a7fba5 100644 > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms= _dev *kms) > > =A0 config->min_height =3D 1; > > =A0 config->max_width =3D 4096; > > =A0 config->max_height =3D 4096; > > - config->allow_fb_modifiers =3D true; > > =A0 config->normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 config->funcs =3D &dcss_drm_mode_config_funcs; > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/i= mx-drm-core.c > > index 2ded8e4f32d0..8be4edaec958 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > =A0 drm->mode_config.max_height =3D 4096; > > =A0 drm->mode_config.funcs =3D &imx_drm_mode_config_funcs; > > =A0 drm->mode_config.helper_private =3D &imx_drm_mode_config_helpers; > > - drm->mode_config.allow_fb_modifiers =3D true; > > =A0 drm->mode_config.normalize_zpos =3D true; > > =A0 > > = > > = > > = > > =A0 ret =3D drmm_mode_config_init(drm); > = > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx