From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FBAC433ED for ; Tue, 13 Apr 2021 23:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAE9661244 for ; Tue, 13 Apr 2021 23:12:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348779AbhDMXM3 (ORCPT ); Tue, 13 Apr 2021 19:12:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:42110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348771AbhDMXM1 (ORCPT ); Tue, 13 Apr 2021 19:12:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A3C360238; Tue, 13 Apr 2021 23:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618355527; bh=theE9w+VmO2/VI5mSH45o6r0hr0DMFTHT8weF9dix0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n0LuWHUYpOtZEqB9zMMa7I5H5bKdRPfEy8BDEKIENENB7b+3nkgVW9Tbgq65Z+VbQ YIEcyR0qUqG0OQPoJIRbO4EJ9tn268lYbEkIRK0xuNAOUVh/NQbjoRU+DsEmkSk3eZ b0jdJRvTaEnrw2SMezZm6KkcMlXy0Ic4SdRw/zCwB7fpWo+hiKY8hU+M+08SwF5l60 WU2ssACNqOnDQwPoSaS3l/X2KP4ZA27iX91n5MAzgYr4oy9zVHNJSji+SwgwkbW4WD 1abFBlUnsaKANcU6vvDsW4qN2Ok+KSdXYKdGrB/UMMdEyLdotKGlfbbTKfM3Cf+/HP 38SWTtx2gD4Jw== Date: Tue, 13 Apr 2021 16:12:02 -0700 From: Nathan Chancellor To: Nick Desaulniers Cc: Catalin Marinas , Will Deacon , vincenzo.frascino@arm.com, Masahiro Yamada , Bill Wendling , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] arm64: vdso32: drop -no-integrated-as flag Message-ID: References: <20210413230609.3114365-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210413230609.3114365-1-ndesaulniers@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 04:06:06PM -0700, Nick Desaulniers wrote: > Clang can assemble these files just fine; this is a relic from the top > level Makefile conditionally adding this. > > To test building: > $ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ > CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make LLVM=1 LLVM_IAS=1 \ > defconfig arch/arm64/kernel/vdso32/ > > Signed-off-by: Nick Desaulniers > --- > arch/arm64/kernel/vdso32/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 789ad420f16b..7812717f8b79 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -15,7 +15,7 @@ COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) > > CC_COMPAT_CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > CC_COMPAT_CLANG_FLAGS += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE_COMPAT)) > -CC_COMPAT_CLANG_FLAGS += -no-integrated-as -Qunused-arguments > +CC_COMPAT_CLANG_FLAGS += -Qunused-arguments Might as well just eliminate '--prefix=' and '--gcc-toolchain=' along with the variables COMPAT_GCC_TOOLCHAIN_DIR and COMPAT_GCC_TOOLCHAIN while you are at it, they serve no purpose without '-no-integrated-as'. > ifneq ($(COMPAT_GCC_TOOLCHAIN),) > CC_COMPAT_CLANG_FLAGS += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > endif > -- > 2.31.1.295.g9ea45b61b8-goog > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CA5C433ED for ; Tue, 13 Apr 2021 23:13:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9BF161242 for ; Tue, 13 Apr 2021 23:13:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9BF161242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t0DVayFdg7enU9ozbT6sd8iWhF01TNWjty4qp0sW0+M=; b=RT4pvR/8fV+QiHfXkAjM38VG2 fsdy9E93jjFkGXBmStRGEl1UWOa96Nkm7rI4OxJLfEvDQvKdTzBgADvJPRsT/1L3Kcmid89lYSXEL 5OwX7A6pBAG4J+B+7fbng3VSgasBiqWEVAxHH3FaTDhg+oMUNFCeOAA8c83MHuH//+CUg6AmLB7kX aqB7TGVQbzg3e2wVEIx4Xs0MgbaNv+6Fl7st0UFdHiIJWud/m3N5oSesYm3/426l3+k6LixZ5kapA g0el2FOTpYfeeY7RaNCwGhan2Xl9Db/Zimd/yTi9lE0OtujlTw1C/6EgeJnW3vNxNXfh+rDazbOVC saWJyUr7A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWSCb-00AmB5-Ag; Tue, 13 Apr 2021 23:12:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWSCY-00AmAi-Ub for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 23:12:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ova/kLbFwlnelXNEgz1AUU7MEamvxIbMbHTIsubIKU4=; b=bbnuD/PIRWWKSp86CJ/Qqa/EWH cydvytdxgFE/LQD5JDUTQjUSTZjqXyaKLEjJrXZBRf95UjV06GzohQNlkH9xLWTBFgO8nzz7cuUil DhW/RDhYKWTrgwrUmZuRajUbsDkD+bbKZ23hB+IagBHOlr6vWhqLnZdLHgToU7pob8m9vRjcQdydR pLk8jk8uOeAj2cZhTtM/aR4yEZVfyY/oBx2TkjwL2hVKxYvR783l0Vcx1RFRIshvvP2/uB6DKAhft fjNWphSf/rvzdRTal19Zy3Zp4X5Z8XTmbjzgHuhmfgmh1NkebhUdaQbAGd2dG3aaMy7dlxuCWuNnS 0zxUMr1Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWSCW-007NX4-Ce for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 23:12:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A3C360238; Tue, 13 Apr 2021 23:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618355527; bh=theE9w+VmO2/VI5mSH45o6r0hr0DMFTHT8weF9dix0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n0LuWHUYpOtZEqB9zMMa7I5H5bKdRPfEy8BDEKIENENB7b+3nkgVW9Tbgq65Z+VbQ YIEcyR0qUqG0OQPoJIRbO4EJ9tn268lYbEkIRK0xuNAOUVh/NQbjoRU+DsEmkSk3eZ b0jdJRvTaEnrw2SMezZm6KkcMlXy0Ic4SdRw/zCwB7fpWo+hiKY8hU+M+08SwF5l60 WU2ssACNqOnDQwPoSaS3l/X2KP4ZA27iX91n5MAzgYr4oy9zVHNJSji+SwgwkbW4WD 1abFBlUnsaKANcU6vvDsW4qN2Ok+KSdXYKdGrB/UMMdEyLdotKGlfbbTKfM3Cf+/HP 38SWTtx2gD4Jw== Date: Tue, 13 Apr 2021 16:12:02 -0700 From: Nathan Chancellor To: Nick Desaulniers Cc: Catalin Marinas , Will Deacon , vincenzo.frascino@arm.com, Masahiro Yamada , Bill Wendling , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] arm64: vdso32: drop -no-integrated-as flag Message-ID: References: <20210413230609.3114365-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210413230609.3114365-1-ndesaulniers@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_161208_466212_B6969AD0 X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 13, 2021 at 04:06:06PM -0700, Nick Desaulniers wrote: > Clang can assemble these files just fine; this is a relic from the top > level Makefile conditionally adding this. > > To test building: > $ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ > CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make LLVM=1 LLVM_IAS=1 \ > defconfig arch/arm64/kernel/vdso32/ > > Signed-off-by: Nick Desaulniers > --- > arch/arm64/kernel/vdso32/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 789ad420f16b..7812717f8b79 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -15,7 +15,7 @@ COMPAT_GCC_TOOLCHAIN := $(realpath $(COMPAT_GCC_TOOLCHAIN_DIR)/..) > > CC_COMPAT_CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE_COMPAT:%-=%)) > CC_COMPAT_CLANG_FLAGS += --prefix=$(COMPAT_GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE_COMPAT)) > -CC_COMPAT_CLANG_FLAGS += -no-integrated-as -Qunused-arguments > +CC_COMPAT_CLANG_FLAGS += -Qunused-arguments Might as well just eliminate '--prefix=' and '--gcc-toolchain=' along with the variables COMPAT_GCC_TOOLCHAIN_DIR and COMPAT_GCC_TOOLCHAIN while you are at it, they serve no purpose without '-no-integrated-as'. > ifneq ($(COMPAT_GCC_TOOLCHAIN),) > CC_COMPAT_CLANG_FLAGS += --gcc-toolchain=$(COMPAT_GCC_TOOLCHAIN) > endif > -- > 2.31.1.295.g9ea45b61b8-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel