From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D759C433B4 for ; Sat, 17 Apr 2021 23:01:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3548D6102A for ; Sat, 17 Apr 2021 23:01:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237101AbhDQXBg (ORCPT ); Sat, 17 Apr 2021 19:01:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237088AbhDQXBf (ORCPT ); Sat, 17 Apr 2021 19:01:35 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7424C06174A for ; Sat, 17 Apr 2021 16:01:08 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 78352B9C; Sun, 18 Apr 2021 01:01:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618700464; bh=p4TxTvsF49EuO2cUXaly1m7YLeJDo+Zk+ZRU6OEd+KI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cu9xjd1LLDNbixq1qRKMMY37FrRooS2JgJjzbSiU/1L67tvU4oXbk7eaGuC2hYQ2W UPavbs78ZALFrwVEDBDn2HfVx1wck6PgpkcPJxwzrmpjNXCgIMW2GRBGM04NW2x/a5 1z+J+G4HaL4MuAlS5OCa7VZXFDqJA6ZdLHTWCNlE= Date: Sun, 18 Apr 2021 02:01:02 +0300 From: Laurent Pinchart To: Tomi Valkeinen Cc: Benoit Parrot , Pratyush Yadav , Lokesh Vutla , linux-media@vger.kernel.org Subject: Re: [PATCH 01/28] media: ti-vpe: cal: add g/s_parm for legacy API Message-ID: References: <20210412113457.328012-1-tomi.valkeinen@ideasonboard.com> <20210412113457.328012-2-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210412113457.328012-2-tomi.valkeinen@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Tomi, Thank you for the patch. On Mon, Apr 12, 2021 at 02:34:30PM +0300, Tomi Valkeinen wrote: > v4l2-compliance complains about g/s_parm when using the non-MC API. Fix > it by adding the functions and just call v4l2_s/g_parm_cap for the > phy subdev. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/ti-vpe/cal-video.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/media/platform/ti-vpe/cal-video.c b/drivers/media/platform/ti-vpe/cal-video.c > index 7b7436a355ee..86d7cdd27224 100644 > --- a/drivers/media/platform/ti-vpe/cal-video.c > +++ b/drivers/media/platform/ti-vpe/cal-video.c > @@ -388,6 +388,20 @@ static int cal_enum_frameintervals(struct file *file, void *priv, > return 0; > } > > +static int cal_g_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > +{ > + struct cal_ctx *ctx = video_drvdata(file); > + > + return v4l2_g_parm_cap(video_devdata(file), ctx->phy->sensor, a); > +} > + > +static int cal_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > +{ > + struct cal_ctx *ctx = video_drvdata(file); > + > + return v4l2_s_parm_cap(video_devdata(file), ctx->phy->sensor, a); > +} > + > static const struct v4l2_ioctl_ops cal_ioctl_video_ops = { > .vidioc_querycap = cal_querycap, > .vidioc_enum_fmt_vid_cap = cal_enum_fmt_vid_cap, > @@ -411,6 +425,8 @@ static const struct v4l2_ioctl_ops cal_ioctl_video_ops = { > .vidioc_log_status = v4l2_ctrl_log_status, > .vidioc_subscribe_event = v4l2_ctrl_subscribe_event, > .vidioc_unsubscribe_event = v4l2_event_unsubscribe, > + .vidioc_g_parm = cal_g_parm, > + .vidioc_s_parm = cal_s_parm, > }; > > /* ------------------------------------------------------------------ -- Regards, Laurent Pinchart