From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D5BC433B4 for ; Sun, 18 Apr 2021 08:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BAF8600CD for ; Sun, 18 Apr 2021 08:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhDRIUh (ORCPT ); Sun, 18 Apr 2021 04:20:37 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:48045 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhDRIUg (ORCPT ); Sun, 18 Apr 2021 04:20:36 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D21135C06B1; Sun, 18 Apr 2021 04:20:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 18 Apr 2021 04:20:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=d7X8OG FVFOhDXCmZyOMBVNJkgbqgwpPEDeOT/pCuT34=; b=Dh6/1Ts7vLH5n4pGhm1xhd aQ/i6HcTldn9WUZgqC4sbDS8cpKl8VWoZj3NvlgaZg1bPjxTr8alz4kvw7+3c/HB //PFNCckLCK/aXm1Q5RspG0Z6r0+t3/hH7TXaY6kZwL4xbQP223ptLwl8Nu4N3wd pv5VhzG5Wtl27IHcns6YoCfQ1LlACSVDCKQuGQVG2f6E9zZ7YjBg21tU2Xl6vJds 4T6pkmCwZ1u8qsML3FjmjmGjD+pG3DGHXdwBOQ8dXtZoOoPxwB/anUC8kjehr0O6 /rvVjCUa7WwLSA2QuBp5qwHojBngxirZY+3BpVKcNx1qGdf5mTugwz+VOLPTEgaw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelkedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiugho shgthhdrohhrgheqnecuggftrfgrthhtvghrnheptdffkeekfeduffevgeeujeffjefhte fgueeugfevtdeiheduueeukefhudehleetnecukfhppeduleefrdegjedrudeihedrvdeh udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 3A22D1080063; Sun, 18 Apr 2021 04:20:07 -0400 (EDT) Date: Sun, 18 Apr 2021 11:20:04 +0300 From: Ido Schimmel To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch, mkubecek@suse.cz, idosch@nvidia.com, saeedm@nvidia.com, michael.chan@broadcom.com Subject: Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats Message-ID: References: <20210416192745.2851044-1-kuba@kernel.org> <20210416192745.2851044-4-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416192745.2851044-4-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 16, 2021 at 12:27:39PM -0700, Jakub Kicinski wrote: > +static int stats_prepare_data(const struct ethnl_req_info *req_base, > + struct ethnl_reply_data *reply_base, > + struct genl_info *info) > +{ > + const struct stats_req_info *req_info = STATS_REQINFO(req_base); > + struct stats_reply_data *data = STATS_REPDATA(reply_base); > + struct net_device *dev = reply_base->dev; > + int ret; > + > + ret = ethnl_ops_begin(dev); > + if (ret < 0) > + return ret; > + Nit: A comment here would be nice. Something like: Mark all stats as unset (see ETHTOOL_STAT_NOT_SET) to prevent them from being reported to user space in case driver did not set them. > + memset(&data->phy_stats, 0xff, sizeof(data->phy_stats)); > + > + if (test_bit(ETHTOOL_STATS_ETH_PHY, req_info->stat_mask) && > + dev->ethtool_ops->get_eth_phy_stats) > + dev->ethtool_ops->get_eth_phy_stats(dev, &data->phy_stats); > + > + ethnl_ops_complete(dev); > + return 0; > +}