From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF76BC433ED for ; Sun, 18 Apr 2021 13:00:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A5D2610FC for ; Sun, 18 Apr 2021 13:00:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbhDRNBI (ORCPT ); Sun, 18 Apr 2021 09:01:08 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:59306 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhDRNBI (ORCPT ); Sun, 18 Apr 2021 09:01:08 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EE88499; Sun, 18 Apr 2021 15:00:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618750839; bh=w4IYY4apxr7tnmQBBiqMZk4DROdU7bq8CvtCafCiPRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJ4J1wY0BCsh83gyqJfelEo2zLVKvfHye/1AG4PwbXXVTrWpwEkAmHxmYCdVfdjgI lOs9d8bhADG1XrvHiTU2u5C5NOHG7AtCK/Ao5UCxdiiQRzdwcx9gwwj9xPCiIaVeTs 62JmPZ5lUmLIuqCY8mfwpKPZ//21W21Nh5iiJjm4= Date: Sun, 18 Apr 2021 16:00:36 +0300 From: Laurent Pinchart To: Tomi Valkeinen Cc: Benoit Parrot , Pratyush Yadav , Lokesh Vutla , linux-media@vger.kernel.org Subject: Re: [PATCH 18/28] media: ti-vpe: cal: add 'use_pix_proc' field Message-ID: References: <20210412113457.328012-1-tomi.valkeinen@ideasonboard.com> <20210412113457.328012-19-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210412113457.328012-19-tomi.valkeinen@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Tomi, Thank you for the patch. On Mon, Apr 12, 2021 at 02:34:47PM +0300, Tomi Valkeinen wrote: > We already have functions to reserve and release a pix proc unit, but we > always reserve such and the code expects the pix proc unit to be used. > > Add a new field, 'use_pix_proc', to indicate if the pix prox unit has > been reserved and should be used. Use the flag to skip programming pix > proc unit when not needed. > > Note that we still always set the use_pix_proc flag to true. > > Signed-off-by: Tomi Valkeinen > --- > drivers/media/platform/ti-vpe/cal.c | 10 +++++++--- > drivers/media/platform/ti-vpe/cal.h | 2 ++ > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c > index e397f59d3bbc..a1d173bd4613 100644 > --- a/drivers/media/platform/ti-vpe/cal.c > +++ b/drivers/media/platform/ti-vpe/cal.c > @@ -473,13 +473,15 @@ int cal_ctx_prepare(struct cal_ctx *ctx) > } > > ctx->pix_proc = ret; > + ctx->use_pix_proc = true; > > return 0; > } > > void cal_ctx_unprepare(struct cal_ctx *ctx) > { > - cal_release_pix_proc(ctx->cal, ctx->pix_proc); > + if (ctx->use_pix_proc) > + cal_release_pix_proc(ctx->cal, ctx->pix_proc); > } > > void cal_ctx_start(struct cal_ctx *ctx) > @@ -489,7 +491,8 @@ void cal_ctx_start(struct cal_ctx *ctx) > > /* Configure the CSI-2, pixel processing and write DMA contexts. */ > cal_ctx_csi2_config(ctx); > - cal_ctx_pix_proc_config(ctx); > + if (ctx->use_pix_proc) > + cal_ctx_pix_proc_config(ctx); > cal_ctx_wr_dma_config(ctx); > > /* Enable IRQ_WDMA_END and IRQ_WDMA_START. */ > @@ -530,7 +533,8 @@ void cal_ctx_stop(struct cal_ctx *ctx) > cal_write(ctx->cal, CAL_CSI2_CTX(ctx->phy->instance, ctx->ppi_ctx), 0); > > /* Disable pix proc */ > - cal_write(ctx->cal, CAL_PIX_PROC(ctx->pix_proc), 0); > + if (ctx->use_pix_proc) > + cal_write(ctx->cal, CAL_PIX_PROC(ctx->pix_proc), 0); > } > > /* ------------------------------------------------------------------ > diff --git a/drivers/media/platform/ti-vpe/cal.h b/drivers/media/platform/ti-vpe/cal.h > index 01e05e46e48d..409b7276a1fa 100644 > --- a/drivers/media/platform/ti-vpe/cal.h > +++ b/drivers/media/platform/ti-vpe/cal.h > @@ -223,6 +223,8 @@ struct cal_ctx { > u8 cport; > u8 ppi_ctx; > u8 pix_proc; > + > + bool use_pix_proc; Indentation ? How about turning pix_proc to a signed value, and using -1 to indicate it's not used ? Reviewed-by: Laurent Pinchart > }; > > extern unsigned int cal_debug; -- Regards, Laurent Pinchart