From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B45C433ED for ; Sun, 18 Apr 2021 19:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9373A610CC for ; Sun, 18 Apr 2021 19:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbhDRTZ2 (ORCPT ); Sun, 18 Apr 2021 15:25:28 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:32876 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbhDRTZ1 (ORCPT ); Sun, 18 Apr 2021 15:25:27 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CC414AB; Sun, 18 Apr 2021 21:24:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618773898; bh=cjOHviHz7IOugD0YJQY3JOSu+gSyWZBZA4X/mbDDvcg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dcU+AwJTKHIyivFFBTYYxq+htLj2pJaRWFnz8Oz8b4TnFbC9uNQBQiqDns+nTOmbk YUQwd0nrU3wonQff94m+rFZiZAJQGcrxgqWxn8airTlrhZKLjb6fyA2hP1lxNthCQO vnpIiTEXNdAlEzc1eRHC4kz/QPNZc/I9IhOxFUSg= Date: Sun, 18 Apr 2021 22:24:54 +0300 From: Laurent Pinchart To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, Jacopo Mondi , niklas.soderlund+renesas@ragnatech.se, Mauro Carvalho Chehab , Hans Verkuil Subject: Re: [PATCH v5 16/24] v4l: Add CSI-2 bus configuration to frame descriptors Message-ID: References: <20210415130450.421168-1-tomi.valkeinen@ideasonboard.com> <20210415130450.421168-17-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210415130450.421168-17-tomi.valkeinen@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Tomi and Sakari, Thank you for the patch. On Thu, Apr 15, 2021 at 04:04:42PM +0300, Tomi Valkeinen wrote: > From: Sakari Ailus > > Add CSI-2 bus specific configuration to the frame descriptors. This allows > obtaining the virtual channel and data type information for each stream > the transmitter is sending. > > Signed-off-by: Sakari Ailus > Reviewed-by: Niklas Söderlund > Reviewed-by: Jacopo Mondi > --- > include/media/v4l2-subdev.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index 85977abbea46..30ec011d31e3 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -308,6 +308,17 @@ struct v4l2_subdev_audio_ops { > int (*s_stream)(struct v4l2_subdev *sd, int enable); > }; > > +/** > + * struct v4l2_mbus_frame_desc_entry_csi2 > + * > + * @channel: CSI-2 virtual channel Maybe s/channel/virtual_channel/ ? Or vc and dt ? > + * @data_type: CSI-2 data type ID > + */ > +struct v4l2_mbus_frame_desc_entry_csi2 { > + u8 channel; > + u8 data_type; > +}; > + > /** > * enum v4l2_mbus_frame_desc_flags - media bus frame description flags > * > @@ -331,11 +342,16 @@ enum v4l2_mbus_frame_desc_flags { > * %FRAME_DESC_FL_BLOB is not set. > * @length: number of octets per frame, valid if @flags > * %V4L2_MBUS_FRAME_DESC_FL_LEN_MAX is set. > + * @bus: Bus specific frame descriptor parameters s/Bus specific/Bus-specific/ > + * @bus.csi2: CSI-2 specific bus configuration Ditto. Reviewed-by: Laurent Pinchart > */ > struct v4l2_mbus_frame_desc_entry { > enum v4l2_mbus_frame_desc_flags flags; > u32 pixelcode; > u32 length; > + union { > + struct v4l2_mbus_frame_desc_entry_csi2 csi2; > + } bus; > }; > > #define V4L2_FRAME_DESC_ENTRY_MAX 4 -- Regards, Laurent Pinchart