From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52738C433ED for ; Mon, 3 May 2021 12:22:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CBB561185 for ; Mon, 3 May 2021 12:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233520AbhECMXs (ORCPT ); Mon, 3 May 2021 08:23:48 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50822 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbhECMXq (ORCPT ); Mon, 3 May 2021 08:23:46 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ldXb7-002HuR-9P; Mon, 03 May 2021 14:22:49 +0200 Date: Mon, 3 May 2021 14:22:49 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory CLEMENT , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210429083636.22560-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210429083636.22560-1-pali@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Rohár wrote: > From: Marek Behún > > The status decoding function mox_get_status() currently contains a dead > code path: if the error status is not MBOX_STS_SUCCESS, it always > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and > we don't get the actual error code sent by the firmware. > > Fix this. > > Signed-off-by: Marek Behún > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver") You have put a fixes tag here, meaning you want it in stable? How does dead code elimination fulfil the stable requirements? Do any of these changes contain real fixes? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3140FC433B4 for ; Mon, 3 May 2021 12:24:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE528611CD for ; Mon, 3 May 2021 12:24:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE528611CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SnSHuxV9ZB0d5nqWymg3a6bV+dNA0DZv3g17EnmU/DI=; b=gHulBrtiOvN+VJzWDXrjJgvGi rcsINifnkE4giWswimatYh9qHdbdLEy/RK/SwMT7UL3nDJ2rbAsrEyjRzDiCrdOW1clP02U4ulrf/ QdqNsSkYGDZ8O+fm9acjtrsEsOKm5B0p5Nh73bxXuTggjdTbrd+NmVfIEeCDRrHK6G7C9d4SRw2Mw kaRNM/hNnyzRIm5G6q2uO8wsP8BawyCW2KC18gp7ruH/3L43Pm55VmeyF/V3uBKkI/W7qDMfzahir IFiwuxJvib+IS4F7T33eQBJvmwLB0L7UsnSi/Vh+bcczzGEued4Tvjx9kt929RwYy0F0FFe1mwjZR m92pKGKfg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldXbS-00DqXR-6Q; Mon, 03 May 2021 12:23:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldXbI-00DqWL-1t for linux-arm-kernel@desiato.infradead.org; Mon, 03 May 2021 12:23:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=gnPLJRqc6wLinvGJYVgJpXxuqqDFgdCXgvtPzeTviRc=; b=3In41NhvRD4CBCZvpVsRLm7exy ZnjRqa5hw20fLTViDWHjbr11DV5mAcNDXyRSySfCj2p8QL2GJNzjjwtjNs8sF1rNLe3ie2N8IOYra kPglKoHvEsQReXhS2IMAFHBjFNPKp/b2q7cpT8COb4tQlUiKkvdOPBxiMWqsNSDgO4KW/AuaN2Qji m9+n1tM9cdvrt92GFNLe2VkALZMzlZjNxDq5AIqARDUPjkqhXenoU2o+QkGuSOB3ojA/a2JmRMLQ+ qWRgVxDsulgBKqL1y6Vjo1QwsFi6DGGg3jXcD8LsyqV9CZzlHcR/E7sjPt0PNXNwcbswQgl+7hM6l qFB31nOA==; Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldXbF-0033Gb-LM for linux-arm-kernel@lists.infradead.org; Mon, 03 May 2021 12:22:58 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ldXb7-002HuR-9P; Mon, 03 May 2021 14:22:49 +0200 Date: Mon, 3 May 2021 14:22:49 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory CLEMENT , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210429083636.22560-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210429083636.22560-1-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210503_052257_721857_0181F147 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Roh=E1r wrote: > From: Marek Beh=FAn > = > The status decoding function mox_get_status() currently contains a dead > code path: if the error status is not MBOX_STS_SUCCESS, it always > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and > we don't get the actual error code sent by the firmware. > = > Fix this. > = > Signed-off-by: Marek Beh=FAn > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver") You have put a fixes tag here, meaning you want it in stable? How does dead code elimination fulfil the stable requirements? Do any of these changes contain real fixes? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel