From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2AFAC433B4 for ; Mon, 3 May 2021 04:56:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AD4360C3E for ; Mon, 3 May 2021 04:56:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AD4360C3E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldQdE-0003Km-9h for qemu-devel@archiver.kernel.org; Mon, 03 May 2021 00:56:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldQbg-0001Ro-TO; Mon, 03 May 2021 00:54:57 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:47441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldQbd-000804-12; Mon, 03 May 2021 00:54:56 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FYVyJ00grz9sTD; Mon, 3 May 2021 14:54:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1620017688; bh=1ET68Nz5Vx2bzVLMZxIOjXd7uFvgRDdthEdWJmqLc8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hi/kSh4/Dj0PEPAZuNBjtNYj/078xbw+vaO2K2dsYTKzdMV5cBuv73QFLq0ipzam7 j6nLT7PFKvgmG5xZApfskviVpsHFWnYPPJNoxr9hhVuDoFIvxJTDVtcnbYOJ1s1xV7 jnIItZMvjbgmbWSTZBu8sms6YPlUX8vmJcrW6Y5w= Date: Mon, 3 May 2021 14:39:43 +1000 From: David Gibson To: Richard Henderson Subject: Re: [PATCH v3 3/7] target/ppc: remove unnecessary SPR functions Message-ID: References: <20210430193533.82136-1-bruno.larsen@eldorado.org.br> <20210430193533.82136-4-bruno.larsen@eldorado.org.br> <8d2f4db4-ebf9-cf6f-ed3a-293f271ed34e@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FCH1lIn8l9vrG2dr" Content-Disposition: inline In-Reply-To: <8d2f4db4-ebf9-cf6f-ed3a-293f271ed34e@linaro.org> Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, qemu-devel@nongnu.org, lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, "Bruno Larsen \(billionai\)" , matheus.ferst@eldorado.org.br, luis.pires@eldorado.org.br Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --FCH1lIn8l9vrG2dr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 30, 2021 at 05:58:46PM -0700, Richard Henderson wrote: > On 4/30/21 12:35 PM, Bruno Larsen (billionai) wrote: > > Removed functions gen_read_xer and gen_write_xer, moving their logic > > directly into spr_read_xer and spr_write_xer, respectively. > >=20 > > Signed-off-by: Bruno Larsen (billionai) > > --- >=20 > "Unnecessary" makes me believe that the code isn't used at all. > A better description for this patch is >=20 > --- > target/ppc: Fold gen_{read,write}_xer into spr_{read,write}_xer >=20 > Fold these functions into their single caller. > --- Agreed. =20 > Otherwise, > Reviewed-by: Richard Henderson This one looks good to me now, whereas I still need to think about the rest of the code motion here. So, could you move this earlier in the series, before the creation of spr_tcg.inc.c, so I can go ahead and apply it while we continue discussing the rest. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --FCH1lIn8l9vrG2dr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmCPfo8ACgkQbDjKyiDZ s5J6rhAAkMeJ4aJ/RnUTEbM1Dn08O3CvUL10lBqtiFgfznwBO3n3KowmwuntpsLh 0YW7Tm12RqFiiB8zB8N+WpktSPQgkKGTPD93AYNMy1cDSoL/VH872F9ERsmCRfSB tzYksQhFJAB56MddoR7ourZDXuMvMTm45Ff3pXV4mKtJ5W4RH/HuZvCIsvue0IfG ZmWbc/HUV5Ju5iJpJ4Tt/AxUG8eIWFVoujiaiwvK5BIvgDYCC3JgDrmJlkjexIN8 E0zTvp5/BYESU1muUU5RqDTRMadjqxwzPdK7LVKx6ccflrnL9KHHznFgSvFK6Y4h jvVNCYoYC51Pn9NQFfUXTpPglJ6obx0tg3mA7XKh0L+bmiJ+eadPU8By93v9/AjZ XJp4Olf13Kw17Xmf9XQLBOtQDBuCtWMCj1OkRwjdlDFvC/Vrvf6s4vTqqOkabG9p b1yYyRGCbVprmr9hzeYjj+8FWrP80WdEVUDzrnNcYJdjaosNGvYChRPR9kapjh5f pzzVNjlbSMj74ollVgSFQiNsZlLq3LJ2rYW7TUVwAuLgcLpYDzAX3qjCwa7NlT88 v+TCFXNm8bW9DVjUNqpfLRsWUcYZNeqJVQXR8ThCY3tGsp1hjT9aiAOF4aaJMPeq O0Bs5cAMmPNuBMhZA8BOzswd6belTdDh/Rl1Hjo4IHrQgdXyFxw= =0+66 -----END PGP SIGNATURE----- --FCH1lIn8l9vrG2dr--