From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E423C433B4 for ; Wed, 21 Apr 2021 14:19:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 727FC61434 for ; Wed, 21 Apr 2021 14:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243573AbhDUOUH (ORCPT ); Wed, 21 Apr 2021 10:20:07 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:57081 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243454AbhDUOTQ (ORCPT ); Wed, 21 Apr 2021 10:19:16 -0400 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 5121C240003; Wed, 21 Apr 2021 14:18:38 +0000 (UTC) Date: Wed, 21 Apr 2021 16:18:37 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Claudiu Beznea , Thierry Reding , Lee Jones , linux-pwm@vger.kernel.org, Nicolas Ferre , Ludovic Desroches , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: overflow and wrong timeout errors in pwm-atmel Message-ID: References: <20210420095118.1571344-1-u.kleine-koenig@pengutronix.de> <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de> <20210421110336.bd5s6e2kjxqilddi@pengutronix.de> <20210421134825.powx5tvqvce32fho@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210421134825.powx5tvqvce32fho@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On 21/04/2021 15:48:25+0200, Uwe Kleine-König wrote: > On Wed, Apr 21, 2021 at 01:03:36PM +0200, Uwe Kleine-König wrote: > > On Wed, Apr 21, 2021 at 11:26:08AM +0200, Uwe Kleine-König wrote: > > > With these three patches PWM_DEBUG is now happy. (At least I couldn't > > > trigger a warning any more. I think there are still a few problems with > > > integer overflows.) > > > > BTW, setting the period to 138350580899 (with a clock rate of 133333333 > > Hz) results in setting period=0 because > > > > state->period * clkrate = > > 138350580899 * 133333333 = > > 40254751 (discarded from 18446744073749806367). > > As a first remedy the following could be done: > > diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c > index 38d86340201c..02d69fa5f7d2 100644 > --- a/drivers/pwm/pwm-atmel.c > +++ b/drivers/pwm/pwm-atmel.c > @@ -199,6 +199,11 @@ static int atmel_pwm_calculate_cprd_and_pres(struct pwm_chip *chip, > unsigned long long cycles = state->period; > int shift; > > + if (fls(cycles) + fls(clkrate) > 64) { > + dev_err(chip->dev, "period to big to calculate HW parameters\n"); > + return -EINVAL; > + } > + > /* Calculate the period cycles and prescale value */ > cycles *= clkrate; > do_div(cycles, NSEC_PER_SEC); > > Is this sensible? (Actually I'd prefer to just continue with > > period = (ULL(1) << (64 - fls(clkrate))) - 1 > > according to the motto to yield the highest possible period, but this > function has another error path that returns -EINVAL so this would be > inconsistent.) Shouldn't that be -ERANGE? I do think it is better to return an error and let userspace decide what is the policy instead of having the policy in the driver. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C97C433B4 for ; Wed, 21 Apr 2021 14:20:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 708BC6144B for ; Wed, 21 Apr 2021 14:20:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 708BC6144B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3AzZlzMRqJNNtjkqLPH1us8NCBM6bFwlMj6iT/OPtVE=; b=iemm5qVdnX3rYKrmO5iSOjheL h5EjLZxt5ZNviau0AR7IKoT4HTsIinCDNgtTGppCy+NyznwjZQK88QPVGNyKa/XFmiK/0Np4+XBUH k938DvUkSgLa4dkpn9elRSCRYKv/349j8MQZ4nAzQsCqOe99YLTgwItRJxp2Gudibcr6IEtrkOGt5 Cb2GTGH+utWMNOXMPgBiYkcRDVFKF2MY94nKYNDyKdhlhLNZTyRxvjXllsKH3H03ZMcqwvW7tDLgs smxuW0j1Ixl2PzT+yrP/v924atSFDhssIyFsPHGYSN2nHFrzNwGWkpr8zpFscg3Q9Y4PPv5McTRCH xc+ek+w+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZDgu-00EYq9-Eo; Wed, 21 Apr 2021 14:18:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZDgq-00EYp8-Ht for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 14:18:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=1496sN2o4cWKmzvyKf5OpI7/vwkUGHK6HXLqMC1T0Ls=; b=JnG2wbSo5LOe5LpV+txtNo5vaB fY24+Z1RaYW7Hc8ukLoL3oJMLK+qtHLDVbJmUzKabcfB24MLHLo9XHFLXwR4UD5atRdOjIwrc9u+h RO0jn5wSxr+MA/rNUFFuBjnncYwDG3+hKebkH8Xm2Q5/Z4DqW71vcLY2CR9mAWWx2cUMBUo3vMkry 08WN5N8N5aKa12ZTqb3lAhRnhz/Gk9tv2uk439Hj47C7LisHijBjZnEQHKax0zLoBgZo/bGG2bnaV rRJqiIIceiO8Hn8PjBGDimXBsw3LCQ47urNEBJf8kl5nW+gX8RERj2o3Y0RfSDLkiH800vR3DXaan xYVlDRkQ==; Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZDgn-00CwzM-1Y for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 14:18:51 +0000 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 5121C240003; Wed, 21 Apr 2021 14:18:38 +0000 (UTC) Date: Wed, 21 Apr 2021 16:18:37 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: overflow and wrong timeout errors in pwm-atmel Message-ID: References: <20210420095118.1571344-1-u.kleine-koenig@pengutronix.de> <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de> <20210421110336.bd5s6e2kjxqilddi@pengutronix.de> <20210421134825.powx5tvqvce32fho@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210421134825.powx5tvqvce32fho@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_071849_245241_93D0FBE2 X-CRM114-Status: GOOD ( 23.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Ludovic Desroches , Thierry Reding , kernel@pengutronix.de, Lee Jones , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/04/2021 15:48:25+0200, Uwe Kleine-K=F6nig wrote: > On Wed, Apr 21, 2021 at 01:03:36PM +0200, Uwe Kleine-K=F6nig wrote: > > On Wed, Apr 21, 2021 at 11:26:08AM +0200, Uwe Kleine-K=F6nig wrote: > > > With these three patches PWM_DEBUG is now happy. (At least I couldn't > > > trigger a warning any more. I think there are still a few problems wi= th > > > integer overflows.) > > = > > BTW, setting the period to 138350580899 (with a clock rate of 133333333 > > Hz) results in setting period=3D0 because > > = > > state->period * clkrate =3D > > 138350580899 * 133333333 =3D > > 40254751 (discarded from 18446744073749806367). > = > As a first remedy the following could be done: > = > diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c > index 38d86340201c..02d69fa5f7d2 100644 > --- a/drivers/pwm/pwm-atmel.c > +++ b/drivers/pwm/pwm-atmel.c > @@ -199,6 +199,11 @@ static int atmel_pwm_calculate_cprd_and_pres(struct = pwm_chip *chip, > unsigned long long cycles =3D state->period; > int shift; > = > + if (fls(cycles) + fls(clkrate) > 64) { > + dev_err(chip->dev, "period to big to calculate HW parameters\n"); > + return -EINVAL; > + } > + > /* Calculate the period cycles and prescale value */ > cycles *=3D clkrate; > do_div(cycles, NSEC_PER_SEC); > = > Is this sensible? (Actually I'd prefer to just continue with > = > period =3D (ULL(1) << (64 - fls(clkrate))) - 1 > = > according to the motto to yield the highest possible period, but this > function has another error path that returns -EINVAL so this would be > inconsistent.) Shouldn't that be -ERANGE? I do think it is better to return an error and let userspace decide what is the policy instead of having the policy in the driver. -- = Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel