From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AFCC433B4 for ; Wed, 21 Apr 2021 16:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06F556140F for ; Wed, 21 Apr 2021 16:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238558AbhDUQ1Z (ORCPT ); Wed, 21 Apr 2021 12:27:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:55236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235040AbhDUQ1X (ORCPT ); Wed, 21 Apr 2021 12:27:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93C1C61409; Wed, 21 Apr 2021 16:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619022410; bh=+fWm8kUa50XqXMGb9xC/2ssHISS6wpy9ziTFDq0kZ1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gJJAk4v6zYhLjMF3z50WJUpFXd8JfEmMJEf6Bald9M0HKvQ4YB9CPPiQ6Cn5DX9Pi F7ymDKLsI+9VkBLl3IDZjh4uYvK4Oci94yqEExzg2oOpb2JyjTOvotMTMPYr07j3K7 JSR6q7m1ezUTHayCkcEmRGMqXsc6x1s7Ga5jhntU= Date: Wed, 21 Apr 2021 18:26:47 +0200 From: Greg Kroah-Hartman To: Paul Moore Cc: linux-kernel@vger.kernel.org, Wenwen Wang , Richard Guy Briggs Subject: Re: [PATCH 085/190] Revert "audit: fix a memory leak bug" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-86-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 12:18:44PM -0400, Paul Moore wrote: > On Wed, Apr 21, 2021 at 9:04 AM Greg Kroah-Hartman > wrote: > > > > This reverts commit 70c4cf17e445264453bc5323db3e50aa0ac9e81f. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Wenwen Wang > > Cc: Richard Guy Briggs > > Cc: Paul Moore > > Signed-off-by: Greg Kroah-Hartman > > --- > > kernel/auditfilter.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > NACK on this revert. I've looked at the original patch again this > morning, and the original patch still looks correct and doesn't appear > to introduce any new faults to the best of my understanding. > Thanks for the review, much appreciate it, I'll drop it. greg k-h