From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83008C433ED for ; Thu, 22 Apr 2021 09:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50E09600EF for ; Thu, 22 Apr 2021 09:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235513AbhDVJpJ (ORCPT ); Thu, 22 Apr 2021 05:45:09 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:49999 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235809AbhDVJpE (ORCPT ); Thu, 22 Apr 2021 05:45:04 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7C9B610AC; Thu, 22 Apr 2021 05:44:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 22 Apr 2021 05:44:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EAVKBY RCUAxx+DP9lvwCNC3TR2gLoQFsbf+1d0aMdVU=; b=uiFlVsX4DID8iQBUYF9f5U bSGiHTwcaMQXm6wG+Sueh09iJxKcE92qafU865L3BgQUHkqONE8l/dzE8xc2sU46 P4HeAVD+U1IoxGAlVvolNDt+JrI30sC2Y3eX/iJZLifaot9YDEJzu84wh3qbRt+B Lp6A127qQWG6TCPAj8Mv8jcc2QoNFvq5RsiI0ox+40ZRQBAMXCJxOOfj0zI8OUbr /ROOY+qCCnljvk0c/Lm7B+NJi2rDvO5CJcthkpjHgB+S6DxB5uDEo5KpaHn8BDuE U0tr0qQ3uYmrGzKt+WSkXIteFoHg9gmKxnP2ZFE1dWgsEKlVoUnNTrtZh5RslSuQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddutddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtro dttddtvdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiugho shgthhdrohhrgheqnecuggftrfgrthhtvghrnhepgfejvefhvdegiedukeetudevgeeuje efffeffeetkeekueeuheejudeltdejuedunecukfhppeekgedrvddvledrudehfedrudek jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (igld-84-229-153-187.inter.net.il [84.229.153.187]) by mail.messagingengine.com (Postfix) with ESMTPA id 555A6108005F; Thu, 22 Apr 2021 05:44:27 -0400 (EDT) Date: Thu, 22 Apr 2021 12:44:24 +0300 From: Ido Schimmel To: Jakub Kicinski Cc: mkubecek@suse.cz, netdev@vger.kernel.org, Ido Schimmel Subject: Re: [PATCH ethtool-next 7/7] netlink: stats: add on --all-groups option Message-ID: References: <20210420003112.3175038-1-kuba@kernel.org> <20210420003112.3175038-8-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210420003112.3175038-8-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 19, 2021 at 05:31:12PM -0700, Jakub Kicinski wrote: > Add a switch for querying all statistic groups available > in the kernel. > > To reject --groups and --all-groups being specified > for one request add a concept of "parameter equivalency" > in the parser. Alternative of having a special group > type like "--groups all" seems less clean. > > Suggested-by: Ido Schimmel > Signed-off-by: Jakub Kicinski Tested-by: Ido Schimmel Thanks!