From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB7DC433ED for ; Thu, 22 Apr 2021 12:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 060E7613C9 for ; Thu, 22 Apr 2021 12:20:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236216AbhDVMUf (ORCPT ); Thu, 22 Apr 2021 08:20:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:33418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235232AbhDVMUe (ORCPT ); Thu, 22 Apr 2021 08:20:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A09E861458; Thu, 22 Apr 2021 12:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619094000; bh=Wr0OhYhDfMPeG2IHpq9JA+nWcwCtRYKEEDdMNXqNT9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LlaLFhYwpL5KwHSeR+kWjYsDL/tsJ53z++3kDhDn76NrrSsP7VizhfXGQyIbXDoqb LJZ8mRtqqeFGV1Q8FDHsud8Q17LECv/AEoLpPNly3nyWYZtcAhFZdQm75qDzi5K+CU 0FqxfTjCfYUtjkBT56BenF/rsDnUW62chd9fKHL8CYa3tPqiehAIWZaa30RoU9mGl6 V59vWyrsISfh6puiMCNpZBbUjywKOXpSeNu+H0oCQEB5l5hNk6uAJFu7ybD+AkaS2C RRBa4F2UAmwnAb9qcAuFRpEbVSRLTjZYn3bSC9Tuad642ys+HkqBTTOCK45NDMDPIS dw8AordqXki3g== Date: Thu, 22 Apr 2021 15:19:53 +0300 From: Mike Rapoport To: Anshuman Khandual Cc: linux-mm@kvack.org, david@redhat.com, akpm@linux-foundation.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes Message-ID: References: <20210422061902.21614-1-rppt@kernel.org> <1619077823-3819-1-git-send-email-anshuman.khandual@arm.com> <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 04:53:36PM +0530, Anshuman Khandual wrote: > On 4/22/21 1:57 PM, Mike Rapoport wrote: ... > >> diff --git a/mm/memblock.c b/mm/memblock.c > >> index 3abf2c3fea7f..93f8a9c8428d 100644 > >> --- a/mm/memblock.c > >> +++ b/mm/memblock.c > >> @@ -1740,6 +1740,7 @@ bool __init_memblock memblock_is_memory(phys_addr_t addr) > >> { > >> return memblock_search(&memblock.memory, addr) != -1; > >> } > >> +EXPORT_SYMBOL(memblock_is_memory); > > > > Please make it inside #ifdef CONFIG_ARCH_MEMBLOCK > CONFIG_ARCH_KEEP_MEMBLOCK ? Yeah, _KEEP went away somehow :) > Wrap it around the EXPORT_SYMBOL() or the entire function > memblock_is_memory(). EXPORT_SYMBOL(). Otherwise we'll have exported __init function. -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E1E6C433ED for ; Thu, 22 Apr 2021 12:22:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E72A16142F for ; Thu, 22 Apr 2021 12:22:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E72A16142F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sv6LiVNN9NsVWpf8K1zzomH3Tkifsq2HMt9gu0L68MI=; b=jDr5T7pYdMIHVnQvhp5wHIUJz 62UDsFqJuTHSmEbPKsSmX10UT2xhzgr5zdeFVkgZfgADEDJFxjYzlTumkdY6+PijWOoR68mFVloR/ 5rLj9vLAxJ5jDx2T7cByAi4+mr9S16aoHe3xoS1y/V3nhl5u08EShQ0q+Edj/NYeSo8v3lJFJKMmE hceqFaa7DqaSwq1XSThfDxmU05qnmW+QVADEJll2jgkj7HKlG7wqkcVjLac8Jy8W40LOwKOmOXQCC vbTGXHPvSz8PHOhbb+/Zx+rBWEmvCWlnBnG18OlEKPGiHP8EZjIiUJIISTPPuqgBmG0cEiV9P/fCW wsGCIiTig==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZYJR-00GfzZ-MZ; Thu, 22 Apr 2021 12:20:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZYJP-00GfzN-T5 for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 12:20:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zWnc0or91jjCEs+VLrJWEy7Rsp0+brxCtVa//4TaJEE=; b=1A5slQhLJA8GmhXzdSTkO4/q5+ XhIpdD5qDe//9DYBjAVl0IT2i5gKuS7AhXGG5Fgt+LDQyxWv6kCFhqeBAdfojC4y/p3r04c598g4x OREQEvD+XSf9G4pL1raDsXkI5OK5npiv4LtPS5EOQBdB+LO5n1QSJINfDA3EGrnrd/Xcrsl6YklAj DpY7wAxB4a1/k+D6sD72w0TpReLRkb2ZiFBEWRcAjCZk4r1j6d03B4G2BazXpXRbKoWK1OQhfwWLt KtDe5JlS/ZqmJVAy12JhzH4BMD23Up7D9yCRvVe7cYK8i7Nboy7APKwaI43cwKMr1K2fYkXVZMukT FVq76yjA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZYJN-00DfJY-Gh for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 12:20:02 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A09E861458; Thu, 22 Apr 2021 12:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619094000; bh=Wr0OhYhDfMPeG2IHpq9JA+nWcwCtRYKEEDdMNXqNT9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LlaLFhYwpL5KwHSeR+kWjYsDL/tsJ53z++3kDhDn76NrrSsP7VizhfXGQyIbXDoqb LJZ8mRtqqeFGV1Q8FDHsud8Q17LECv/AEoLpPNly3nyWYZtcAhFZdQm75qDzi5K+CU 0FqxfTjCfYUtjkBT56BenF/rsDnUW62chd9fKHL8CYa3tPqiehAIWZaa30RoU9mGl6 V59vWyrsISfh6puiMCNpZBbUjywKOXpSeNu+H0oCQEB5l5hNk6uAJFu7ybD+AkaS2C RRBa4F2UAmwnAb9qcAuFRpEbVSRLTjZYn3bSC9Tuad642ys+HkqBTTOCK45NDMDPIS dw8AordqXki3g== Date: Thu, 22 Apr 2021 15:19:53 +0300 From: Mike Rapoport To: Anshuman Khandual Cc: linux-mm@kvack.org, david@redhat.com, akpm@linux-foundation.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes Message-ID: References: <20210422061902.21614-1-rppt@kernel.org> <1619077823-3819-1-git-send-email-anshuman.khandual@arm.com> <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_052001_611927_03DED08A X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 22, 2021 at 04:53:36PM +0530, Anshuman Khandual wrote: > On 4/22/21 1:57 PM, Mike Rapoport wrote: ... > >> diff --git a/mm/memblock.c b/mm/memblock.c > >> index 3abf2c3fea7f..93f8a9c8428d 100644 > >> --- a/mm/memblock.c > >> +++ b/mm/memblock.c > >> @@ -1740,6 +1740,7 @@ bool __init_memblock memblock_is_memory(phys_addr_t addr) > >> { > >> return memblock_search(&memblock.memory, addr) != -1; > >> } > >> +EXPORT_SYMBOL(memblock_is_memory); > > > > Please make it inside #ifdef CONFIG_ARCH_MEMBLOCK > CONFIG_ARCH_KEEP_MEMBLOCK ? Yeah, _KEEP went away somehow :) > Wrap it around the EXPORT_SYMBOL() or the entire function > memblock_is_memory(). EXPORT_SYMBOL(). Otherwise we'll have exported __init function. -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel