From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0178DC43460 for ; Thu, 22 Apr 2021 12:19:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9DFF61452 for ; Thu, 22 Apr 2021 12:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236189AbhDVMTt (ORCPT ); Thu, 22 Apr 2021 08:19:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35546 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235232AbhDVMTp (ORCPT ); Thu, 22 Apr 2021 08:19:45 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lZYIM-000Uj3-4U; Thu, 22 Apr 2021 14:18:58 +0200 Date: Thu, 22 Apr 2021 14:18:58 +0200 From: Andrew Lunn To: Ilya Lipnitskiy Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 05/14] net: ethernet: mtk_eth_soc: reduce MDIO bus access latency Message-ID: References: <20210422040914.47788-1-ilya.lipnitskiy@gmail.com> <20210422040914.47788-6-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422040914.47788-6-ilya.lipnitskiy@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 09:09:05PM -0700, Ilya Lipnitskiy wrote: > From: Felix Fietkau > > usleep_range often ends up sleeping much longer than the 10-20us provided > as a range here. This causes significant latency in mdio bus acceses, I found the same with the FEC driver, and make the same change. > Signed-off-by: Felix Fietkau > [Ilya: use readx_poll_timeout_atomic instead of cond_resched] > Signed-off-by: Ilya Lipnitskiy Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09CC6C433ED for ; Thu, 22 Apr 2021 12:19:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC2BE613FA for ; Thu, 22 Apr 2021 12:19:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC2BE613FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5ftjTF2NCQNWXnii97R/PGrAfTjqhsy/wlZdGI/AZxk=; b=mAqCwklrLEwpbMplSFkTBjhgT luKsz3TkC6eQ0bOnW2wFH3UYcX6gwwo2rnZMrUw4KgBbgGOrLeTCK3IddfWFIzCgWzY9GGWEP38zj ILI1RHTLOHBsAfU63Ei/d2VoNUi0+VM6Ap4+8TinZGb02OycTR2ViOXXTjKFzWB/MwOPATufXPEk7 F9H9MknQAk8WBcI5FjngypfYqBK2qeagxI5wHuvEj270RvFvXzU/6BlthoRcjcmvuUQuze6EPRZdh kF0DOzsVXsfoE/TAdgeSoUt5KqiU6HL8W+e7fn+HpMUEFsYNMNys6ad/v1QZ4Swl2PA/MyYxeExmm zT4m5x50g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZYIu-00Gfvg-O8; Thu, 22 Apr 2021 12:19:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZYIg-00Gfus-9O; Thu, 22 Apr 2021 12:19:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UrYnyGTCCxyN2/jKEP5GreCc5IAqvJnszjWMM5BM604=; b=YtjYMJwdZW+ylt0b/jxO+SLAhx DHoUwolKZlMUSJRcYCTyt0NpcB8mtm+wzQd/XExjvKy6gkqHLZo0/659WZy36yZe/MOQ4v7B+kG6T k1RpMA0tfP/tmj9ukQZqIhXDhciBEYzis9KOm3SxLSltJAHeDcyCBhAQL/fca/eocgYQiKmsQhIA8 dm/FOUs9CbF/xfMTOrAXp/yzVWqf4UBkWEv4aDExDHZLia/Tu5pQHXCj+nMZBexcMaZNmo+xXDQlI cPUWzGcgt2N4iszCX2Zl4OsSyPH+OhlpByL5k9x/oXLntJwux82FtZnw3BQGaemR2NM1G4TDfFgKy WXRa2OiQ==; Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZYId-00DfHJ-N8; Thu, 22 Apr 2021 12:19:17 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lZYIM-000Uj3-4U; Thu, 22 Apr 2021 14:18:58 +0200 Date: Thu, 22 Apr 2021 14:18:58 +0200 From: Andrew Lunn To: Ilya Lipnitskiy Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 05/14] net: ethernet: mtk_eth_soc: reduce MDIO bus access latency Message-ID: References: <20210422040914.47788-1-ilya.lipnitskiy@gmail.com> <20210422040914.47788-6-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210422040914.47788-6-ilya.lipnitskiy@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_051915_775951_CB563D22 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Apr 21, 2021 at 09:09:05PM -0700, Ilya Lipnitskiy wrote: > From: Felix Fietkau > > usleep_range often ends up sleeping much longer than the 10-20us provided > as a range here. This causes significant latency in mdio bus acceses, I found the same with the FEC driver, and make the same change. > Signed-off-by: Felix Fietkau > [Ilya: use readx_poll_timeout_atomic instead of cond_resched] > Signed-off-by: Ilya Lipnitskiy Reviewed-by: Andrew Lunn Andrew _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1314C433B4 for ; Thu, 22 Apr 2021 12:21:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8321F61164 for ; Thu, 22 Apr 2021 12:21:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8321F61164 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bAlUa7HNk7gUPsYvoA4Dfs0a67ubMrft009G7bhT854=; b=msTIAKJNZ9GpflMT5AD3/Mf+1 rSQ8ElgL4USIrYg/AYXuGY3vp7B5advsto/Qx6Tm4kNHIgntOW/3Ekv/UTtZZG2vPLUezGyUymkdo 3PVmMSPkgQ7m8oF9iCIpl6/fFS6QW0oQRrwMLTPriwNy50xcEF8Un+Of9tVoWRl2c07WixduyLJZu SsL2ZkTyAiV8iGJqvmIsB8i50EnlG1OHo8YNIG0qC483+RR1+6emsAm/oRSZLKX5eDcW/lj9ddd31 foOlen3VtLX4R0Hz6vQoa0/DAevooNzn7artcXNcwLG638rqYGbRONnGLyi5i0AaAnhnvuB7mmRWr 5zr6M9hMw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZYIl-00Gfv7-NI; Thu, 22 Apr 2021 12:19:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZYIg-00Gfus-9O; Thu, 22 Apr 2021 12:19:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UrYnyGTCCxyN2/jKEP5GreCc5IAqvJnszjWMM5BM604=; b=YtjYMJwdZW+ylt0b/jxO+SLAhx DHoUwolKZlMUSJRcYCTyt0NpcB8mtm+wzQd/XExjvKy6gkqHLZo0/659WZy36yZe/MOQ4v7B+kG6T k1RpMA0tfP/tmj9ukQZqIhXDhciBEYzis9KOm3SxLSltJAHeDcyCBhAQL/fca/eocgYQiKmsQhIA8 dm/FOUs9CbF/xfMTOrAXp/yzVWqf4UBkWEv4aDExDHZLia/Tu5pQHXCj+nMZBexcMaZNmo+xXDQlI cPUWzGcgt2N4iszCX2Zl4OsSyPH+OhlpByL5k9x/oXLntJwux82FtZnw3BQGaemR2NM1G4TDfFgKy WXRa2OiQ==; Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZYId-00DfHJ-N8; Thu, 22 Apr 2021 12:19:17 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lZYIM-000Uj3-4U; Thu, 22 Apr 2021 14:18:58 +0200 Date: Thu, 22 Apr 2021 14:18:58 +0200 From: Andrew Lunn To: Ilya Lipnitskiy Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 05/14] net: ethernet: mtk_eth_soc: reduce MDIO bus access latency Message-ID: References: <20210422040914.47788-1-ilya.lipnitskiy@gmail.com> <20210422040914.47788-6-ilya.lipnitskiy@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210422040914.47788-6-ilya.lipnitskiy@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_051915_775951_CB563D22 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 21, 2021 at 09:09:05PM -0700, Ilya Lipnitskiy wrote: > From: Felix Fietkau > > usleep_range often ends up sleeping much longer than the 10-20us provided > as a range here. This causes significant latency in mdio bus acceses, I found the same with the FEC driver, and make the same change. > Signed-off-by: Felix Fietkau > [Ilya: use readx_poll_timeout_atomic instead of cond_resched] > Signed-off-by: Ilya Lipnitskiy Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel