From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 501DDC43460 for ; Fri, 23 Apr 2021 00:09:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22A8D61008 for ; Fri, 23 Apr 2021 00:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240038AbhDWAJl (ORCPT ); Thu, 22 Apr 2021 20:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235977AbhDWAJj (ORCPT ); Thu, 22 Apr 2021 20:09:39 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A34B7C06174A for ; Thu, 22 Apr 2021 17:09:03 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id g1-20020a17090adac1b0290150d07f9402so233942pjx.5 for ; Thu, 22 Apr 2021 17:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nMfzkQEov6kIVHNuaAn8iFcBDyLGbYrJQC6NcLJ8Y0k=; b=MOieLRc2dtfBssKc/drPE5jrnqhvaOSHoX1ikwjvgMyDtGflicbL5w6KTO5ZxViai7 kbByOq81BuV6XajiwS2fhVpdRigaLp8UnuwZjexAwNKeblgLrirAMrEs11+DjBVnj5cG ygYwgdov1P3rUjQ4D6Nx7diFlsnBhOB6L0b8ZTvbyjqFKw0WpxQnhf2+T6Q1q/QIq90d mpdOgZ8Jnpk9RKFnAMLfHdFw8JTdjTISf6yQcL4wxr4GwC/Fj2HJQ+pf3ICh7xPT6YnR oryyzeAOW1bMSYxI4Px1yvJ5zcPtzyY+5AOk49SBpNN426ZjX7VgqrksC1X52ltOHhYQ VelA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nMfzkQEov6kIVHNuaAn8iFcBDyLGbYrJQC6NcLJ8Y0k=; b=DBuqsyW+VcrDPS9oQce4cEuBG9RkEpZUifYmKUAitNjbyuORg5Dhkol0vrSXjhaRor 7GOWeT3k9ZNPlRNSD9Gm6WhzmTyVtza7VZ7CHhzel8GHj5LF32xdkpn2OY3Cx3pAEnLj bcaf+87LsAMeb/EKfKp1NOQGbp68Gd+CX7gdg2tRThNJ0pgTk8BC3wRDaKFphVkYAQUJ QNtIVwjZ12gQXUerV6Dfv0VBjnIUuDpgMgii5qYKz8sJyfeuEc/t4T+jk9TiW7IOgGVH /+x61mRgfYaJEvn49X9SMnR+Bvjpff1OjksGea++CTlBxbA/bZIZAiSqUljhvvfjSkER 0isw== X-Gm-Message-State: AOAM531zPIV9b0xQcDNbI3nyBQNb+RtiCy0pLEJCCFdnrqId0/4QY9vb WwmtTWRReOzqZcF3GO39rrOzgw== X-Google-Smtp-Source: ABdhPJybGByf1Kk9YiSc1IOkyXvmd9WNT9e++V5g4QLN7WhkKtqrQ2uDQMiVse4F9jCpZfXPv2zbXw== X-Received: by 2002:a17:902:e904:b029:eb:73f6:ac99 with SMTP id k4-20020a170902e904b02900eb73f6ac99mr1069354pld.12.1619136543044; Thu, 22 Apr 2021 17:09:03 -0700 (PDT) Received: from google.com (150.12.83.34.bc.googleusercontent.com. [34.83.12.150]) by smtp.gmail.com with ESMTPSA id w123sm2906742pfb.109.2021.04.22.17.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Apr 2021 17:09:02 -0700 (PDT) Date: Thu, 22 Apr 2021 17:08:58 -0700 From: Ricardo Koller To: Paolo Bonzini Cc: kvm@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "H. Peter Anvin" , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 3/5] tools headers x86: Copy cpuid helpers from the kernel Message-ID: References: <20210422005626.564163-1-ricarkol@google.com> <20210422005626.564163-4-ricarkol@google.com> <404e903a-5752-6ab2-9b46-aa40f7fb0fba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <404e903a-5752-6ab2-9b46-aa40f7fb0fba@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 08:59:50AM +0200, Paolo Bonzini wrote: > On 22/04/21 02:56, Ricardo Koller wrote: > > Copy arch/x86/include/asm/acpufeature.h and arch/x86/kvm/reverse_cpuid.h > > from the kernel so that KVM selftests can use them in the next commits. > > Also update the tools copy of arch/x86/include/asm/acpufeatures.h. > > Typo. > > > These should be kept in sync, ideally with the help of some script like > > check-headers.sh used by tools/perf/. > > Please provide such a script. > > Also, without an automated way to keep them in sync I think it's better to > copy all of them to tools/testing/selftests/kvm Will move them to the kvm subdir. The only issue is cpufeatures.h as that would create a third copy of it: there is one already at tools/arch/x86/include/asm/cpufeatures.h. Note that we can't move cpufeatures.h from tools/arch/x86/include/asm to tools/testing/selftests/kvm as it's already included by others like tools/perf. > so that we can be sure that > a maintainer (me) runs the script and keeps them up to date. I am fairly > sure that the x86 maintainers don't want to have anything to do with all of > this business! > > Paolo > Thanks for the review! I'll try this approach for the next version: copy the new headers to tools/testing/selftests/kvm (except cpufeatures.h), and add the script.