From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E46C433B4 for ; Fri, 23 Apr 2021 13:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC7BB61463 for ; Fri, 23 Apr 2021 13:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236064AbhDWNZj (ORCPT ); Fri, 23 Apr 2021 09:25:39 -0400 Received: from mga12.intel.com ([192.55.52.136]:31798 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhDWNZg (ORCPT ); Fri, 23 Apr 2021 09:25:36 -0400 IronPort-SDR: kK0FOKpcJsrVU5ds7uOD45vpKD5enBULxfLehoun9FPz+s+dUqUjrCnZxsnhMZKTMcRF8bu0Um 8XKmNBmVRJmw== X-IronPort-AV: E=McAfee;i="6200,9189,9963"; a="175551467" X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="175551467" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 06:24:59 -0700 IronPort-SDR: fU1MwX/zwew2GLGuBMdwnSfJshhZBEqFxXeg9B7pmIkZEYkobjV2mCQOh8Iy5uLxNUnvqaJ/o1 edoxgT6ZBkWQ== X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="456222695" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 06:24:56 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lZvnh-006ZPI-4z; Fri, 23 Apr 2021 16:24:53 +0300 Date: Fri, 23 Apr 2021 16:24:53 +0300 From: Andy Shevchenko To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , linux-doc@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH v5 05/13] module: Add printk formats to add module build ID to stacktraces Message-ID: References: <20210420215003.3510247-1-swboyd@chromium.org> <20210420215003.3510247-6-swboyd@chromium.org> <161913520061.46595.8469966711677906076@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161913520061.46595.8469966711677906076@swboyd.mtv.corp.google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 04:46:40PM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2021-04-21 04:49:33) > > On Tue, Apr 20, 2021 at 02:49:55PM -0700, Stephen Boyd wrote: ... > > > Example: > > > > Please, shrink the example to leave only meaningful lines. > > > > Why, e.g., do we need to see register dump, is it somehow different? > > Can you format it how you would like to see it? Should it be a unified > diff? I agree it would help to see "what changed" but also don't know > what you want so opted to provide more information, not less. I was > worried about the questions like "do you change other parts of a splat?" > so I just put the whole thing there. Before: ...line X... ... ...line Y... After: ...line X'... ... ...line Y'... Three lines of example per each paragraph, in each of them the middle one is simply [...]. ... > > > +#ifdef CONFIG_STACKTRACE_BUILD_ID > > > + /* Module build ID */ > > > + unsigned char build_id[BUILD_ID_SIZE_MAX]; > > > > Is it really string of characters? Perhaps u8 will be more explicit. > > I'm just matching the build ID API that uses unsigned char. If you want > u8 then we should update more places. I could do that in a followup > patch, but this one is already sorta big. Unsigned char here is confusing. I would prefer a prerequisite patch to fix other places first. ... > > > +#include > > > > What do you need this header for? > > > > For typeof_member(). Argh... We really need to split this and container_of to something else. Having entire kernel.h for that is an overkill. -- With Best Regards, Andy Shevchenko