From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209D7C433ED for ; Fri, 23 Apr 2021 13:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2F5461445 for ; Fri, 23 Apr 2021 13:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbhDWNZk (ORCPT ); Fri, 23 Apr 2021 09:25:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:45962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238784AbhDWNZj (ORCPT ); Fri, 23 Apr 2021 09:25:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 575FB613C8; Fri, 23 Apr 2021 13:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619184303; bh=h1qY378UMQdddxG9UZ6KBaWxcknWZJ3Q+JYiQACCZFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kywQkQZPg2x4C0fM82+FM8X+MMdsm332yVNP3DX5CFaxfXXLNPFp+8pYDoSUuEeOA JZ7mLesloIiNcotMujf8LqvTDyKsOWuDTGT5/1Ev4xjGNCszISFAb9j99eO9WbkrUL RE2QpIRmI5qt+DKtW+W4hJtWuGRDK/kcvAVPCaUP5DU70IPg1EfMhmhEOXsbIYtQnI mItjZAK5/OEIDgPe5ARwsqCcEjRp4q+niQ+l+BHZBiYFHzTtQ38A87kDlFq0Nbn7V3 apm6M2gfjoDw28ax64pRSrYZSjsbzxnUx4FaOCjbqX5Y3mBOvAtaUK/o3MWl70cNwA Nf9hdS025bt0w== Date: Fri, 23 Apr 2021 18:54:59 +0530 From: Vinod Koul To: Lars-Peter Clausen Cc: Adrian Larumbe , dmaengine@vger.kernel.org, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] Expand Xilinx CDMA functions Message-ID: References: <20210423011913.13122-1-adrian.martinezlarumbe@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 23-04-21, 11:17, Lars-Peter Clausen wrote: > > It seems to me what we are missing from the DMAengine API is the equivalent > of device_prep_dma_memcpy() that is able to take SG lists. There is already > a memset_sg, it should be possible to add something similar for memcpy. You mean something like dmaengine_prep_dma_sg() which was removed? static inline struct dma_async_tx_descriptor *dmaengine_prep_dma_sg( struct dma_chan *chan, struct scatterlist *dst_sg, unsigned int dst_nents, struct scatterlist *src_sg, unsigned int src_nents, unsigned long flags) The problem with this API is that it would work only when src_sg and dst_sg is of similar nature, if not then how should one go about copying...should we fill without a care for dst_sg being different than src_sg as long as total data to be copied has enough space in dst... We can always add this back if we have in-kernel user but the semantics of the API needs to be thought thru Thanks -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A77FC433B4 for ; Fri, 23 Apr 2021 13:27:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3D2361445 for ; Fri, 23 Apr 2021 13:27:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3D2361445 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TmBuzrejfwNXkebO1uA3CBCBwSgTENLWIhhw/wsb0AY=; b=K+3stMQs3cOQiX9GWmT6HAw3D E9sYL4BBdWNOzW6J2oAAqJcNpM6IUAgnkacBGd3ixL24VUIK7Ap6yqh8pdyVp2QJrkdw3uZOFybVq 1m95VlEyWK9khG9zHhi1NGH+tuzVWhKyhrvKZbE9hVVs9zSfZqh/HVy2oXVHTBn4wU5V/mTBalqVe a4ZcQkFYRJ2SSX2AzISM8oMBOGYTUURhzkaFe/K6Y/ApMNNn7d/WsWuZRY5Qzca9t8ADmr9DNj3FN hOgdk3/4Gtt7Y2WKV0l6DATaTsUsrNUsbnlH2kIgEnVh+zSYPL/pFW39czJFw03BplKzuq0UCBGjB qOaeU29mw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZvo2-001YPD-US; Fri, 23 Apr 2021 13:25:15 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZvo0-001YOs-0j for linux-arm-kernel@desiato.infradead.org; Fri, 23 Apr 2021 13:25:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/y+cymbax0mgBB4waHTJGPGY1JFpq0dNijOeGKmftn8=; b=2WALSuJ3JY+eveFl5AaFIdxo9k Bu95E27FYZDa1RUz6EUO6eJvR2wwXsRNG0VqD20L4z9UqAyPi9ceRdX4HybwXD9475q+G0/yCqItG 8YbGFE/B8BzXS4FszPwYt9FbXMSUlPMQmRi7+EKeUy7918JH7JZhYqgYG0zS+/OyPmjTbss34TTMF z9HtXS23xnc0CWR/5GSx2CYWQYa9Oh0I7mjlHy45EQFsbsKKOktdNy6cTuNb+7CbgK8r2aVML4Ha7 NnzTKRmt0XyKDk7+nf6XXnor5C865Gh8Wmb3d6PKrxy3N+pR+B69ZnO/L9HO7WY+S29tzDN3MEwlQ 2hgujXHQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZvnw-00EQPD-0R for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 13:25:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 575FB613C8; Fri, 23 Apr 2021 13:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619184303; bh=h1qY378UMQdddxG9UZ6KBaWxcknWZJ3Q+JYiQACCZFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kywQkQZPg2x4C0fM82+FM8X+MMdsm332yVNP3DX5CFaxfXXLNPFp+8pYDoSUuEeOA JZ7mLesloIiNcotMujf8LqvTDyKsOWuDTGT5/1Ev4xjGNCszISFAb9j99eO9WbkrUL RE2QpIRmI5qt+DKtW+W4hJtWuGRDK/kcvAVPCaUP5DU70IPg1EfMhmhEOXsbIYtQnI mItjZAK5/OEIDgPe5ARwsqCcEjRp4q+niQ+l+BHZBiYFHzTtQ38A87kDlFq0Nbn7V3 apm6M2gfjoDw28ax64pRSrYZSjsbzxnUx4FaOCjbqX5Y3mBOvAtaUK/o3MWl70cNwA Nf9hdS025bt0w== Date: Fri, 23 Apr 2021 18:54:59 +0530 From: Vinod Koul To: Lars-Peter Clausen Cc: Adrian Larumbe , dmaengine@vger.kernel.org, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] Expand Xilinx CDMA functions Message-ID: References: <20210423011913.13122-1-adrian.martinezlarumbe@imgtec.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210423_062508_114759_F78AF086 X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-04-21, 11:17, Lars-Peter Clausen wrote: > > It seems to me what we are missing from the DMAengine API is the equivalent > of device_prep_dma_memcpy() that is able to take SG lists. There is already > a memset_sg, it should be possible to add something similar for memcpy. You mean something like dmaengine_prep_dma_sg() which was removed? static inline struct dma_async_tx_descriptor *dmaengine_prep_dma_sg( struct dma_chan *chan, struct scatterlist *dst_sg, unsigned int dst_nents, struct scatterlist *src_sg, unsigned int src_nents, unsigned long flags) The problem with this API is that it would work only when src_sg and dst_sg is of similar nature, if not then how should one go about copying...should we fill without a care for dst_sg being different than src_sg as long as total data to be copied has enough space in dst... We can always add this back if we have in-kernel user but the semantics of the API needs to be thought thru Thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel