From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E6BC433B4 for ; Fri, 23 Apr 2021 15:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B97861463 for ; Fri, 23 Apr 2021 15:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbhDWPPz (ORCPT ); Fri, 23 Apr 2021 11:15:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbhDWPPy (ORCPT ); Fri, 23 Apr 2021 11:15:54 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27686C061574 for ; Fri, 23 Apr 2021 08:15:18 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id n140so49457160oig.9 for ; Fri, 23 Apr 2021 08:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H20jNSQBl2MjyzyhkMYaw3Uy+F10G5cykrLW0bCJkBA=; b=pbgHZ7XQhrdOvbvAEjMyl0uK0HMUgeZJJF+ej6t7BPq/nAAOkrIUydX+1QHj4u3KvE pLJIkbIJwMGOu2yzI3poPk98hnq8bSFyQsAtWmghJefxSFUCF5GgUMakEzY/G52IecyX N6vnUWZQjFjsNFgoTDl14F24ZjuyimIj9GRrfxpXByaXYg6s8L10Jnibgr7D8hc4giuF 9f9P1y+QA4CxKMKY70bvbYeAP0qqZg1jXldsiydJzBDv6EDSTapmYebrwv5u129V0FFd m648IZf/e0ns6mu6mKhFtYsSa+kbirPQhcKZNtXvnLauhKVBdnelRFhMWp3L6ty0K8Yw ck1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H20jNSQBl2MjyzyhkMYaw3Uy+F10G5cykrLW0bCJkBA=; b=gZjbtEN+/Njs6SQnhO9C+O+xbqOb+b9K2LuVD4xldFmxKe7j45oQlYITrPKkAMqx4B 9qK05EO+WYn/Np/7kSKgAob0FBFY8uQ+w+CgJJ/TlVjEhtuCqewVHbQYZWNuWq/X2ZSC 1zc7U0olIpzSUxwpDG3GTBf2HwfVWsk7ucF3iRlX8LNAhlXUchplvq6t9jh3JoxvsLfL IG7m7t7OxipHKVvvroPWLDtOyZ43KBCFe3N9r4DJN8lDKfBnq+8iu0pTz5nySN1o2lfJ frljMlai3bF9gON4yGRwlRO3rEznaC2oK5xRKNw8utaABZF5T93Q6Z9aiVwRpVlZrD6r BeaQ== X-Gm-Message-State: AOAM530ty/spED5+4UfdceyVE/yFj6i+sO5E5Hy0IEfLPxarrSWMzCrS LCdO4VYWu06+1xSjiaFB3KZLxw== X-Google-Smtp-Source: ABdhPJweYNjzWUSWU6X45/xUm+r362Z1QMdsI+CBjPXjPS8ZOsGsSpPe5+cGwgePXKHxnPQi2QkCMg== X-Received: by 2002:aca:75cc:: with SMTP id q195mr4322750oic.88.1619190917554; Fri, 23 Apr 2021 08:15:17 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 88sm1422029otx.2.2021.04.23.08.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 08:15:17 -0700 (PDT) Date: Fri, 23 Apr 2021 10:15:15 -0500 From: Bjorn Andersson To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , Stephen Boyd , robdclark@chromium.org, Maarten Lankhorst , Stanislav Lisovskiy , Steev Klimaszewski , linux-arm-msm@vger.kernel.org, Linus W , Daniel Vetter , David Airlie , Thierry Reding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 22/27] drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property() Message-ID: References: <20210416223950.3586967-1-dianders@chromium.org> <20210416153909.v4.22.Icb581b0273d95cc33ca38676c61ae6d7d2e75357@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416153909.v4.22.Icb581b0273d95cc33ca38676c61ae6d7d2e75357@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 16 Apr 17:39 CDT 2021, Douglas Anderson wrote: > As of commit 5186421cbfe2 ("drm: Introduce epoch counter to > drm_connector") the drm_get_edid() function calls > drm_connector_update_edid_property() for us. There's no reason for us > to call it again. > Reviewed-by: Bjorn Andersson > Signed-off-by: Douglas Anderson > --- > As Laurent pointed out [1] this is actually a pretty common > problem. His suggestion to do this more broadly is a good idea but > this series is probably a bit ambitious already so I would suggest > that be taken up separately. > > [1] https://lore.kernel.org/r/YGphgcESWsozCi1y@pendragon.ideasonboard.com > > (no changes since v1) > > drivers/gpu/drm/panel/panel-simple.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 90a17ca79d06..c91e8aa108f7 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -512,7 +512,6 @@ static int panel_simple_get_modes(struct drm_panel *panel, > if (p->ddc) { > struct edid *edid = drm_get_edid(connector, p->ddc); > > - drm_connector_update_edid_property(connector, edid); > if (edid) { > num += drm_add_edid_modes(connector, edid); > kfree(edid); > -- > 2.31.1.368.gbe11c130af-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3DAC433B4 for ; Fri, 23 Apr 2021 15:15:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 435DD6147D for ; Fri, 23 Apr 2021 15:15:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 435DD6147D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 896076EBFB; Fri, 23 Apr 2021 15:15:20 +0000 (UTC) Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16EA96E113 for ; Fri, 23 Apr 2021 15:15:18 +0000 (UTC) Received: by mail-oi1-x22e.google.com with SMTP id v6so21680094oiv.3 for ; Fri, 23 Apr 2021 08:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H20jNSQBl2MjyzyhkMYaw3Uy+F10G5cykrLW0bCJkBA=; b=pbgHZ7XQhrdOvbvAEjMyl0uK0HMUgeZJJF+ej6t7BPq/nAAOkrIUydX+1QHj4u3KvE pLJIkbIJwMGOu2yzI3poPk98hnq8bSFyQsAtWmghJefxSFUCF5GgUMakEzY/G52IecyX N6vnUWZQjFjsNFgoTDl14F24ZjuyimIj9GRrfxpXByaXYg6s8L10Jnibgr7D8hc4giuF 9f9P1y+QA4CxKMKY70bvbYeAP0qqZg1jXldsiydJzBDv6EDSTapmYebrwv5u129V0FFd m648IZf/e0ns6mu6mKhFtYsSa+kbirPQhcKZNtXvnLauhKVBdnelRFhMWp3L6ty0K8Yw ck1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H20jNSQBl2MjyzyhkMYaw3Uy+F10G5cykrLW0bCJkBA=; b=OjqyZDBtVgBLoZKRSwwFjh9tXQc9do995EAEJ46krydAx1XtKOiLRrsugk32OelzM5 OqTUgW1BtLJaZ0nBZu+hAdVWA4W5PqVfjvTjwsuntHskd1XuTRbN5i6aYj3YJBGkwZWN 1HmDk5dZI9mkIXIUK0hAskU4NGYC5i6z5AOripHBt69bpGjgnSJP35l3PgbBeiW1dYa8 y35kJ7mFypjeg275Qp0rRU75mZ42sTCfWoHx8Iy0uzVF0KgzqqMW8yuP6Jlw2sCuYNIu bWTQkmpVyrvd+15YKPtUhXh9s/9sHk3gCP7yqe7chy2BmN8nmmna2kC1dls5PQDnTSBH vGIw== X-Gm-Message-State: AOAM53046/hjv4ukHYhx6XqUTOLiGCqDCfKGnibn/K7RJjg676WOBt+R 6I0lNNMfRFRXEBQKhDolzPRSRw== X-Google-Smtp-Source: ABdhPJweYNjzWUSWU6X45/xUm+r362Z1QMdsI+CBjPXjPS8ZOsGsSpPe5+cGwgePXKHxnPQi2QkCMg== X-Received: by 2002:aca:75cc:: with SMTP id q195mr4322750oic.88.1619190917554; Fri, 23 Apr 2021 08:15:17 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 88sm1422029otx.2.2021.04.23.08.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 08:15:17 -0700 (PDT) Date: Fri, 23 Apr 2021 10:15:15 -0500 From: Bjorn Andersson To: Douglas Anderson Subject: Re: [PATCH v4 22/27] drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property() Message-ID: References: <20210416223950.3586967-1-dianders@chromium.org> <20210416153909.v4.22.Icb581b0273d95cc33ca38676c61ae6d7d2e75357@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210416153909.v4.22.Icb581b0273d95cc33ca38676c61ae6d7d2e75357@changeid> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Stanislav Lisovskiy , Jernej Skrabec , dri-devel@lists.freedesktop.org, Jonas Karlman , David Airlie , linux-arm-msm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, Steev Klimaszewski , Stephen Boyd , Wolfram Sang , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri 16 Apr 17:39 CDT 2021, Douglas Anderson wrote: > As of commit 5186421cbfe2 ("drm: Introduce epoch counter to > drm_connector") the drm_get_edid() function calls > drm_connector_update_edid_property() for us. There's no reason for us > to call it again. > Reviewed-by: Bjorn Andersson > Signed-off-by: Douglas Anderson > --- > As Laurent pointed out [1] this is actually a pretty common > problem. His suggestion to do this more broadly is a good idea but > this series is probably a bit ambitious already so I would suggest > that be taken up separately. > > [1] https://lore.kernel.org/r/YGphgcESWsozCi1y@pendragon.ideasonboard.com > > (no changes since v1) > > drivers/gpu/drm/panel/panel-simple.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 90a17ca79d06..c91e8aa108f7 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -512,7 +512,6 @@ static int panel_simple_get_modes(struct drm_panel *panel, > if (p->ddc) { > struct edid *edid = drm_get_edid(connector, p->ddc); > > - drm_connector_update_edid_property(connector, edid); > if (edid) { > num += drm_add_edid_modes(connector, edid); > kfree(edid); > -- > 2.31.1.368.gbe11c130af-goog > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel