From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B6FC433ED for ; Mon, 26 Apr 2021 09:36:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 750DD6135F for ; Mon, 26 Apr 2021 09:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232748AbhDZJgS (ORCPT ); Mon, 26 Apr 2021 05:36:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:55086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232685AbhDZJgR (ORCPT ); Mon, 26 Apr 2021 05:36:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D7EF46103E; Mon, 26 Apr 2021 09:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619429735; bh=bLpWGYOQ2/M+ci5Sjuq25051I+IODYqeokzOZ36nF9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ELRro1aqNRHwkv3KvqoNQ0Rl3kdWm1zeHFWfKZE/H7+mNlU5SwEghQ1xYhwZ+/eOA HYDFfGeY5F5VBxvyMppJrxg11d/jo9T6Q91CEyOKSfIGtUMh08bIadA6ryO7AFMRa0 RKJnBILHgbUg64CjoqoTgoS/lTF2ZNuM/fN3mABK1BqoAMM8TM0sIhJmqaxc+frkoT ZGhq6gntykkgXryFV6+2StcDX//W4x02FczsLjHnzID4r+rn6VHSolBeybt93RGD3T BHCWEecm+AL9UXBvlenkpQOJlAfqYGE8lDg7lLbHhFYWMXMJWa4gfzx+3hGpKwtGGL gOyymuXHDar6w== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1laxec-00045S-7F; Mon, 26 Apr 2021 11:35:46 +0200 Date: Mon, 26 Apr 2021 11:35:46 +0200 From: Johan Hovold To: Leonardo Antoniazzi Cc: linux-usb@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Greg Kroah-Hartman , Anirudh Rayabharam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hso: fix NULL-deref on disconnect regression Message-ID: References: <20210426081149.10498-1-johan@kernel.org> <20210426112911.fb3593c3a9ecbabf98a13313@aruba.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210426112911.fb3593c3a9ecbabf98a13313@aruba.it> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 26, 2021 at 11:29:11AM +0200, Leonardo Antoniazzi wrote: > On Mon, 26 Apr 2021 10:11:49 +0200 > Johan Hovold wrote: > > > Commit 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device > > unregistration") fixed the racy minor allocation reported by syzbot, but > > introduced an unconditional NULL-pointer dereference on every disconnect > > instead. > > > > Specifically, the serial device table must no longer be accessed after > > the minor has been released by hso_serial_tty_unregister(). > > > > Fixes: 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device unregistration") > > Cc: stable@vger.kernel.org > > Cc: Anirudh Rayabharam > > Reported-by: Leonardo Antoniazzi > > Signed-off-by: Johan Hovold > > --- > the patch fix the problem Thanks for confirming. Next time, please keep the CC list intact when replying so that everyone sees that you've tested it. Johan